| Message ID | 20200331214327.6496-6-digetx@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Support NVIDIA Tegra-based Acer A500 and Nexus 7 devices | expand |
On Wed, Apr 01, 2020 at 12:43:26AM +0300, Dmitry Osipenko wrote: > Add a binding for the Tegra30-based ASUS Google Nexus 7 tablet device. > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > Documentation/devicetree/bindings/arm/tegra.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/tegra.yaml b/Documentation/devicetree/bindings/arm/tegra.yaml > index 7fd0b66c69b2..fb3bbf7a5fb4 100644 > --- a/Documentation/devicetree/bindings/arm/tegra.yaml > +++ b/Documentation/devicetree/bindings/arm/tegra.yaml > @@ -62,6 +62,13 @@ properties: > - toradex,colibri_t30-eval-v3 > - const: toradex,colibri_t30 > - const: nvidia,tegra30 > + - items: > + - const: asus,grouper > + - const: nvidia,tegra30 > + - items: > + - const: asus,tilapia > + - const: asus,grouper > + - const: nvidia,tegra30 > - items: > - enum: > - nvidia,dalmore Is it really necessary to list every possible device using a SoC chip? Wouldn't it be enough to just list SoC value nvidia,tegraXYZ and allow any other supplemental "compatibles"? Best Regards, Michał Mirosław
02.04.2020 07:50, Michał Mirosław пишет: > On Wed, Apr 01, 2020 at 12:43:26AM +0300, Dmitry Osipenko wrote: >> Add a binding for the Tegra30-based ASUS Google Nexus 7 tablet device. >> >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> >> --- >> Documentation/devicetree/bindings/arm/tegra.yaml | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/tegra.yaml b/Documentation/devicetree/bindings/arm/tegra.yaml >> index 7fd0b66c69b2..fb3bbf7a5fb4 100644 >> --- a/Documentation/devicetree/bindings/arm/tegra.yaml >> +++ b/Documentation/devicetree/bindings/arm/tegra.yaml >> @@ -62,6 +62,13 @@ properties: >> - toradex,colibri_t30-eval-v3 >> - const: toradex,colibri_t30 >> - const: nvidia,tegra30 >> + - items: >> + - const: asus,grouper >> + - const: nvidia,tegra30 >> + - items: >> + - const: asus,tilapia >> + - const: asus,grouper >> + - const: nvidia,tegra30 >> - items: >> - enum: >> - nvidia,dalmore > > Is it really necessary to list every possible device using a SoC chip? Yes, otherwise make dtbs_check will give you a warning about the unknown compatible. > Wouldn't it be enough to just list SoC value nvidia,tegraXYZ and allow > any other supplemental "compatibles"? I don't know what was the initial intention of having boards defined in a way it's currently done, maybe Rob;Thierry;Stephen;Jon could clarify?
diff --git a/Documentation/devicetree/bindings/arm/tegra.yaml b/Documentation/devicetree/bindings/arm/tegra.yaml index 7fd0b66c69b2..fb3bbf7a5fb4 100644 --- a/Documentation/devicetree/bindings/arm/tegra.yaml +++ b/Documentation/devicetree/bindings/arm/tegra.yaml @@ -62,6 +62,13 @@ properties: - toradex,colibri_t30-eval-v3 - const: toradex,colibri_t30 - const: nvidia,tegra30 + - items: + - const: asus,grouper + - const: nvidia,tegra30 + - items: + - const: asus,tilapia + - const: asus,grouper + - const: nvidia,tegra30 - items: - enum: - nvidia,dalmore
Add a binding for the Tegra30-based ASUS Google Nexus 7 tablet device. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- Documentation/devicetree/bindings/arm/tegra.yaml | 7 +++++++ 1 file changed, 7 insertions(+)