| Message ID | 20200331094001.13441-4-troy.lin@rock-chips.com |
|---|---|
| State | Accepted |
| Commit | df35df3e8d6ccb1e4179fcab440f52204218524e |
| Delegated to: | Kever Yang |
| Headers | show |
| Series | [1/5] arm: dts: rockchip: rk3399: add and enable rng node | expand |
On Tue, Mar 31, 2020 at 12:36 PM Lin Jinhan <troy.lin@rock-chips.com> wrote: > > CONFIG_RNG_ROCKCHIP/CONFIG_DM_RNG is enabled. This should be universally available by default on all rk3399 devices shouldn't it or does it need external regulators or something that is per device? If so shouldn't we just enable it by default for the SoC? > Signed-off-by: Lin Jinhan <troy.lin@rock-chips.com> > --- > configs/evb-rk3399_defconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/configs/evb-rk3399_defconfig b/configs/evb-rk3399_defconfig > index 3f74be3b3c..7f14e18b1b 100644 > --- a/configs/evb-rk3399_defconfig > +++ b/configs/evb-rk3399_defconfig > @@ -39,6 +39,8 @@ CONFIG_PMIC_RK8XX=y > CONFIG_REGULATOR_PWM=y > CONFIG_REGULATOR_RK8XX=y > CONFIG_PWM_ROCKCHIP=y > +CONFIG_DM_RNG=y > +CONFIG_RNG_ROCKCHIP=y > CONFIG_BAUDRATE=1500000 > CONFIG_DEBUG_UART_SHIFT=2 > CONFIG_SYSRESET=y > -- > 2.17.1 > > >
Hi Peter, On 2020/3/31 下午10:37, Peter Robinson wrote: > On Tue, Mar 31, 2020 at 12:36 PM Lin Jinhan <troy.lin@rock-chips.com> wrote: >> CONFIG_RNG_ROCKCHIP/CONFIG_DM_RNG is enabled. > This should be universally available by default on all rk3399 devices > shouldn't it or does it need external regulators or something that is > per device? If so shouldn't we just enable it by default for the SoC? This rng is a internal module, only need available clock and nothing to do with regulator, it could default enable, but I'm not sure all the boards want to enable it, the U-Boot size is already too big for me now. Thanks, - Kever >> Signed-off-by: Lin Jinhan <troy.lin@rock-chips.com> >> --- >> configs/evb-rk3399_defconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/configs/evb-rk3399_defconfig b/configs/evb-rk3399_defconfig >> index 3f74be3b3c..7f14e18b1b 100644 >> --- a/configs/evb-rk3399_defconfig >> +++ b/configs/evb-rk3399_defconfig >> @@ -39,6 +39,8 @@ CONFIG_PMIC_RK8XX=y >> CONFIG_REGULATOR_PWM=y >> CONFIG_REGULATOR_RK8XX=y >> CONFIG_PWM_ROCKCHIP=y >> +CONFIG_DM_RNG=y >> +CONFIG_RNG_ROCKCHIP=y >> CONFIG_BAUDRATE=1500000 >> CONFIG_DEBUG_UART_SHIFT=2 >> CONFIG_SYSRESET=y >> -- >> 2.17.1 >> >> >>
On 2020/3/31 下午5:40, Lin Jinhan wrote: > CONFIG_RNG_ROCKCHIP/CONFIG_DM_RNG is enabled. > > Signed-off-by: Lin Jinhan <troy.lin@rock-chips.com> Reviewed-by: Kever Yang <kever.yang@rock-chips.com> Thanks, - Kever > --- > configs/evb-rk3399_defconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/configs/evb-rk3399_defconfig b/configs/evb-rk3399_defconfig > index 3f74be3b3c..7f14e18b1b 100644 > --- a/configs/evb-rk3399_defconfig > +++ b/configs/evb-rk3399_defconfig > @@ -39,6 +39,8 @@ CONFIG_PMIC_RK8XX=y > CONFIG_REGULATOR_PWM=y > CONFIG_REGULATOR_RK8XX=y > CONFIG_PWM_ROCKCHIP=y > +CONFIG_DM_RNG=y > +CONFIG_RNG_ROCKCHIP=y > CONFIG_BAUDRATE=1500000 > CONFIG_DEBUG_UART_SHIFT=2 > CONFIG_SYSRESET=y
diff --git a/configs/evb-rk3399_defconfig b/configs/evb-rk3399_defconfig index 3f74be3b3c..7f14e18b1b 100644 --- a/configs/evb-rk3399_defconfig +++ b/configs/evb-rk3399_defconfig @@ -39,6 +39,8 @@ CONFIG_PMIC_RK8XX=y CONFIG_REGULATOR_PWM=y CONFIG_REGULATOR_RK8XX=y CONFIG_PWM_ROCKCHIP=y +CONFIG_DM_RNG=y +CONFIG_RNG_ROCKCHIP=y CONFIG_BAUDRATE=1500000 CONFIG_DEBUG_UART_SHIFT=2 CONFIG_SYSRESET=y
CONFIG_RNG_ROCKCHIP/CONFIG_DM_RNG is enabled. Signed-off-by: Lin Jinhan <troy.lin@rock-chips.com> --- configs/evb-rk3399_defconfig | 2 ++ 1 file changed, 2 insertions(+)