diff mbox series

rtc: fsl-ftm-alarm: add shutdown interface

Message ID 20200330122616.24044-1-biwen.li@oss.nxp.com
State Rejected
Headers show
Series rtc: fsl-ftm-alarm: add shutdown interface | expand

Commit Message

Biwen Li March 30, 2020, 12:26 p.m. UTC 
From: Biwen Li <biwen.li@nxp.com>

Add shutdown interface

Signed-off-by: Biwen Li <biwen.li@nxp.com>
---
 drivers/rtc/rtc-fsl-ftm-alarm.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Alexandre Belloni March 30, 2020, 4:44 p.m. UTC | #1 
On 30/03/2020 20:26:16+0800, Biwen Li wrote:
> From: Biwen Li <biwen.li@nxp.com>
> 
> Add shutdown interface
> 
> Signed-off-by: Biwen Li <biwen.li@nxp.com>
> ---
>  drivers/rtc/rtc-fsl-ftm-alarm.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c b/drivers/rtc/rtc-fsl-ftm-alarm.c
> index d7fa6c16f47b..118a775e8316 100644
> --- a/drivers/rtc/rtc-fsl-ftm-alarm.c
> +++ b/drivers/rtc/rtc-fsl-ftm-alarm.c
> @@ -307,6 +307,15 @@ static int ftm_rtc_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +static void ftm_rtc_shutdown(struct platform_device *pdev)
> +{
> +	struct ftm_rtc *rtc = platform_get_drvdata(pdev);
> +
> +	ftm_irq_acknowledge(rtc);
> +	ftm_irq_disable(rtc);
> +	ftm_clean_alarm(rtc);

If the alarm is able to start the platform, then you probably don't want
to disable the alarm on shutdown.
Alexandre Belloni Sept. 15, 2020, 10:28 a.m. UTC | #2 
Hi,

On 30/03/2020 18:44:01+0200, Alexandre Belloni wrote:
> On 30/03/2020 20:26:16+0800, Biwen Li wrote:
> > From: Biwen Li <biwen.li@nxp.com>
> > 
> > Add shutdown interface
> > 
> > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> > ---
> >  drivers/rtc/rtc-fsl-ftm-alarm.c | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c b/drivers/rtc/rtc-fsl-ftm-alarm.c
> > index d7fa6c16f47b..118a775e8316 100644
> > --- a/drivers/rtc/rtc-fsl-ftm-alarm.c
> > +++ b/drivers/rtc/rtc-fsl-ftm-alarm.c
> > @@ -307,6 +307,15 @@ static int ftm_rtc_probe(struct platform_device *pdev)
> >  	return 0;
> >  }
> >  
> > +static void ftm_rtc_shutdown(struct platform_device *pdev)
> > +{
> > +	struct ftm_rtc *rtc = platform_get_drvdata(pdev);
> > +
> > +	ftm_irq_acknowledge(rtc);
> > +	ftm_irq_disable(rtc);
> > +	ftm_clean_alarm(rtc);
> 
> If the alarm is able to start the platform, then you probably don't want
> to disable the alarm on shutdown.
> 

I realise you never replied to that question. Is that patch still of
interest?
Biwen Li Sept. 15, 2020, 10:35 a.m. UTC | #3 
> 
> Hi,
> 
> On 30/03/2020 18:44:01+0200, Alexandre Belloni wrote:
> > On 30/03/2020 20:26:16+0800, Biwen Li wrote:
> > > From: Biwen Li <biwen.li@nxp.com>
> > >
> > > Add shutdown interface
> > >
> > > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> > > ---
> > >  drivers/rtc/rtc-fsl-ftm-alarm.c | 10 ++++++++++
> > >  1 file changed, 10 insertions(+)
> > >
> > > diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c
> > > b/drivers/rtc/rtc-fsl-ftm-alarm.c index d7fa6c16f47b..118a775e8316
> > > 100644
> > > --- a/drivers/rtc/rtc-fsl-ftm-alarm.c
> > > +++ b/drivers/rtc/rtc-fsl-ftm-alarm.c
> > > @@ -307,6 +307,15 @@ static int ftm_rtc_probe(struct platform_device
> *pdev)
> > >     return 0;
> > >  }
> > >
> > > +static void ftm_rtc_shutdown(struct platform_device *pdev) {
> > > +   struct ftm_rtc *rtc = platform_get_drvdata(pdev);
> > > +
> > > +   ftm_irq_acknowledge(rtc);
> > > +   ftm_irq_disable(rtc);
> > > +   ftm_clean_alarm(rtc);
> >
> > If the alarm is able to start the platform, then you probably don't
> > want to disable the alarm on shutdown.
> >
> 
> I realise you never replied to that question. Is that patch still of interest?
Hi Alex, you can drop it. Thanks.
Best Regards,
Biwen Li
> 
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.c
> om%2F&amp;data=02%7C01%7Cbiwen.li%40nxp.com%7Cd688030894714bca7
> 5c708d8596210ec%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63
> 7357625013809281&amp;sdata=pOBMmsxi7DVlywuLZ2LOLVgK4r4GtvW1PYq1
> p9JVv74%3D&amp;reserved=0
diff mbox series

Patch

diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c b/drivers/rtc/rtc-fsl-ftm-alarm.c
index d7fa6c16f47b..118a775e8316 100644
--- a/drivers/rtc/rtc-fsl-ftm-alarm.c
+++ b/drivers/rtc/rtc-fsl-ftm-alarm.c
@@ -307,6 +307,15 @@  static int ftm_rtc_probe(struct platform_device *pdev)
 	return 0;
 }
 
+static void ftm_rtc_shutdown(struct platform_device *pdev)
+{
+	struct ftm_rtc *rtc = platform_get_drvdata(pdev);
+
+	ftm_irq_acknowledge(rtc);
+	ftm_irq_disable(rtc);
+	ftm_clean_alarm(rtc);
+}
+
 static const struct of_device_id ftm_rtc_match[] = {
 	{ .compatible = "fsl,ls1012a-ftm-alarm", },
 	{ .compatible = "fsl,ls1021a-ftm-alarm", },
@@ -321,6 +330,7 @@  static const struct of_device_id ftm_rtc_match[] = {
 
 static struct platform_driver ftm_rtc_driver = {
 	.probe		= ftm_rtc_probe,
+	.shutdown	= ftm_rtc_shutdown,
 	.driver		= {
 		.name	= "ftm-alarm",
 		.of_match_table = ftm_rtc_match,