diff mbox series

[v3,08/10] docs/manual: cargo packages depend on host-rustc

Message ID 20200207180829.165689-9-arnout@mind.be
State Accepted
Headers show
Series Merge rust and cargo | expand

Commit Message

Arnout Vandecappelle Feb. 7, 2020, 6:08 p.m. UTC 
From: Eric Le Bihan <eric.le.bihan.dev@free.fr>

As Cargo is either installed by host-rust or host-rust-bin, the
Cargo-based packages should depend on host-rustc.

Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
Signed-off-by: Patrick Havelange <patrick.havelange@essensium.com>
[Arnout: also select HOST_RUSTC in Config.in]
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 docs/manual/adding-packages-cargo.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

David PIERRET March 27, 2020, 10:57 a.m. UTC | #1 
Hi,
Working on a new package using rust, this patch suite have resolved my
issue with rust version successfully.

Regards
David

On Fri, Feb 7, 2020 at 7:10 PM Arnout Vandecappelle (Essensium/Mind)
<arnout@mind.be> wrote:
>
> From: Eric Le Bihan <eric.le.bihan.dev@free.fr>
>
> As Cargo is either installed by host-rust or host-rust-bin, the
> Cargo-based packages should depend on host-rustc.
>
> Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
> Signed-off-by: Patrick Havelange <patrick.havelange@essensium.com>
> [Arnout: also select HOST_RUSTC in Config.in]
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Reviewed-by: David Pierret <david.pierret@smile.fr>
Tested-by: David Pierret <david.pierret@smile.fr>
> ---
>  docs/manual/adding-packages-cargo.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/manual/adding-packages-cargo.txt b/docs/manual/adding-packages-cargo.txt
> index b6029e1eed..bb078b6981 100644
> --- a/docs/manual/adding-packages-cargo.txt
> +++ b/docs/manual/adding-packages-cargo.txt
> @@ -18,7 +18,7 @@ The +Config.in+ file of Cargo-based package 'foo' should contain:
>  01: config BR2_PACKAGE_FOO
>  02:    bool "foo"
>  03:    depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS
> -04:    select BR2_PACKAGE_HOST_CARGO
> +04:    select BR2_PACKAGE_HOST_RUSTC
>  05:    help
>  06:      This is a comment that explains what foo is.
>  07:
> @@ -44,7 +44,7 @@ package. Let's start with an example:
>  10: FOO_LICENSE = GPL-3.0+
>  11: FOO_LICENSE_FILES = COPYING
>  12:
> -13: FOO_DEPENDENCIES = host-cargo
> +13: FOO_DEPENDENCIES = host-rustc
>  14:
>  15: FOO_CARGO_ENV = CARGO_HOME=$(HOST_DIR)/share/cargo
>  16: FOO_CARGO_MODE = $(if $(BR2_ENABLE_DEBUG),debug,release)
> --
> 2.24.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox series

Patch

diff --git a/docs/manual/adding-packages-cargo.txt b/docs/manual/adding-packages-cargo.txt
index b6029e1eed..bb078b6981 100644
--- a/docs/manual/adding-packages-cargo.txt
+++ b/docs/manual/adding-packages-cargo.txt
@@ -18,7 +18,7 @@  The +Config.in+ file of Cargo-based package 'foo' should contain:
 01: config BR2_PACKAGE_FOO
 02: 	bool "foo"
 03: 	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS
-04: 	select BR2_PACKAGE_HOST_CARGO
+04: 	select BR2_PACKAGE_HOST_RUSTC
 05: 	help
 06: 	  This is a comment that explains what foo is.
 07:
@@ -44,7 +44,7 @@  package. Let's start with an example:
 10: FOO_LICENSE = GPL-3.0+
 11: FOO_LICENSE_FILES = COPYING
 12:
-13: FOO_DEPENDENCIES = host-cargo
+13: FOO_DEPENDENCIES = host-rustc
 14:
 15: FOO_CARGO_ENV = CARGO_HOME=$(HOST_DIR)/share/cargo
 16: FOO_CARGO_MODE = $(if $(BR2_ENABLE_DEBUG),debug,release)