| Message ID | 20200314153047.2486-4-sam@ravnborg.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | drm: drop data-mapping property from panel-dpi | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
Hi Sam, Thank you for the patch. On Sat, Mar 14, 2020 at 04:30:47PM +0100, Sam Ravnborg wrote: > Fix a few grammar/editorial issues spotted by Laurent Pinchart. > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Rob Herring <robh@kernel.org> > --- > .../bindings/display/panel/display-timings.yaml | 8 ++++---- > .../devicetree/bindings/display/panel/panel-common.yaml | 4 ++-- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/panel/display-timings.yaml b/Documentation/devicetree/bindings/display/panel/display-timings.yaml > index c8c0c9cb0492..56903ded005e 100644 > --- a/Documentation/devicetree/bindings/display/panel/display-timings.yaml > +++ b/Documentation/devicetree/bindings/display/panel/display-timings.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/display/panel/display-timings.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: display timing bindings > +title: display timings bindings > > maintainers: > - Thierry Reding <thierry.reding@gmail.com> > @@ -14,7 +14,7 @@ maintainers: > description: | > A display panel may be able to handle several display timings, > with different resolutions. > - The display-timings node makes it possible to specify the timing > + The display-timings node makes it possible to specify the timings > and to specify the timing that is native for the display. > > properties: > @@ -25,8 +25,8 @@ properties: > $ref: /schemas/types.yaml#/definitions/phandle > description: | > The default display timing is the one specified as native-mode. > - If no native-mode is specified then the first node is assumed the > - native mode. > + If no native-mode is specified then the first node is assumed > + to be the native mode. > > patternProperties: > "^timing": > diff --git a/Documentation/devicetree/bindings/display/panel/panel-common.yaml b/Documentation/devicetree/bindings/display/panel/panel-common.yaml > index ed051ba12084..dee4faffd204 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-common.yaml > +++ b/Documentation/devicetree/bindings/display/panel/panel-common.yaml > @@ -63,9 +63,9 @@ properties: > > display-timings: > description: > - Some display panels supports several resolutions with different timing. > + Some display panels supports several resolutions with different timings. s/supports/support/ > The display-timings bindings supports specifying several timings and > - optional specify which is the native mode. > + optionally specify which is the native mode. s/specify/specifying/ ? Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > allOf: > - $ref: display-timings.yaml# >
Hi Laurent. On Tue, Mar 17, 2020 at 09:25:22PM +0200, Laurent Pinchart wrote: > Hi Sam, > > Thank you for the patch. > > On Sat, Mar 14, 2020 at 04:30:47PM +0100, Sam Ravnborg wrote: > > Fix a few grammar/editorial issues spotted by Laurent Pinchart. > > > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Cc: Rob Herring <robh@kernel.org> > > --- > > .../bindings/display/panel/display-timings.yaml | 8 ++++---- > > .../devicetree/bindings/display/panel/panel-common.yaml | 4 ++-- > > 2 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/panel/display-timings.yaml b/Documentation/devicetree/bindings/display/panel/display-timings.yaml > > index c8c0c9cb0492..56903ded005e 100644 > > --- a/Documentation/devicetree/bindings/display/panel/display-timings.yaml > > +++ b/Documentation/devicetree/bindings/display/panel/display-timings.yaml > > @@ -4,7 +4,7 @@ > > $id: http://devicetree.org/schemas/display/panel/display-timings.yaml# > > $schema: http://devicetree.org/meta-schemas/core.yaml# > > > > -title: display timing bindings > > +title: display timings bindings > > > > maintainers: > > - Thierry Reding <thierry.reding@gmail.com> > > @@ -14,7 +14,7 @@ maintainers: > > description: | > > A display panel may be able to handle several display timings, > > with different resolutions. > > - The display-timings node makes it possible to specify the timing > > + The display-timings node makes it possible to specify the timings > > and to specify the timing that is native for the display. > > > > properties: > > @@ -25,8 +25,8 @@ properties: > > $ref: /schemas/types.yaml#/definitions/phandle > > description: | > > The default display timing is the one specified as native-mode. > > - If no native-mode is specified then the first node is assumed the > > - native mode. > > + If no native-mode is specified then the first node is assumed > > + to be the native mode. > > > > patternProperties: > > "^timing": > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-common.yaml b/Documentation/devicetree/bindings/display/panel/panel-common.yaml > > index ed051ba12084..dee4faffd204 100644 > > --- a/Documentation/devicetree/bindings/display/panel/panel-common.yaml > > +++ b/Documentation/devicetree/bindings/display/panel/panel-common.yaml > > @@ -63,9 +63,9 @@ properties: > > > > display-timings: > > description: > > - Some display panels supports several resolutions with different timing. > > + Some display panels supports several resolutions with different timings. > > s/supports/support/ > > > The display-timings bindings supports specifying several timings and > > - optional specify which is the native mode. > > + optionally specify which is the native mode. > > s/specify/specifying/ ? > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Fixed the above and applied this patch to drm-misc-next. The other patches awaits that drm-misc-next-fixes is ready Sam
diff --git a/Documentation/devicetree/bindings/display/panel/display-timings.yaml b/Documentation/devicetree/bindings/display/panel/display-timings.yaml index c8c0c9cb0492..56903ded005e 100644 --- a/Documentation/devicetree/bindings/display/panel/display-timings.yaml +++ b/Documentation/devicetree/bindings/display/panel/display-timings.yaml @@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/display/panel/display-timings.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: display timing bindings +title: display timings bindings maintainers: - Thierry Reding <thierry.reding@gmail.com> @@ -14,7 +14,7 @@ maintainers: description: | A display panel may be able to handle several display timings, with different resolutions. - The display-timings node makes it possible to specify the timing + The display-timings node makes it possible to specify the timings and to specify the timing that is native for the display. properties: @@ -25,8 +25,8 @@ properties: $ref: /schemas/types.yaml#/definitions/phandle description: | The default display timing is the one specified as native-mode. - If no native-mode is specified then the first node is assumed the - native mode. + If no native-mode is specified then the first node is assumed + to be the native mode. patternProperties: "^timing": diff --git a/Documentation/devicetree/bindings/display/panel/panel-common.yaml b/Documentation/devicetree/bindings/display/panel/panel-common.yaml index ed051ba12084..dee4faffd204 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-common.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-common.yaml @@ -63,9 +63,9 @@ properties: display-timings: description: - Some display panels supports several resolutions with different timing. + Some display panels supports several resolutions with different timings. The display-timings bindings supports specifying several timings and - optional specify which is the native mode. + optionally specify which is the native mode. allOf: - $ref: display-timings.yaml#
Fix a few grammar/editorial issues spotted by Laurent Pinchart. Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Rob Herring <robh@kernel.org> --- .../bindings/display/panel/display-timings.yaml | 8 ++++---- .../devicetree/bindings/display/panel/panel-common.yaml | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-)