| Message ID | 1308961475-25055-1-git-send-email-jesse@nicira.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Thanks again. > When receiving packets from another guest on the same hypervisor, it's > generally possible to receive large packets because no segmentation is > necessary and these packets are handled by LRO. However, when doing > routing or bridging we must disable LRO and lose this benefit. In > these cases GRO can still be used and it is very effective because the > packets which are segmented in the hypervisor are received very close > together and can easily be merged. > > CC: Shreyas Bhatewara <sbhatewara@vmware.com> > CC: Scott Goldman <scottjg@vmware.com> > CC: VMware PV-Drivers <pv-drivers@vmware.com> > Signed-off-by: Jesse Gross <jesse@nicira.com> Signed-off-by: Scott J. Goldman <scottjg@vmware.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Jesse Gross <jesse@nicira.com> Date: Fri, 24 Jun 2011 17:24:35 -0700 > When receiving packets from another guest on the same hypervisor, it's > generally possible to receive large packets because no segmentation is > necessary and these packets are handled by LRO. However, when doing > routing or bridging we must disable LRO and lose this benefit. In > these cases GRO can still be used and it is very effective because the > packets which are segmented in the hypervisor are received very close > together and can easily be merged. > > CC: Shreyas Bhatewara <sbhatewara@vmware.com> > CC: Scott Goldman <scottjg@vmware.com> > CC: VMware PV-Drivers <pv-drivers@vmware.com> > Signed-off-by: Jesse Gross <jesse@nicira.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index c84b1dd..2c14736 100644 --- a/drivers/net/vmxnet3/vmxnet3_drv.c +++ b/drivers/net/vmxnet3/vmxnet3_drv.c @@ -1234,7 +1234,10 @@ vmxnet3_rq_rx_complete(struct vmxnet3_rx_queue *rq, if (unlikely(rcd->ts)) __vlan_hwaccel_put_tag(skb, rcd->tci); - netif_receive_skb(skb); + if (adapter->netdev->features & NETIF_F_LRO) + netif_receive_skb(skb); + else + napi_gro_receive(&rq->napi, skb); ctx->skb = NULL; }
When receiving packets from another guest on the same hypervisor, it's generally possible to receive large packets because no segmentation is necessary and these packets are handled by LRO. However, when doing routing or bridging we must disable LRO and lose this benefit. In these cases GRO can still be used and it is very effective because the packets which are segmented in the hypervisor are received very close together and can easily be merged. CC: Shreyas Bhatewara <sbhatewara@vmware.com> CC: Scott Goldman <scottjg@vmware.com> CC: VMware PV-Drivers <pv-drivers@vmware.com> Signed-off-by: Jesse Gross <jesse@nicira.com> --- This applies on top of my previous vmxnet3 patch "vmxnet3: Convert to new vlan model." v2: Only use GRO when LRO is not active as suggested by Scott Goldman. --- drivers/net/vmxnet3/vmxnet3_drv.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)