mbox series

[v2,0/3] Support SDMA mode on RPI4 target - 32bit

Message ID 20200218012546.15858-1-jh80.chung@samsung.com
Headers show
Series Support SDMA mode on RPI4 target - 32bit | expand

Message

Jaehoon Chung Feb. 18, 2020, 1:25 a.m. UTC
RPI4's SDHCI controller is supported SDMA mode. (Checked on kernel side)
But It doesn't use on u-boot side. Then it's too slow about read/write performance.
This patchset is supported SDMA mode on RPI4 target(32bit).
- I didn't test on RPI4 64bit.

Read/write time about 8MB file
Before
- Read : 1.472 seconds
- Write : 4.690 seconds
After
- Read : 0.359 seconds
- Write : 0.574 seconds

This patch is based on my RFC's patches.RPI4's SDHCI controller is supported SDMA mode. (Checked on kernel side)
But It doesn't use on u-boot side. Then it's too slow about read/write performance.
This patchset is supported SDMA mode on RPI4 target(32bit).
- I didn't test on RPI4 64bit.

Read/write time about 8MB file
Before
- Read : 1.472 seconds
- Write : 4.690 seconds
After
- Read : 0.359 seconds
- Write : 0.574 seconds

This patch is based on my RFC's patches.

Changelog on V2
- Keep printf message instead of debug
- Add Peng's Reviewed-by tag

Jaehoon Chung (3):
  mmc: sdhci: use phys2bus macro when dma address is accessed
  mmc: sdhci: not return error when SDMA is not supported
  configs: rpi_4_32b_defconfig: enable SDHCI_SDMA config

 configs/rpi_4_32b_defconfig |  1 +
 drivers/mmc/sdhci.c         | 13 +++++++------
 2 files changed, 8 insertions(+), 6 deletions(-)

Comments

Jaehoon Chung March 17, 2020, 11:50 p.m. UTC | #1
Hi

Is there any comment or plan to apply?

Best Regards,
Jaehoon Chung

On 2/18/20 10:25 AM, Jaehoon Chung wrote:
> RPI4's SDHCI controller is supported SDMA mode. (Checked on kernel side)
> But It doesn't use on u-boot side. Then it's too slow about read/write performance.
> This patchset is supported SDMA mode on RPI4 target(32bit).
> - I didn't test on RPI4 64bit.
> 
> Read/write time about 8MB file
> Before
> - Read : 1.472 seconds
> - Write : 4.690 seconds
> After
> - Read : 0.359 seconds
> - Write : 0.574 seconds
> 
> This patch is based on my RFC's patches.RPI4's SDHCI controller is supported SDMA mode. (Checked on kernel side)
> But It doesn't use on u-boot side. Then it's too slow about read/write performance.
> This patchset is supported SDMA mode on RPI4 target(32bit).
> - I didn't test on RPI4 64bit.
> 
> Read/write time about 8MB file
> Before
> - Read : 1.472 seconds
> - Write : 4.690 seconds
> After
> - Read : 0.359 seconds
> - Write : 0.574 seconds
> 
> This patch is based on my RFC's patches.
> 
> Changelog on V2
> - Keep printf message instead of debug
> - Add Peng's Reviewed-by tag
> 
> Jaehoon Chung (3):
>   mmc: sdhci: use phys2bus macro when dma address is accessed
>   mmc: sdhci: not return error when SDMA is not supported
>   configs: rpi_4_32b_defconfig: enable SDHCI_SDMA config
> 
>  configs/rpi_4_32b_defconfig |  1 +
>  drivers/mmc/sdhci.c         | 13 +++++++------
>  2 files changed, 8 insertions(+), 6 deletions(-)
>
Peng Fan March 18, 2020, 1 a.m. UTC | #2
> Subject: Re: [PATCH v2 0/3] Support SDMA mode on RPI4 target - 32bit
> 
> Hi
> 
> Is there any comment or plan to apply?

Sorry, I missed this patchset. Will pick it up.

Thanks,
Peng.

> 
> Best Regards,
> Jaehoon Chung
> 
> On 2/18/20 10:25 AM, Jaehoon Chung wrote:
> > RPI4's SDHCI controller is supported SDMA mode. (Checked on kernel
> > side) But It doesn't use on u-boot side. Then it's too slow about read/write
> performance.
> > This patchset is supported SDMA mode on RPI4 target(32bit).
> > - I didn't test on RPI4 64bit.
> >
> > Read/write time about 8MB file
> > Before
> > - Read : 1.472 seconds
> > - Write : 4.690 seconds
> > After
> > - Read : 0.359 seconds
> > - Write : 0.574 seconds
> >
> > This patch is based on my RFC's patches.RPI4's SDHCI controller is
> > supported SDMA mode. (Checked on kernel side) But It doesn't use on
> u-boot side. Then it's too slow about read/write performance.
> > This patchset is supported SDMA mode on RPI4 target(32bit).
> > - I didn't test on RPI4 64bit.
> >
> > Read/write time about 8MB file
> > Before
> > - Read : 1.472 seconds
> > - Write : 4.690 seconds
> > After
> > - Read : 0.359 seconds
> > - Write : 0.574 seconds
> >
> > This patch is based on my RFC's patches.
> >
> > Changelog on V2
> > - Keep printf message instead of debug
> > - Add Peng's Reviewed-by tag
> >
> > Jaehoon Chung (3):
> >   mmc: sdhci: use phys2bus macro when dma address is accessed
> >   mmc: sdhci: not return error when SDMA is not supported
> >   configs: rpi_4_32b_defconfig: enable SDHCI_SDMA config
> >
> >  configs/rpi_4_32b_defconfig |  1 +
> >  drivers/mmc/sdhci.c         | 13 +++++++------
> >  2 files changed, 8 insertions(+), 6 deletions(-)
> >
Jaehoon Chung March 18, 2020, 5:29 a.m. UTC | #3
On 3/18/20 10:00 AM, Peng Fan wrote:
>> Subject: Re: [PATCH v2 0/3] Support SDMA mode on RPI4 target - 32bit
>>
>> Hi
>>
>> Is there any comment or plan to apply?
> 
> Sorry, I missed this patchset. Will pick it up.

No problem. :) Thanks!

Best Regards,
Jaehoon Chung

> 
> Thanks,
> Peng.
> 
>>
>> Best Regards,
>> Jaehoon Chung
>>
>> On 2/18/20 10:25 AM, Jaehoon Chung wrote:
>>> RPI4's SDHCI controller is supported SDMA mode. (Checked on kernel
>>> side) But It doesn't use on u-boot side. Then it's too slow about read/write
>> performance.
>>> This patchset is supported SDMA mode on RPI4 target(32bit).
>>> - I didn't test on RPI4 64bit.
>>>
>>> Read/write time about 8MB file
>>> Before
>>> - Read : 1.472 seconds
>>> - Write : 4.690 seconds
>>> After
>>> - Read : 0.359 seconds
>>> - Write : 0.574 seconds
>>>
>>> This patch is based on my RFC's patches.RPI4's SDHCI controller is
>>> supported SDMA mode. (Checked on kernel side) But It doesn't use on
>> u-boot side. Then it's too slow about read/write performance.
>>> This patchset is supported SDMA mode on RPI4 target(32bit).
>>> - I didn't test on RPI4 64bit.
>>>
>>> Read/write time about 8MB file
>>> Before
>>> - Read : 1.472 seconds
>>> - Write : 4.690 seconds
>>> After
>>> - Read : 0.359 seconds
>>> - Write : 0.574 seconds
>>>
>>> This patch is based on my RFC's patches.
>>>
>>> Changelog on V2
>>> - Keep printf message instead of debug
>>> - Add Peng's Reviewed-by tag
>>>
>>> Jaehoon Chung (3):
>>>   mmc: sdhci: use phys2bus macro when dma address is accessed
>>>   mmc: sdhci: not return error when SDMA is not supported
>>>   configs: rpi_4_32b_defconfig: enable SDHCI_SDMA config
>>>
>>>  configs/rpi_4_32b_defconfig |  1 +
>>>  drivers/mmc/sdhci.c         | 13 +++++++------
>>>  2 files changed, 8 insertions(+), 6 deletions(-)
>>>
>
Peng Fan March 23, 2020, 1:14 a.m. UTC | #4
Hi Jaehoon,

> Subject: Re: [PATCH v2 0/3] Support SDMA mode on RPI4 target - 32bit
> 
> On 3/18/20 10:00 AM, Peng Fan wrote:
> >> Subject: Re: [PATCH v2 0/3] Support SDMA mode on RPI4 target - 32bit
> >>
> >> Hi
> >>
> >> Is there any comment or plan to apply?
> >
> > Sorry, I missed this patchset. Will pick it up.

This patchset could not be applied on master, would you rebase?

Thanks,
Peng.

> 
> No problem. :) Thanks!
> 
> Best Regards,
> Jaehoon Chung
> 
> >
> > Thanks,
> > Peng.
> >
> >>
> >> Best Regards,
> >> Jaehoon Chung
> >>
> >> On 2/18/20 10:25 AM, Jaehoon Chung wrote:
> >>> RPI4's SDHCI controller is supported SDMA mode. (Checked on kernel
> >>> side) But It doesn't use on u-boot side. Then it's too slow about
> >>> read/write
> >> performance.
> >>> This patchset is supported SDMA mode on RPI4 target(32bit).
> >>> - I didn't test on RPI4 64bit.
> >>>
> >>> Read/write time about 8MB file
> >>> Before
> >>> - Read : 1.472 seconds
> >>> - Write : 4.690 seconds
> >>> After
> >>> - Read : 0.359 seconds
> >>> - Write : 0.574 seconds
> >>>
> >>> This patch is based on my RFC's patches.RPI4's SDHCI controller is
> >>> supported SDMA mode. (Checked on kernel side) But It doesn't use on
> >> u-boot side. Then it's too slow about read/write performance.
> >>> This patchset is supported SDMA mode on RPI4 target(32bit).
> >>> - I didn't test on RPI4 64bit.
> >>>
> >>> Read/write time about 8MB file
> >>> Before
> >>> - Read : 1.472 seconds
> >>> - Write : 4.690 seconds
> >>> After
> >>> - Read : 0.359 seconds
> >>> - Write : 0.574 seconds
> >>>
> >>> This patch is based on my RFC's patches.
> >>>
> >>> Changelog on V2
> >>> - Keep printf message instead of debug
> >>> - Add Peng's Reviewed-by tag
> >>>
> >>> Jaehoon Chung (3):
> >>>   mmc: sdhci: use phys2bus macro when dma address is accessed
> >>>   mmc: sdhci: not return error when SDMA is not supported
> >>>   configs: rpi_4_32b_defconfig: enable SDHCI_SDMA config
> >>>
> >>>  configs/rpi_4_32b_defconfig |  1 +
> >>>  drivers/mmc/sdhci.c         | 13 +++++++------
> >>>  2 files changed, 8 insertions(+), 6 deletions(-)
> >>>
> >
Jaehoon Chung March 24, 2020, 7:12 a.m. UTC | #5
On 3/23/20 10:14 AM, Peng Fan wrote:
> Hi Jaehoon,
> 
>> Subject: Re: [PATCH v2 0/3] Support SDMA mode on RPI4 target - 32bit
>>
>> On 3/18/20 10:00 AM, Peng Fan wrote:
>>>> Subject: Re: [PATCH v2 0/3] Support SDMA mode on RPI4 target - 32bit
>>>>
>>>> Hi
>>>>
>>>> Is there any comment or plan to apply?
>>>
>>> Sorry, I missed this patchset. Will pick it up.
> 
> This patchset could not be applied on master, would you rebase?

Sure, i will resend after rebase on latest. 

Best Regards,
Jaehoon Chung

> 
> Thanks,
> Peng.
> 
>>
>> No problem. :) Thanks!
>>
>> Best Regards,
>> Jaehoon Chung
>>
>>>
>>> Thanks,
>>> Peng.
>>>
>>>>
>>>> Best Regards,
>>>> Jaehoon Chung
>>>>
>>>> On 2/18/20 10:25 AM, Jaehoon Chung wrote:
>>>>> RPI4's SDHCI controller is supported SDMA mode. (Checked on kernel
>>>>> side) But It doesn't use on u-boot side. Then it's too slow about
>>>>> read/write
>>>> performance.
>>>>> This patchset is supported SDMA mode on RPI4 target(32bit).
>>>>> - I didn't test on RPI4 64bit.
>>>>>
>>>>> Read/write time about 8MB file
>>>>> Before
>>>>> - Read : 1.472 seconds
>>>>> - Write : 4.690 seconds
>>>>> After
>>>>> - Read : 0.359 seconds
>>>>> - Write : 0.574 seconds
>>>>>
>>>>> This patch is based on my RFC's patches.RPI4's SDHCI controller is
>>>>> supported SDMA mode. (Checked on kernel side) But It doesn't use on
>>>> u-boot side. Then it's too slow about read/write performance.
>>>>> This patchset is supported SDMA mode on RPI4 target(32bit).
>>>>> - I didn't test on RPI4 64bit.
>>>>>
>>>>> Read/write time about 8MB file
>>>>> Before
>>>>> - Read : 1.472 seconds
>>>>> - Write : 4.690 seconds
>>>>> After
>>>>> - Read : 0.359 seconds
>>>>> - Write : 0.574 seconds
>>>>>
>>>>> This patch is based on my RFC's patches.
>>>>>
>>>>> Changelog on V2
>>>>> - Keep printf message instead of debug
>>>>> - Add Peng's Reviewed-by tag
>>>>>
>>>>> Jaehoon Chung (3):
>>>>>   mmc: sdhci: use phys2bus macro when dma address is accessed
>>>>>   mmc: sdhci: not return error when SDMA is not supported
>>>>>   configs: rpi_4_32b_defconfig: enable SDHCI_SDMA config
>>>>>
>>>>>  configs/rpi_4_32b_defconfig |  1 +
>>>>>  drivers/mmc/sdhci.c         | 13 +++++++------
>>>>>  2 files changed, 8 insertions(+), 6 deletions(-)
>>>>>
>>>
>