diff mbox

[U-Boot,1/3] config.mk: move LDSCRIPT processing to the top-level Makefile

Message ID 1308609939-23337-1-git-send-email-yanok@emcraft.com
State Accepted
Commit d51dfff7af2ad30c54a4fb99539f3fa4275a1573
Delegated to: Wolfgang Denk
Headers show

Commit Message

Ilya Yanok June 20, 2011, 10:45 p.m. UTC 
LDSCRIPT is used only from the top-level Makefile and only when the
system is configured so we can move LDSCRIPT and CONFIG_SYS_LDSCRIPT
related logic into the top level Makefile and under configured condition
to avoid errors when building tools from unconfigured tree.

Signed-off-by: Ilya Yanok <yanok@emcraft.com>
---
 Makefile  |   30 ++++++++++++++++++++++++++++++
 config.mk |   30 ------------------------------
 2 files changed, 30 insertions(+), 30 deletions(-)

Comments

Mike Frysinger June 21, 2011, 1:57 a.m. UTC | #1 
Acked-by: Mike Frysinger <vapier@gentoo.org>
-mike
Wolfgang Denk June 22, 2011, 6:05 p.m. UTC | #2 
Dear Ilya Yanok,

In message <1308609939-23337-1-git-send-email-yanok@emcraft.com> you wrote:
> LDSCRIPT is used only from the top-level Makefile and only when the
> system is configured so we can move LDSCRIPT and CONFIG_SYS_LDSCRIPT
> related logic into the top level Makefile and under configured condition
> to avoid errors when building tools from unconfigured tree.
> 
> Signed-off-by: Ilya Yanok <yanok@emcraft.com>
> ---
>  Makefile  |   30 ++++++++++++++++++++++++++++++
>  config.mk |   30 ------------------------------
>  2 files changed, 30 insertions(+), 30 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk
diff mbox

Patch

diff --git a/Makefile b/Makefile
index dcf5d93..e73cfc7 100644
--- a/Makefile
+++ b/Makefile
@@ -163,6 +163,36 @@  endif
 # load other configuration
 include $(TOPDIR)/config.mk
 
+# If board code explicitly specified LDSCRIPT or CONFIG_SYS_LDSCRIPT, use
+# that (or fail if absent).  Otherwise, search for a linker script in a
+# standard location.
+
+ifndef LDSCRIPT
+	#LDSCRIPT := $(TOPDIR)/board/$(BOARDDIR)/u-boot.lds.debug
+	ifdef CONFIG_SYS_LDSCRIPT
+		# need to strip off double quotes
+		LDSCRIPT := $(subst ",,$(CONFIG_SYS_LDSCRIPT))
+	endif
+endif
+
+ifndef LDSCRIPT
+	ifeq ($(CONFIG_NAND_U_BOOT),y)
+		LDSCRIPT := $(TOPDIR)/board/$(BOARDDIR)/u-boot-nand.lds
+		ifeq ($(wildcard $(LDSCRIPT)),)
+			LDSCRIPT := $(TOPDIR)/$(CPUDIR)/u-boot-nand.lds
+		endif
+	endif
+	ifeq ($(wildcard $(LDSCRIPT)),)
+		LDSCRIPT := $(TOPDIR)/board/$(BOARDDIR)/u-boot.lds
+	endif
+	ifeq ($(wildcard $(LDSCRIPT)),)
+		LDSCRIPT := $(TOPDIR)/$(CPUDIR)/u-boot.lds
+	endif
+	ifeq ($(wildcard $(LDSCRIPT)),)
+$(error could not find linker script)
+	endif
+endif
+
 #########################################################################
 # U-Boot objects....order is important (i.e. start must be first)
 
diff --git a/config.mk b/config.mk
index 7ce554e..2eb7fa2 100644
--- a/config.mk
+++ b/config.mk
@@ -154,36 +154,6 @@  RELFLAGS= $(PLATFORM_RELFLAGS)
 DBGFLAGS= -g # -DDEBUG
 OPTFLAGS= -Os #-fomit-frame-pointer
 
-# If board code explicitly specified LDSCRIPT or CONFIG_SYS_LDSCRIPT, use
-# that (or fail if absent).  Otherwise, search for a linker script in a
-# standard location.
-
-ifndef LDSCRIPT
-	#LDSCRIPT := $(TOPDIR)/board/$(BOARDDIR)/u-boot.lds.debug
-	ifdef CONFIG_SYS_LDSCRIPT
-		# need to strip off double quotes
-		LDSCRIPT := $(subst ",,$(CONFIG_SYS_LDSCRIPT))
-	endif
-endif
-
-ifndef LDSCRIPT
-	ifeq ($(CONFIG_NAND_U_BOOT),y)
-		LDSCRIPT := $(TOPDIR)/board/$(BOARDDIR)/u-boot-nand.lds
-		ifeq ($(wildcard $(LDSCRIPT)),)
-			LDSCRIPT := $(TOPDIR)/$(CPUDIR)/u-boot-nand.lds
-		endif
-	endif
-	ifeq ($(wildcard $(LDSCRIPT)),)
-		LDSCRIPT := $(TOPDIR)/board/$(BOARDDIR)/u-boot.lds
-	endif
-	ifeq ($(wildcard $(LDSCRIPT)),)
-		LDSCRIPT := $(TOPDIR)/$(CPUDIR)/u-boot.lds
-	endif
-	ifeq ($(wildcard $(LDSCRIPT)),)
-$(error could not find linker script)
-	endif
-endif
-
 OBJCFLAGS += --gap-fill=0xff
 
 gccincdir := $(shell $(CC) -print-file-name=include)