| Message ID | 20200225020937.25028-13-kuhn.chenqun@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | redundant code: Fix warnings reported by Clang static code analyzer | expand |
On 2/25/20 3:09 AM, kuhn.chenqun@huawei.com wrote: > From: Chen Qun <kuhn.chenqun@huawei.com> > > The "again" assignment is meaningless before g_assert_not_reached. > In addition, the break statements no longer needs to be after > g_assert_not_reached. > > Clang static code analyzer show warning: > hw/usb/hcd-ehci.c:2108:13: warning: Value stored to 'again' is never read > again = -1; > ^ ~~ > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > --- > Cc: Gerd Hoffmann <kraxel@redhat.com> > --- > hw/usb/hcd-ehci.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c > index 56ab2f457f..29d49c2d7e 100644 > --- a/hw/usb/hcd-ehci.c > +++ b/hw/usb/hcd-ehci.c > @@ -1301,7 +1301,6 @@ static void ehci_execute_complete(EHCIQueue *q) > /* should not be triggerable */ > fprintf(stderr, "USB invalid response %d\n", p->packet.status); > g_assert_not_reached(); > - break; > } > > /* TODO check 4.12 for splits */ > @@ -2105,9 +2104,7 @@ static void ehci_advance_state(EHCIState *ehci, int async) > > default: > fprintf(stderr, "Bad state!\n"); > - again = -1; > g_assert_not_reached(); > - break; > } > > if (again < 0 || itd_count > 16) { > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 56ab2f457f..29d49c2d7e 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -1301,7 +1301,6 @@ static void ehci_execute_complete(EHCIQueue *q) /* should not be triggerable */ fprintf(stderr, "USB invalid response %d\n", p->packet.status); g_assert_not_reached(); - break; } /* TODO check 4.12 for splits */ @@ -2105,9 +2104,7 @@ static void ehci_advance_state(EHCIState *ehci, int async) default: fprintf(stderr, "Bad state!\n"); - again = -1; g_assert_not_reached(); - break; } if (again < 0 || itd_count > 16) {