Message ID | 20200213213129.34023-9-anthony.l.nguyen@intel.com |
---|---|
State | Accepted |
Delegated to: | Jeff Kirsher |
Headers | show |
Series | [S39,v2,01/15] ice: Validate config for SW DCB map | expand |
> -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On > Behalf Of Tony Nguyen > Sent: Thursday, February 13, 2020 1:31 PM > To: intel-wired-lan@lists.osuosl.org > Subject: [Intel-wired-lan] [PATCH S39 v2 10/15] ice: Don't tell the OS that link > is going down > > From: Michal Swiatkowski <michal.swiatkowski@intel.com> > > Remove code that tell the OS that link is going down when user change flow > control via ethtool. When link is up it isn't certain that link goes down after > 0x0605 aq command. If link doesn't go down, OS thinks that link is down, but > physical link is up. To reset this state user have to take interface down and > up. > > If link goes down after 0x0605 command, FW send information about that > and after that driver tells the OS that the link goes down. So this code in > ethtool is unnecessary. > > Signed-off-by: Michal Swiatkowski <michal.swiatkowski@intel.com> > --- > drivers/net/ethernet/intel/ice/ice_ethtool.c | 7 ------- > 1 file changed, 7 deletions(-) Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c index 22a9f59e7218..135d5bfc6e11 100644 --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c @@ -2935,13 +2935,6 @@ ice_set_pauseparam(struct net_device *netdev, struct ethtool_pauseparam *pause) else return -EINVAL; - /* Tell the OS link is going down, the link will go back up when fw - * says it is ready asynchronously - */ - ice_print_link_msg(vsi, false); - netif_carrier_off(netdev); - netif_tx_stop_all_queues(netdev); - /* Set the FC mode and only restart AN if link is up */ status = ice_set_fc(pi, &aq_failures, link_up);