| Message ID | 20200209163356.6439-19-digetx@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | NVIDIA Tegra APB DMA driver fixes and improvements | expand |
On 09/02/2020 16:33, Dmitry Osipenko wrote: > Remove unused function argument from handle_continuous_head_request(). > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/dma/tegra20-apb-dma.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c > index 7b9d59bbd2c1..3e0373b89195 100644 > --- a/drivers/dma/tegra20-apb-dma.c > +++ b/drivers/dma/tegra20-apb-dma.c > @@ -553,7 +553,6 @@ static void tegra_dma_abort_all(struct tegra_dma_channel *tdc) > } > > static bool handle_continuous_head_request(struct tegra_dma_channel *tdc, > - struct tegra_dma_sg_req *last_sg_req, > bool to_terminate) > { > struct tegra_dma_sg_req *hsgreq; > @@ -638,7 +637,7 @@ static void handle_cont_sngl_cycle_dma_done(struct tegra_dma_channel *tdc, > if (!list_is_last(&sgreq->node, &tdc->pending_sg_req)) { > list_move_tail(&sgreq->node, &tdc->pending_sg_req); > sgreq->configured = false; > - st = handle_continuous_head_request(tdc, sgreq, to_terminate); > + st = handle_continuous_head_request(tdc, to_terminate); > if (!st) > dma_desc->dma_status = DMA_ERROR; > } > Acked-by: Jon Hunter <jonathanh@nvidia.com> Thanks! Jon
14.02.2020 17:16, Jon Hunter пишет: ... > Acked-by: Jon Hunter <jonathanh@nvidia.com> > > Thanks! > Jon > Jon, thank you very much! In the patchwork I see that you acked all the patches, but my Gmail missed 2 of 4 emails, maybe the missing emails will arrive a day later :)
On 14/02/2020 16:54, Dmitry Osipenko wrote: > 14.02.2020 17:16, Jon Hunter пишет: > ... >> Acked-by: Jon Hunter <jonathanh@nvidia.com> >> >> Thanks! >> Jon >> > > Jon, thank you very much! > > In the patchwork I see that you acked all the patches, but my Gmail > missed 2 of 4 emails, maybe the missing emails will arrive a day later :) Yes all should be ACK'ed now. I did receive an email from our mail server saying that there was an issue and the message was delayed. So not sure if you ever got it. Jon
17.02.2020 14:15, Jon Hunter пишет: > > On 14/02/2020 16:54, Dmitry Osipenko wrote: >> 14.02.2020 17:16, Jon Hunter пишет: >> ... >>> Acked-by: Jon Hunter <jonathanh@nvidia.com> >>> >>> Thanks! >>> Jon >>> >> >> Jon, thank you very much! >> >> In the patchwork I see that you acked all the patches, but my Gmail >> missed 2 of 4 emails, maybe the missing emails will arrive a day later :) > > Yes all should be ACK'ed now. I did receive an email from our mail > server saying that there was an issue and the message was delayed. So > not sure if you ever got it. The emails arrived a day later, just like it was predicted :) Thank you very much for reviewing the patches!
diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c index 7b9d59bbd2c1..3e0373b89195 100644 --- a/drivers/dma/tegra20-apb-dma.c +++ b/drivers/dma/tegra20-apb-dma.c @@ -553,7 +553,6 @@ static void tegra_dma_abort_all(struct tegra_dma_channel *tdc) } static bool handle_continuous_head_request(struct tegra_dma_channel *tdc, - struct tegra_dma_sg_req *last_sg_req, bool to_terminate) { struct tegra_dma_sg_req *hsgreq; @@ -638,7 +637,7 @@ static void handle_cont_sngl_cycle_dma_done(struct tegra_dma_channel *tdc, if (!list_is_last(&sgreq->node, &tdc->pending_sg_req)) { list_move_tail(&sgreq->node, &tdc->pending_sg_req); sgreq->configured = false; - st = handle_continuous_head_request(tdc, sgreq, to_terminate); + st = handle_continuous_head_request(tdc, to_terminate); if (!st) dma_desc->dma_status = DMA_ERROR; }
Remove unused function argument from handle_continuous_head_request(). Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/dma/tegra20-apb-dma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)