| Message ID | 20200128170418.15912-1-GNUtoo@cyberdimension.org |
|---|---|
| State | Rejected |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | [v2,1/3] tbs2910: disable fuse command | expand |
On Tue, Jan 28, 2020 at 2:04 PM Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> wrote: > > The fuse command is not needed for booting or during usual > users interactions with u-boot. > > As that the resulting u-boot.imx image is already very > close to the size limit, removing the fuse command shouldn't > hurt. > > With arm-linux-gnueabi-gcc 9.2.0-1 from the Parabola > GNU/Linux distribution, it shrinks the image from 392192 to > 388096 bytes. I think it would be more readable if you put the delta value instead of initial versus final.
Sorry, sent with wrong sender address. Please only use this address here. Soeren On 28.01.20 18:13, Soeren Moch wrote: > On 28.01.20 18:07, Fabio Estevam wrote: >> On Tue, Jan 28, 2020 at 2:04 PM Denis 'GNUtoo' Carikli >> <GNUtoo@cyberdimension.org> wrote: >>> The fuse command is not needed for booting or during usual >>> users interactions with u-boot. >>> >>> As that the resulting u-boot.imx image is already very >>> close to the size limit, removing the fuse command shouldn't >>> hurt. >>> >>> With arm-linux-gnueabi-gcc 9.2.0-1 from the Parabola >>> GNU/Linux distribution, it shrinks the image from 392192 to >>> 388096 bytes. >> I think it would be more readable if you put the delta value instead >> of initial versus final. > Which is 4k, surprise, surprise, the alignment of imx files. Actually > you only shrink the binary by a few bytes, which is not worth the pain > it you need fuses. > > Tom today merged a patch with much bigger size reduction (mentioned > earlier), so this should not be required. > > Soeren
On 28.01.20 18:04, Denis 'GNUtoo' Carikli wrote: > The fuse command is not needed for booting or during usual > users interactions with u-boot. > > As that the resulting u-boot.imx image is already very > close to the size limit, removing the fuse command shouldn't > hurt. > > With arm-linux-gnueabi-gcc 9.2.0-1 from the Parabola > GNU/Linux distribution, it shrinks the image from 392192 to > 388096 bytes. > > Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> The fuse command is useful for tbs2910, especially for 1.x board revisions. So NAK. Soeren
diff --git a/configs/tbs2910_defconfig b/configs/tbs2910_defconfig index 61d4c74324..0f12b94257 100644 --- a/configs/tbs2910_defconfig +++ b/configs/tbs2910_defconfig @@ -24,6 +24,7 @@ CONFIG_CMD_BOOTZ=y # CONFIG_BOOTM_VXWORKS is not set # CONFIG_CMD_FDT is not set CONFIG_CMD_MEMTEST=y +# CONFIG_CMD_FUSE is not set CONFIG_CMD_GPIO=y CONFIG_CMD_I2C=y CONFIG_CMD_MMC=y
The fuse command is not needed for booting or during usual users interactions with u-boot. As that the resulting u-boot.imx image is already very close to the size limit, removing the fuse command shouldn't hurt. With arm-linux-gnueabi-gcc 9.2.0-1 from the Parabola GNU/Linux distribution, it shrinks the image from 392192 to 388096 bytes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> --- configs/tbs2910_defconfig | 1 + 1 file changed, 1 insertion(+)