| Message ID | 20200124161828.12206-3-horatiu.vultur@microchip.com |
|---|---|
| State | RFC |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: bridge: mrp: Add support for Media Redundancy Protocol (MRP) | expand |
On Fri, Jan 24, 2020 at 05:18:20PM +0100, Horatiu Vultur wrote: > In case the HW is capable to detect when the MRP ring is open or closed. It is > expected that the network driver will notify the bridge that the ring is open or > closed. > > The function br_mrp_port_open is used to notify the kernel that one of the ports > stopped receiving MRP_Test frames. The argument 'loc' has a value of '1' when > the port stopped receiving MRP_Test and '0' when it started to receive MRP_Test. Hi Horatiu Given the name of the function, br_mrp_port_open(), how about replacing loc with a bool with the name open? Andrew
The 01/24/2020 18:37, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Fri, Jan 24, 2020 at 05:18:20PM +0100, Horatiu Vultur wrote: > > In case the HW is capable to detect when the MRP ring is open or closed. It is > > expected that the network driver will notify the bridge that the ring is open or > > closed. > > > > The function br_mrp_port_open is used to notify the kernel that one of the ports > > stopped receiving MRP_Test frames. The argument 'loc' has a value of '1' when > > the port stopped receiving MRP_Test and '0' when it started to receive MRP_Test. > > Hi Horatiu > > Given the name of the function, br_mrp_port_open(), how about replacing > loc with a bool with the name open? Hi Andrew, Well spotted, yes I will replace this in the next series. > > Andrew
diff --git a/include/linux/mrp_bridge.h b/include/linux/mrp_bridge.h new file mode 100644 index 000000000000..0508bbe6ecdb --- /dev/null +++ b/include/linux/mrp_bridge.h @@ -0,0 +1,25 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef _LINUX_MRP_BRIDGE_H +#define _LINUX_MRO_BRIDGE_H + +#include <linux/netdevice.h> + +/* The drivers are responsible to call this function when it detects that the + * MRP port stopped receiving MRP_Test frames or it started to receive MRP_Test. + * The argument dev represents the port and loc(Lost of Continuity) has a value + * of 1 when it stopped receiving MRP_Test frames and a value of 0 when it + * started to receive frames. + * + * This eventually eventually notify the userspace which is required to react on + * thise changes. + */ + +#ifdef CONFIG_BRIDGE_MRP +void br_mrp_port_open(struct net_device *dev, u8 loc); +#else +inline void br_mrp_port_open(struct net_device *dev, u8 loc) {} +#endif + +#endif +
In case the HW is capable to detect when the MRP ring is open or closed. It is expected that the network driver will notify the bridge that the ring is open or closed. The function br_mrp_port_open is used to notify the kernel that one of the ports stopped receiving MRP_Test frames. The argument 'loc' has a value of '1' when the port stopped receiving MRP_Test and '0' when it started to receive MRP_Test. This notification will eventually reach the userspace via netlink interface and the userspace application will process this information. Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com> --- include/linux/mrp_bridge.h | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 include/linux/mrp_bridge.h