| Message ID | 20200124105753.15976-1-dafna.hirschfeld@collabora.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | dt-bindings: fix compilation error of the example in marvell,mmp3-hsic-phy.yaml | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | "total: 0 errors, 1 warnings, 7 lines checked" |
On Fri, Jan 24, 2020 at 4:58 AM Dafna Hirschfeld <dafna.hirschfeld@collabora.com> wrote: > > Running `make dt_binging_check`, gives the error: > > DTC Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.example.dt.yaml > Error: Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.example.dts:20.41-42 syntax error > FATAL ERROR: Unable to parse input tree > > This is because the example uses the macro GPIO_ACTIVE_HIGH which > is defined in gpio.h but the include of this header is missing. > Add the include to fix the error. > > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> Fixes: f6f149604eef ("dt-bindings: phy: Add binding for marvell,mmp3-hsic-phy") Acked-by: Rob Herring <robh@kernel.org> Arnd, Olof, The above commit is in your tree. Please apply this. Rob
On Fri, Jan 24, 2020 at 08:08:58AM -0600, Rob Herring wrote: > On Fri, Jan 24, 2020 at 4:58 AM Dafna Hirschfeld > <dafna.hirschfeld@collabora.com> wrote: > > > > Running `make dt_binging_check`, gives the error: > > > > DTC Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.example.dt.yaml > > Error: Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.example.dts:20.41-42 syntax error > > FATAL ERROR: Unable to parse input tree > > > > This is because the example uses the macro GPIO_ACTIVE_HIGH which > > is defined in gpio.h but the include of this header is missing. > > Add the include to fix the error. > > > > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> > > Fixes: f6f149604eef ("dt-bindings: phy: Add binding for marvell,mmp3-hsic-phy") > Acked-by: Rob Herring <robh@kernel.org> > > Arnd, Olof, The above commit is in your tree. Please apply this. Applied. Thanks, -Olof
diff --git a/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml b/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml index 7917a95cda78..5ab436189f3b 100644 --- a/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml +++ b/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml @@ -33,6 +33,7 @@ required: examples: - | + #include <dt-bindings/gpio/gpio.h> hsic-phy@f0001800 { compatible = "marvell,mmp3-hsic-phy"; reg = <0xf0001800 0x40>;
Running `make dt_binging_check`, gives the error: DTC Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.example.dt.yaml Error: Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.example.dts:20.41-42 syntax error FATAL ERROR: Unable to parse input tree This is because the example uses the macro GPIO_ACTIVE_HIGH which is defined in gpio.h but the include of this header is missing. Add the include to fix the error. Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> --- Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml | 1 + 1 file changed, 1 insertion(+)