| Message ID | 20200123115831.36842-2-quintela@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Multifd Migration Compression | expand |
* Juan Quintela (quintela@redhat.com) wrote: > Signed-off-by: Juan Quintela <quintela@redhat.com> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > --- > tests/qtest/migration-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c > index 26e2e77289..b6a74a05ce 100644 > --- a/tests/qtest/migration-test.c > +++ b/tests/qtest/migration-test.c > @@ -1291,7 +1291,7 @@ static void test_multifd_tcp(void) > wait_for_serial("dest_serial"); > wait_for_migration_complete(from); > test_migrate_end(from, to, true); > - free(uri); > + g_free(uri); > } > > int main(int argc, char **argv) > -- > 2.24.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
On 1/23/20 12:58 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela <quintela@redhat.com> Nothing changed since v4 (apart it is now v3), however it misses: Fixes: b99784ef6c3 Reviewed-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> See: https://www.mail-archive.com/qemu-devel@nongnu.org/msg672805.html https://www.mail-archive.com/qemu-devel@nongnu.org/msg672853.html > --- > tests/qtest/migration-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c > index 26e2e77289..b6a74a05ce 100644 > --- a/tests/qtest/migration-test.c > +++ b/tests/qtest/migration-test.c > @@ -1291,7 +1291,7 @@ static void test_multifd_tcp(void) > wait_for_serial("dest_serial"); > wait_for_migration_complete(from); > test_migrate_end(from, to, true); > - free(uri); > + g_free(uri); > } > > int main(int argc, char **argv) >
On Thu, Jan 23, 2020 at 12:58:11PM +0100, Juan Quintela wrote: > Signed-off-by: Juan Quintela <quintela@redhat.com> > --- > tests/qtest/migration-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c > index 26e2e77289..b6a74a05ce 100644 > --- a/tests/qtest/migration-test.c > +++ b/tests/qtest/migration-test.c > @@ -1291,7 +1291,7 @@ static void test_multifd_tcp(void) > wait_for_serial("dest_serial"); > wait_for_migration_complete(from); > test_migrate_end(from, to, true); > - free(uri); > + g_free(uri); Not an objection to this patch, just a general FYI. Our min glib guarantees that g_malloc/g_free are always using the system allocator. So using free() is not a correctness problem these days. In general I'd suggest eliminating both free() and g_free(), and instead annotating the variable decl for automatic free. eg g_autofree char *uri = NULL; Regards, Daniel
Daniel P. Berrangé <berrange@redhat.com> wrote: > On Thu, Jan 23, 2020 at 12:58:11PM +0100, Juan Quintela wrote: >> Signed-off-by: Juan Quintela <quintela@redhat.com> >> --- >> tests/qtest/migration-test.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c >> index 26e2e77289..b6a74a05ce 100644 >> --- a/tests/qtest/migration-test.c >> +++ b/tests/qtest/migration-test.c >> @@ -1291,7 +1291,7 @@ static void test_multifd_tcp(void) >> wait_for_serial("dest_serial"); >> wait_for_migration_complete(from); >> test_migrate_end(from, to, true); >> - free(uri); >> + g_free(uri); > > Not an objection to this patch, just a general FYI. > > Our min glib guarantees that g_malloc/g_free are always using the > system allocator. So using free() is not a correctness problem > these days. Ok. But the rest of the file uses g_malloc/g_free and friends O:-) > In general I'd suggest eliminating both free() and g_free(), and instead > annotating the variable decl for automatic free. eg > > g_autofree char *uri = NULL; I will investigate this, thanks. Later, Juan.
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 26e2e77289..b6a74a05ce 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@ -1291,7 +1291,7 @@ static void test_multifd_tcp(void) wait_for_serial("dest_serial"); wait_for_migration_complete(from); test_migrate_end(from, to, true); - free(uri); + g_free(uri); } int main(int argc, char **argv)
Signed-off-by: Juan Quintela <quintela@redhat.com> --- tests/qtest/migration-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)