diff mbox series

[v3,1/2] MAINTAINERS: Add missing m48t59 files to the PReP section

Message ID 20200117165809.31067-2-philmd@redhat.com
State New
Headers show
Series hw/timer/m48t59: Convert to trace events | expand

Commit Message

Philippe Mathieu-Daudé Jan. 17, 2020, 4:58 p.m. UTC 
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Huth Jan. 20, 2020, 5:53 a.m. UTC | #1 
On 17/01/2020 17.58, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4b425d030d..c162145bd0 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1084,6 +1084,8 @@ F: hw/pci-host/prep.[hc]
>  F: hw/isa/i82378.c
>  F: hw/isa/pc87312.c
>  F: hw/dma/i82374.c
> +F: hw/rtc/m48t59.c
> +F: hw/rtc/m48t59-internal.h
>  F: hw/rtc/m48t59-isa.c
>  F: include/hw/isa/pc87312.h
>  F: include/hw/rtc/m48t59.h

Why only PReP? The device seems also to be used by Sparc machines...?

 Thomas
Thomas Huth Jan. 20, 2020, 5:54 a.m. UTC | #2 
On 17/01/2020 17.58, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4b425d030d..c162145bd0 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1084,6 +1084,8 @@ F: hw/pci-host/prep.[hc]
>  F: hw/isa/i82378.c
>  F: hw/isa/pc87312.c
>  F: hw/dma/i82374.c
> +F: hw/rtc/m48t59.c
> +F: hw/rtc/m48t59-internal.h
>  F: hw/rtc/m48t59-isa.c

You could also use a wildcard instead of the three lines:

F: hw/rtc/m48t59*

 Thomas
Philippe Mathieu-Daudé Jan. 20, 2020, 7:10 p.m. UTC | #3 
On 1/20/20 6:53 AM, Thomas Huth wrote:
> On 17/01/2020 17.58, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>   MAINTAINERS | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 4b425d030d..c162145bd0 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1084,6 +1084,8 @@ F: hw/pci-host/prep.[hc]
>>   F: hw/isa/i82378.c
>>   F: hw/isa/pc87312.c
>>   F: hw/dma/i82374.c
>> +F: hw/rtc/m48t59.c
>> +F: hw/rtc/m48t59-internal.h
>>   F: hw/rtc/m48t59-isa.c
>>   F: include/hw/isa/pc87312.h
>>   F: include/hw/rtc/m48t59.h
> 
> Why only PReP? The device seems also to be used by Sparc machines...?

Indeed, and also the PowerPC405 evaluation boards, so I'll simply drop 
this patch.
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 4b425d030d..c162145bd0 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1084,6 +1084,8 @@  F: hw/pci-host/prep.[hc]
 F: hw/isa/i82378.c
 F: hw/isa/pc87312.c
 F: hw/dma/i82374.c
+F: hw/rtc/m48t59.c
+F: hw/rtc/m48t59-internal.h
 F: hw/rtc/m48t59-isa.c
 F: include/hw/isa/pc87312.h
 F: include/hw/rtc/m48t59.h