| Message ID | 20200116170035.261803-3-fbl@sysclose.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Add support for TSO with DPDK | expand |
On 16.01.2020 18:00, Flavio Leitner wrote: > There is no support for multi-segmented buffers, so flag > that to vhost library. > > Signed-off-by: Flavio Leitner <fbl@sysclose.org> > --- > lib/netdev-dpdk.c | 6 ++++++ > 1 file changed, 6 insertions(+) > Suggesting to rename this patch to: 'netdev-dpdk: Disable multi-segmented buffers for vhost.' Otherwise, Acked-by: Ilya Maximets <i.maximets@ovn.org>
On 1/17/2020 4:24 PM, Ilya Maximets wrote: > On 16.01.2020 18:00, Flavio Leitner wrote: >> There is no support for multi-segmented buffers, so flag >> that to vhost library. >> >> Signed-off-by: Flavio Leitner <fbl@sysclose.org> >> --- >> lib/netdev-dpdk.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> > > Suggesting to rename this patch to: > 'netdev-dpdk: Disable multi-segmented buffers for vhost.' > > Otherwise, > Acked-by: Ilya Maximets <i.maximets@ovn.org> > Thanks Ilya, both pushed to master. BR Ian
On 1/17/2020 5:48 PM, Stokes, Ian wrote: > > > On 1/17/2020 4:24 PM, Ilya Maximets wrote: >> On 16.01.2020 18:00, Flavio Leitner wrote: >>> There is no support for multi-segmented buffers, so flag >>> that to vhost library. >>> >>> Signed-off-by: Flavio Leitner <fbl@sysclose.org> >>> --- >>> lib/netdev-dpdk.c | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >> >> Suggesting to rename this patch to: >> 'netdev-dpdk: Disable multi-segmented buffers for vhost.' >> >> Otherwise, >> Acked-by: Ilya Maximets <i.maximets@ovn.org> >> > Sincere apologies, Ilya, I've applied the original patches without the name change, completely unintended (long week). Regards Ian > Thanks Ilya, both pushed to master. > > BR > Ian > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 72b67af1a..d1469f6f2 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -1347,6 +1347,9 @@ netdev_dpdk_vhost_construct(struct netdev *netdev) dev->vhost_id = xasprintf("%s/%s", dpdk_get_vhost_sock_dir(), name); dev->vhost_driver_flags &= ~RTE_VHOST_USER_CLIENT; + + /* There is no support for multi-segments buffers. */ + dev->vhost_driver_flags |= RTE_VHOST_USER_LINEARBUF_SUPPORT; err = rte_vhost_driver_register(dev->vhost_id, dev->vhost_driver_flags); if (err) { VLOG_ERR("vhost-user socket device setup failure for socket %s\n", @@ -4952,6 +4955,9 @@ netdev_dpdk_vhost_client_reconfigure(struct netdev *netdev) /* Register client-mode device. */ vhost_flags |= RTE_VHOST_USER_CLIENT; + /* There is no support for multi-segments buffers. */ + vhost_flags |= RTE_VHOST_USER_LINEARBUF_SUPPORT; + /* Enable IOMMU support, if explicitly requested. */ if (dpdk_vhost_iommu_enabled()) { vhost_flags |= RTE_VHOST_USER_IOMMU_SUPPORT;
There is no support for multi-segmented buffers, so flag that to vhost library. Signed-off-by: Flavio Leitner <fbl@sysclose.org> --- lib/netdev-dpdk.c | 6 ++++++ 1 file changed, 6 insertions(+)