| Message ID | 20200115151652.10826-1-m.szyprowski@samsung.com |
|---|---|
| State | Superseded |
| Delegated to: | Minkyu Kang |
| Headers | show |
| Series | arm: exynos: Use proper PMIC device name | expand |
Hi Marek, On Wed, 15 Jan 2020 at 20:47, Marek Szyprowski <m.szyprowski@samsung.com> wrote: > > Since commit 4213609cc7 ("drivers: core: use strcmp when find device by > name") one has to provide full name to get requested object. Fix the code > used to detect enable power regulators on Odroid boards to use proper PMIC > device device name then. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > board/samsung/common/exynos5-dt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/samsung/common/exynos5-dt.c b/board/samsung/common/exynos5-dt.c > index 87eb381345..c5e77480f5 100644 > --- a/board/samsung/common/exynos5-dt.c > +++ b/board/samsung/common/exynos5-dt.c > @@ -64,7 +64,7 @@ int exynos_power_init(void) > int ret; > > #ifdef CONFIG_PMIC_S2MPS11 > - ret = pmic_get("s2mps11_pmic", &dev); > + ret = pmic_get("s2mps11_pmic@66", &dev); > #else > ret = pmic_get("max77686", &dev); > if (!ret) { > -- > 2.17.1 > Please add my Reviewed-by: Anand Moon <linux.amoon@gmail.com> I was going to send similar patch, Their is another place where this chances needed to avoid following failed adc@12D10000: Can't update Vdd. Error: -19Type: hc1 # board/samsung/common/exynos5-dt-types.c -Anand
On Wed, 15 Jan 2020 16:16:52 +0100 Marek Szyprowski <m.szyprowski@samsung.com> wrote: > Since commit 4213609cc7 ("drivers: core: use strcmp when find device > by name") one has to provide full name to get requested object. Fix > the code used to detect enable power regulators on Odroid boards to > use proper PMIC device device name then. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > board/samsung/common/exynos5-dt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/samsung/common/exynos5-dt.c > b/board/samsung/common/exynos5-dt.c index 87eb381345..c5e77480f5 > 100644 --- a/board/samsung/common/exynos5-dt.c > +++ b/board/samsung/common/exynos5-dt.c > @@ -64,7 +64,7 @@ int exynos_power_init(void) > int ret; > > #ifdef CONFIG_PMIC_S2MPS11 > - ret = pmic_get("s2mps11_pmic", &dev); > + ret = pmic_get("s2mps11_pmic@66", &dev); > #else > ret = pmic_get("max77686", &dev); > if (!ret) { Reviewed-by: Lukasz Majewski <lukma@denx.de> Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
diff --git a/board/samsung/common/exynos5-dt.c b/board/samsung/common/exynos5-dt.c index 87eb381345..c5e77480f5 100644 --- a/board/samsung/common/exynos5-dt.c +++ b/board/samsung/common/exynos5-dt.c @@ -64,7 +64,7 @@ int exynos_power_init(void) int ret; #ifdef CONFIG_PMIC_S2MPS11 - ret = pmic_get("s2mps11_pmic", &dev); + ret = pmic_get("s2mps11_pmic@66", &dev); #else ret = pmic_get("max77686", &dev); if (!ret) {
Since commit 4213609cc7 ("drivers: core: use strcmp when find device by name") one has to provide full name to get requested object. Fix the code used to detect enable power regulators on Odroid boards to use proper PMIC device device name then. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- board/samsung/common/exynos5-dt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)