Message ID | 1577114139-14984-8-git-send-email-yamonkar@cadence.com |
---|---|
State | Not Applicable, archived |
Headers | show |
Series | PHY: Update Cadence Torrent PHY driver with reconfiguration | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success |
On 23/12/2019 17:15, Yuti Amonkar wrote: > Add Torrent PHY reference clock bindings.This will not affect ABI as > the driver has never been functional, and therefore do not exist in > any active use case > I think this could very well be a part of the first patch. There is no requirement for the driver to actually use all properties in the binding. > Signed-off-by: Yuti Amonkar <yamonkar@cadence.com> > --- > .../devicetree/bindings/phy/phy-cadence-torrent.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml > index 3587312..907b627 100644 > --- a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml > +++ b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml > @@ -17,6 +17,14 @@ properties: > compatible: > const: cdns,torrent-phy > > + clocks: > + maxItems: 1 > + description: > + PHY reference clock. Must contain an entry in clock-names. > + > + clock-names: > + const: refclk > + > reg: > items: > - description: Offset of the DPTX PHY configuration registers. > @@ -46,6 +54,8 @@ properties: > > required: > - compatible > + - clocks > + - clock-names > - reg > - "#phy-cells" > > @@ -60,5 +70,7 @@ examples: > num_lanes = <4>; > max_bit_rate = <8100>; > #phy-cells = <0>; > + clocks = <&ref_clk>; > + clock-names = "refclk"; > }; > ... >
On Mon, 23 Dec 2019 16:15:32 +0100, Yuti Amonkar wrote: > Add Torrent PHY reference clock bindings.This will not affect ABI as > the driver has never been functional, and therefore do not exist in > any active use case > > Signed-off-by: Yuti Amonkar <yamonkar@cadence.com> > --- > .../devicetree/bindings/phy/phy-cadence-torrent.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml index 3587312..907b627 100644 --- a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml +++ b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml @@ -17,6 +17,14 @@ properties: compatible: const: cdns,torrent-phy + clocks: + maxItems: 1 + description: + PHY reference clock. Must contain an entry in clock-names. + + clock-names: + const: refclk + reg: items: - description: Offset of the DPTX PHY configuration registers. @@ -46,6 +54,8 @@ properties: required: - compatible + - clocks + - clock-names - reg - "#phy-cells" @@ -60,5 +70,7 @@ examples: num_lanes = <4>; max_bit_rate = <8100>; #phy-cells = <0>; + clocks = <&ref_clk>; + clock-names = "refclk"; }; ...
Add Torrent PHY reference clock bindings.This will not affect ABI as the driver has never been functional, and therefore do not exist in any active use case Signed-off-by: Yuti Amonkar <yamonkar@cadence.com> --- .../devicetree/bindings/phy/phy-cadence-torrent.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+)