Message ID | 1307453803-31950-27-git-send-email-dbaryshkov@gmail.com |
---|---|
State | Accepted |
Headers | show |
On Tue, 2011-06-07 at 17:36 +0400, Dmitry Eremin-Solenikov wrote: > + mtd_device_parse_register(cs553x_mtd[i], NULL, > 0, > + NULL, 0); You do not need 2 lines here.
On 6/8/11, Artem Bityutskiy <dedekind1@gmail.com> wrote: > On Tue, 2011-06-07 at 17:36 +0400, Dmitry Eremin-Solenikov wrote: >> + mtd_device_parse_register(cs553x_mtd[i], NULL, >> 0, >> + NULL, 0); > > You do not need 2 lines here. 84 syms.
diff --git a/drivers/mtd/nand/cs553x_nand.c b/drivers/mtd/nand/cs553x_nand.c index b2bdf72..4aac849 100644 --- a/drivers/mtd/nand/cs553x_nand.c +++ b/drivers/mtd/nand/cs553x_nand.c @@ -283,8 +283,6 @@ static int __init cs553x_init(void) int err = -ENXIO; int i; uint64_t val; - int mtd_parts_nb = 0; - struct mtd_partition *mtd_parts = NULL; /* If the CPU isn't a Geode GX or LX, abort */ if (!is_geode()) @@ -316,9 +314,8 @@ static int __init cs553x_init(void) if (cs553x_mtd[i]) { /* If any devices registered, return success. Else the last error. */ - mtd_parts_nb = parse_mtd_partitions(cs553x_mtd[i], NULL, &mtd_parts, 0); - mtd_device_register(cs553x_mtd[i], mtd_parts, - mtd_parts_nb); + mtd_device_parse_register(cs553x_mtd[i], NULL, 0, + NULL, 0); err = 0; } }
Replace custom invocations of parse_mtd_partitions and mtd_device_register with common mtd_device_parse_register call. This would bring: standard handling of all errors, fallback to default partitions, etc. Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> --- drivers/mtd/nand/cs553x_nand.c | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-)