| Message ID | 20191216064407.32310-1-o.rempel@pengutronix.de |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | [v1] net: ag71xx: fix compile warnings | expand |
On Mon, Dec 16, 2019 at 07:44:07AM +0100, Oleksij Rempel wrote: > drivers/net/ethernet/atheros/ag71xx.c: In function 'ag71xx_probe': > drivers/net/ethernet/atheros/ag71xx.c:1776:30: warning: passing argument 2 of > 'of_get_phy_mode' makes pointer from integer without a cast [-Wint-conversion] > In file included from drivers/net/ethernet/atheros/ag71xx.c:33: > ./include/linux/of_net.h:15:69: note: expected 'phy_interface_t *' > {aka 'enum <anonymous> *'} but argument is of type 'int' > > Fixes: 0c65b2b90d13c1 ("net: of_get_phy_mode: Change API to solve int/unit warnings") > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
From: Oleksij Rempel <o.rempel@pengutronix.de> Date: Mon, 16 Dec 2019 07:44:07 +0100 > drivers/net/ethernet/atheros/ag71xx.c: In function 'ag71xx_probe': > drivers/net/ethernet/atheros/ag71xx.c:1776:30: warning: passing argument 2 of > 'of_get_phy_mode' makes pointer from integer without a cast [-Wint-conversion] > In file included from drivers/net/ethernet/atheros/ag71xx.c:33: > ./include/linux/of_net.h:15:69: note: expected 'phy_interface_t *' > {aka 'enum <anonymous> *'} but argument is of type 'int' > > Fixes: 0c65b2b90d13c1 ("net: of_get_phy_mode: Change API to solve int/unit warnings") > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> This patch does not apply to the net tree.
diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c index e0958fc0bd57..3b02b55c2545 100644 --- a/drivers/net/ethernet/atheros/ag71xx.c +++ b/drivers/net/ethernet/atheros/ag71xx.c @@ -314,7 +314,7 @@ struct ag71xx { struct ag71xx_desc *stop_desc; dma_addr_t stop_desc_dma; - int phy_if_mode; + phy_interface_t phy_if_mode; struct phylink *phylink; struct phylink_config phylink_config; @@ -1773,7 +1773,7 @@ static int ag71xx_probe(struct platform_device *pdev) eth_random_addr(ndev->dev_addr); } - err = of_get_phy_mode(np, ag->phy_if_mode); + err = of_get_phy_mode(np, &ag->phy_if_mode); if (err) { netif_err(ag, probe, ndev, "missing phy-mode property in DT\n"); goto err_free;
drivers/net/ethernet/atheros/ag71xx.c: In function 'ag71xx_probe': drivers/net/ethernet/atheros/ag71xx.c:1776:30: warning: passing argument 2 of 'of_get_phy_mode' makes pointer from integer without a cast [-Wint-conversion] In file included from drivers/net/ethernet/atheros/ag71xx.c:33: ./include/linux/of_net.h:15:69: note: expected 'phy_interface_t *' {aka 'enum <anonymous> *'} but argument is of type 'int' Fixes: 0c65b2b90d13c1 ("net: of_get_phy_mode: Change API to solve int/unit warnings") Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- drivers/net/ethernet/atheros/ag71xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)