| Message ID | 20191206044134.259488-1-david@gibson.dropbear.id.au |
|---|---|
| State | New |
| Headers | show |
On Fri, 6 Dec 2019 at 04:41, David Gibson <david@gibson.dropbear.id.au> wrote: > > The following changes since commit 1bdc319ab5d289ce6b822e06fb2b13666fd9278e: > > Update version for v4.2.0-rc4 release (2019-12-03 17:56:30 +0000) > > are available in the Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-4.2-20191206 > > for you to fetch changes up to d887a8cfc083bcf3856f9f42352989f3624e0cae: > > pseries: Update SLOF firmware image (2019-12-06 15:33:23 +1100) > > ---------------------------------------------------------------- > ppc patch queue 2019-12-06 > > This is a last minute pull request for ppc-for-4.2. I know it's very > late in freeze, but this does fix a regression: a bad interaction > between the new qemu and SLOF device tree construction code means that > SLOF will crash if PCI to PCI bridges are included in the system. I really really really don't want to do an rc5. This would have to be "everybody using ppc gets crashes" for me to really want to put it in at this point... thanks -- PMM
On Fri, Dec 06, 2019 at 09:52:54AM +0000, Peter Maydell wrote: > On Fri, 6 Dec 2019 at 04:41, David Gibson <david@gibson.dropbear.id.au> wrote: > > > > The following changes since commit 1bdc319ab5d289ce6b822e06fb2b13666fd9278e: > > > > Update version for v4.2.0-rc4 release (2019-12-03 17:56:30 +0000) > > > > are available in the Git repository at: > > > > git://github.com/dgibson/qemu.git tags/ppc-for-4.2-20191206 > > > > for you to fetch changes up to d887a8cfc083bcf3856f9f42352989f3624e0cae: > > > > pseries: Update SLOF firmware image (2019-12-06 15:33:23 +1100) > > > > ---------------------------------------------------------------- > > ppc patch queue 2019-12-06 > > > > This is a last minute pull request for ppc-for-4.2. I know it's very > > late in freeze, but this does fix a regression: a bad interaction > > between the new qemu and SLOF device tree construction code means that > > SLOF will crash if PCI to PCI bridges are included in the system. > > I really really really don't want to do an rc5. This would > have to be "everybody using ppc gets crashes" for me to > really want to put it in at this point... Yeah, alright. I'll send it to Mike for a 4.2.1.
On Fri, 6 Dec 2019 at 10:43, David Gibson <david@gibson.dropbear.id.au> wrote: > > On Fri, Dec 06, 2019 at 09:52:54AM +0000, Peter Maydell wrote: > > On Fri, 6 Dec 2019 at 04:41, David Gibson <david@gibson.dropbear.id.au> wrote: > > > > > > The following changes since commit 1bdc319ab5d289ce6b822e06fb2b13666fd9278e: > > > > > > Update version for v4.2.0-rc4 release (2019-12-03 17:56:30 +0000) > > > > > > are available in the Git repository at: > > > > > > git://github.com/dgibson/qemu.git tags/ppc-for-4.2-20191206 > > > > > > for you to fetch changes up to d887a8cfc083bcf3856f9f42352989f3624e0cae: > > > > > > pseries: Update SLOF firmware image (2019-12-06 15:33:23 +1100) > > > > > > ---------------------------------------------------------------- > > > ppc patch queue 2019-12-06 > > > > > > This is a last minute pull request for ppc-for-4.2. I know it's very > > > late in freeze, but this does fix a regression: a bad interaction > > > between the new qemu and SLOF device tree construction code means that > > > SLOF will crash if PCI to PCI bridges are included in the system. > > > > I really really really don't want to do an rc5. This would > > have to be "everybody using ppc gets crashes" for me to > > really want to put it in at this point... > > Yeah, alright. I'll send it to Mike for a 4.2.1. Paolo says he has something that needs to go into rc5, so maybe we can take this too. How confident are you that the change is small and safe? It's a bit hard to tell with updates to firmware binaries. thanks -- PMM
On Fri, 6 Dec 2019 at 11:19, Peter Maydell <peter.maydell@linaro.org> wrote: > > On Fri, 6 Dec 2019 at 10:43, David Gibson <david@gibson.dropbear.id.au> wrote: > > > > On Fri, Dec 06, 2019 at 09:52:54AM +0000, Peter Maydell wrote: > > > On Fri, 6 Dec 2019 at 04:41, David Gibson <david@gibson.dropbear.id.au> wrote: > > > > > > > > The following changes since commit 1bdc319ab5d289ce6b822e06fb2b13666fd9278e: > > > > > > > > Update version for v4.2.0-rc4 release (2019-12-03 17:56:30 +0000) > > > > > > > > are available in the Git repository at: > > > > > > > > git://github.com/dgibson/qemu.git tags/ppc-for-4.2-20191206 > > > > > > > > for you to fetch changes up to d887a8cfc083bcf3856f9f42352989f3624e0cae: > > > > > > > > pseries: Update SLOF firmware image (2019-12-06 15:33:23 +1100) > > > > > > > > ---------------------------------------------------------------- > > > > ppc patch queue 2019-12-06 > > > > > > > > This is a last minute pull request for ppc-for-4.2. I know it's very > > > > late in freeze, but this does fix a regression: a bad interaction > > > > between the new qemu and SLOF device tree construction code means that > > > > SLOF will crash if PCI to PCI bridges are included in the system. > > > > > > I really really really don't want to do an rc5. This would > > > have to be "everybody using ppc gets crashes" for me to > > > really want to put it in at this point... > > > > Yeah, alright. I'll send it to Mike for a 4.2.1. > > Paolo says he has something that needs to go into rc5, so maybe > we can take this too. How confident are you that the change is > small and safe? It's a bit hard to tell with updates to > firmware binaries. ...I just read the commit message for the firmware blob update. That is way too many random changes to go into rc5. I'd have taken a firmware blob update that was just "one change, fixing this specific bug", but not one which has all that other stuff too. thanks -- PMM
On Fri, Dec 06, 2019 at 01:40:19PM +0000, Peter Maydell wrote: > On Fri, 6 Dec 2019 at 11:19, Peter Maydell <peter.maydell@linaro.org> wrote: > > > > On Fri, 6 Dec 2019 at 10:43, David Gibson <david@gibson.dropbear.id.au> wrote: > > > > > > On Fri, Dec 06, 2019 at 09:52:54AM +0000, Peter Maydell wrote: > > > > On Fri, 6 Dec 2019 at 04:41, David Gibson <david@gibson.dropbear.id.au> wrote: > > > > > > > > > > The following changes since commit 1bdc319ab5d289ce6b822e06fb2b13666fd9278e: > > > > > > > > > > Update version for v4.2.0-rc4 release (2019-12-03 17:56:30 +0000) > > > > > > > > > > are available in the Git repository at: > > > > > > > > > > git://github.com/dgibson/qemu.git tags/ppc-for-4.2-20191206 > > > > > > > > > > for you to fetch changes up to d887a8cfc083bcf3856f9f42352989f3624e0cae: > > > > > > > > > > pseries: Update SLOF firmware image (2019-12-06 15:33:23 +1100) > > > > > > > > > > ---------------------------------------------------------------- > > > > > ppc patch queue 2019-12-06 > > > > > > > > > > This is a last minute pull request for ppc-for-4.2. I know it's very > > > > > late in freeze, but this does fix a regression: a bad interaction > > > > > between the new qemu and SLOF device tree construction code means that > > > > > SLOF will crash if PCI to PCI bridges are included in the system. > > > > > > > > I really really really don't want to do an rc5. This would > > > > have to be "everybody using ppc gets crashes" for me to > > > > really want to put it in at this point... > > > > > > Yeah, alright. I'll send it to Mike for a 4.2.1. > > > > Paolo says he has something that needs to go into rc5, so maybe > > we can take this too. How confident are you that the change is > > small and safe? It's a bit hard to tell with updates to > > firmware binaries. > > ...I just read the commit message for the firmware blob update. > That is way too many random changes to go into rc5. I'd have > taken a firmware blob update that was just "one change, fixing > this specific bug", but not one which has all that other stuff too. Yeah, that's a good point. I've just resent, but with a cherry-picked update that only includes the SLOF patches directly relevant to this regression.
The following changes since commit 1bdc319ab5d289ce6b822e06fb2b13666fd9278e: Update version for v4.2.0-rc4 release (2019-12-03 17:56:30 +0000) are available in the Git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-4.2-20191206 for you to fetch changes up to d887a8cfc083bcf3856f9f42352989f3624e0cae: pseries: Update SLOF firmware image (2019-12-06 15:33:23 +1100) ---------------------------------------------------------------- ppc patch queue 2019-12-06 This is a last minute pull request for ppc-for-4.2. I know it's very late in freeze, but this does fix a regression: a bad interaction between the new qemu and SLOF device tree construction code means that SLOF will crash if PCI to PCI bridges are included in the system. ---------------------------------------------------------------- Alexey Kardashevskiy (1): pseries: Update SLOF firmware image pc-bios/README | 2 +- pc-bios/slof.bin | Bin 928552 -> 931032 bytes roms/SLOF | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-)