diff mbox series

[v2,8/9] package/network-manager: adapt to preset-all

Message ID 20191111172443.6874-9-jeremy.rosen@smile.fr
State Changes Requested
Headers show
Series use host-systemd to enable units | expand

Commit Message

Jérémy ROSEN Nov. 11, 2019, 5:24 p.m. UTC 
NM has three services
* NetworkManger.service : the main daemon
* NetworkManger-dispatcher.service : a daemon handling network callbacks
* NetworkManager-wait-online.service : sync of other services with network-online

Only the first two were activated. We now also enable
wait-online. Not enabling it was probably a bug.

Note that buildroot adds an alias dbus-org.freedesktop.NetworkManager
Adding an alias that is not known upstream is not clean,
but I left it for backward compatibility
---
 package/network-manager/network-manager.mk | 7 -------
 1 file changed, 7 deletions(-)

Comments

Yann E. MORIN Dec. 5, 2019, 1:01 p.m. UTC | #1 
Jérémy, Nathaniel, All,

On 2019-11-11 18:24 +0100, Jérémy Rosen spake thusly:
> NM has three services
> * NetworkManger.service : the main daemon
> * NetworkManger-dispatcher.service : a daemon handling network callbacks
> * NetworkManager-wait-online.service : sync of other services with network-online
> 
> Only the first two were activated. We now also enable
> wait-online. Not enabling it was probably a bug.
> 
> Note that buildroot adds an alias dbus-org.freedesktop.NetworkManager
> Adding an alias that is not known upstream is not clean,
> but I left it for backward compatibility

Nathaniel, do you remember why you added that alias back in the day?
(yes, it's been 5 years now...)

I was not able to find any conlusive explanations with a cursory
duckduckgo search...

Reviewed-by: Yann E. MORIN <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/network-manager/network-manager.mk | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/package/network-manager/network-manager.mk b/package/network-manager/network-manager.mk
> index e913d69927..9ec205cc04 100644
> --- a/package/network-manager/network-manager.mk
> +++ b/package/network-manager/network-manager.mk
> @@ -88,16 +88,9 @@ define NETWORK_MANAGER_INSTALL_INIT_SYSV
>  endef
>  
>  define NETWORK_MANAGER_INSTALL_INIT_SYSTEMD
> -	mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
> -
>  	ln -sf /usr/lib/systemd/system/NetworkManager.service \
>  		$(TARGET_DIR)/etc/systemd/system/dbus-org.freedesktop.NetworkManager.service
>  
> -	ln -sf /usr/lib/systemd/system/NetworkManager.service \
> -		$(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/NetworkManager.service
> -
> -	ln -sf /usr/lib/systemd/system/NetworkManager-dispatcher.service \
> -		$(TARGET_DIR)/etc/systemd/system/dbus-org.freedesktop.nm-dispatcher.service
>  endef
>  
>  $(eval $(autotools-package))
> -- 
> 2.24.0.rc1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Arnout Vandecappelle Dec. 5, 2019, 10:29 p.m. UTC | #2 
On 05/12/2019 14:01, Yann E. MORIN wrote:
> Jérémy, Nathaniel, All,
> 
> On 2019-11-11 18:24 +0100, Jérémy Rosen spake thusly:
>> NM has three services
>> * NetworkManger.service : the main daemon
>> * NetworkManger-dispatcher.service : a daemon handling network callbacks
>> * NetworkManager-wait-online.service : sync of other services with network-online
>>
>> Only the first two were activated. We now also enable
>> wait-online. Not enabling it was probably a bug.
>>
>> Note that buildroot adds an alias dbus-org.freedesktop.NetworkManager
>> Adding an alias that is not known upstream is not clean,
>> but I left it for backward compatibility
> 
> Nathaniel, do you remember why you added that alias back in the day?
> (yes, it's been 5 years now...)
> 
> I was not able to find any conlusive explanations with a cursory
> duckduckgo search...

 My Fedora 30 has this symlink as well. I couldn't trace what generates it though.

$ ls -l /etc/systemd/system/dbus-org.*
lrwxrwxrwx. 1 root root 41 Oct 25  2018
/etc/systemd/system/dbus-org.bluez.service ->
/usr/lib/systemd/system/bluetooth.service
lrwxrwxrwx. 1 root root 41 Oct 25  2018
/etc/systemd/system/dbus-org.fedoraproject.FirewallD1.service ->
/usr/lib/systemd/system/firewalld.service
lrwxrwxrwx. 1 root root 44 Oct 25  2018
/etc/systemd/system/dbus-org.freedesktop.Avahi.service ->
/usr/lib/systemd/system/avahi-daemon.service
lrwxrwxrwx. 1 root root 44 Oct 25  2018
/etc/systemd/system/dbus-org.freedesktop.ModemManager1.service ->
/usr/lib/systemd/system/ModemManager.service
lrwxrwxrwx. 1 root root 46 Oct 25  2018
/etc/systemd/system/dbus-org.freedesktop.NetworkManager.service ->
/usr/lib/systemd/system/NetworkManager.service
lrwxrwxrwx. 1 root root 57 Oct 25  2018
/etc/systemd/system/dbus-org.freedesktop.nm-dispatcher.service ->
/usr/lib/systemd/system/NetworkManager-dispatcher.service
lrwxrwxrwx. 1 root root 41 Oct 25  2018
/etc/systemd/system/dbus-org.freedesktop.timedate1.service ->
/usr/lib/systemd/system/timedatex.service

 Regards,
 Arnout

> 
> Reviewed-by: Yann E. MORIN <yann.morin.1998@free.fr>
> 
> Regards,
> Yann E. MORIN.
> 
>> ---
>>  package/network-manager/network-manager.mk | 7 -------
>>  1 file changed, 7 deletions(-)
>>
>> diff --git a/package/network-manager/network-manager.mk b/package/network-manager/network-manager.mk
>> index e913d69927..9ec205cc04 100644
>> --- a/package/network-manager/network-manager.mk
>> +++ b/package/network-manager/network-manager.mk
>> @@ -88,16 +88,9 @@ define NETWORK_MANAGER_INSTALL_INIT_SYSV
>>  endef
>>  
>>  define NETWORK_MANAGER_INSTALL_INIT_SYSTEMD
>> -	mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
>> -
>>  	ln -sf /usr/lib/systemd/system/NetworkManager.service \
>>  		$(TARGET_DIR)/etc/systemd/system/dbus-org.freedesktop.NetworkManager.service
>>  
>> -	ln -sf /usr/lib/systemd/system/NetworkManager.service \
>> -		$(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/NetworkManager.service
>> -
>> -	ln -sf /usr/lib/systemd/system/NetworkManager-dispatcher.service \
>> -		$(TARGET_DIR)/etc/systemd/system/dbus-org.freedesktop.nm-dispatcher.service
>>  endef
>>  
>>  $(eval $(autotools-package))
>> -- 
>> 2.24.0.rc1
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
Jérémy ROSEN Dec. 7, 2019, 1:28 p.m. UTC | #3 
the alias to nm-dispatcher is provided by upstream and is available in BR.

The alias there is a question
is dbus-org.freedesktop.NetworkManager.service.
That one is not in debian, but it is in RH. I'll leave it to be safe...

Le jeu. 5 déc. 2019 à 23:29, Arnout Vandecappelle <arnout@mind.be> a écrit :

>
>
> On 05/12/2019 14:01, Yann E. MORIN wrote:
> > Jérémy, Nathaniel, All,
> >
> > On 2019-11-11 18:24 +0100, Jérémy Rosen spake thusly:
> >> NM has three services
> >> * NetworkManger.service : the main daemon
> >> * NetworkManger-dispatcher.service : a daemon handling network callbacks
> >> * NetworkManager-wait-online.service : sync of other services with
> network-online
> >>
> >> Only the first two were activated. We now also enable
> >> wait-online. Not enabling it was probably a bug.
> >>
> >> Note that buildroot adds an alias dbus-org.freedesktop.NetworkManager
> >> Adding an alias that is not known upstream is not clean,
> >> but I left it for backward compatibility
> >
> > Nathaniel, do you remember why you added that alias back in the day?
> > (yes, it's been 5 years now...)
> >
> > I was not able to find any conlusive explanations with a cursory
> > duckduckgo search...
>
>  My Fedora 30 has this symlink as well. I couldn't trace what generates it
> though.
>
> $ ls -l /etc/systemd/system/dbus-org.*
> lrwxrwxrwx. 1 root root 41 Oct 25  2018
> /etc/systemd/system/dbus-org.bluez.service ->
> /usr/lib/systemd/system/bluetooth.service
> lrwxrwxrwx. 1 root root 41 Oct 25  2018
> /etc/systemd/system/dbus-org.fedoraproject.FirewallD1.service ->
> /usr/lib/systemd/system/firewalld.service
> lrwxrwxrwx. 1 root root 44 Oct 25  2018
> /etc/systemd/system/dbus-org.freedesktop.Avahi.service ->
> /usr/lib/systemd/system/avahi-daemon.service
> lrwxrwxrwx. 1 root root 44 Oct 25  2018
> /etc/systemd/system/dbus-org.freedesktop.ModemManager1.service ->
> /usr/lib/systemd/system/ModemManager.service
> lrwxrwxrwx. 1 root root 46 Oct 25  2018
> /etc/systemd/system/dbus-org.freedesktop.NetworkManager.service ->
> /usr/lib/systemd/system/NetworkManager.service
> lrwxrwxrwx. 1 root root 57 Oct 25  2018
> /etc/systemd/system/dbus-org.freedesktop.nm-dispatcher.service ->
> /usr/lib/systemd/system/NetworkManager-dispatcher.service
> lrwxrwxrwx. 1 root root 41 Oct 25  2018
> /etc/systemd/system/dbus-org.freedesktop.timedate1.service ->
> /usr/lib/systemd/system/timedatex.service
>
>  Regards,
>  Arnout
>
> >
> > Reviewed-by: Yann E. MORIN <yann.morin.1998@free.fr>
> >
> > Regards,
> > Yann E. MORIN.
> >
> >> ---
> >>  package/network-manager/network-manager.mk | 7 -------
> >>  1 file changed, 7 deletions(-)
> >>
> >> diff --git a/package/network-manager/network-manager.mk
> b/package/network-manager/network-manager.mk
> >> index e913d69927..9ec205cc04 100644
> >> --- a/package/network-manager/network-manager.mk
> >> +++ b/package/network-manager/network-manager.mk
> >> @@ -88,16 +88,9 @@ define NETWORK_MANAGER_INSTALL_INIT_SYSV
> >>  endef
> >>
> >>  define NETWORK_MANAGER_INSTALL_INIT_SYSTEMD
> >> -    mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
> >> -
> >>      ln -sf /usr/lib/systemd/system/NetworkManager.service \
> >>
> $(TARGET_DIR)/etc/systemd/system/dbus-org.freedesktop.NetworkManager.service
> >>
> >> -    ln -sf /usr/lib/systemd/system/NetworkManager.service \
> >> -
> $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/NetworkManager.service
> >> -
> >> -    ln -sf /usr/lib/systemd/system/NetworkManager-dispatcher.service \
> >> -
> $(TARGET_DIR)/etc/systemd/system/dbus-org.freedesktop.nm-dispatcher.service
> >>  endef
> >>
> >>  $(eval $(autotools-package))
> >> --
> >> 2.24.0.rc1
> >>
> >> _______________________________________________
> >> buildroot mailing list
> >> buildroot@busybox.net
> >> http://lists.busybox.net/mailman/listinfo/buildroot
> >
>
diff mbox series

Patch

diff --git a/package/network-manager/network-manager.mk b/package/network-manager/network-manager.mk
index e913d69927..9ec205cc04 100644
--- a/package/network-manager/network-manager.mk
+++ b/package/network-manager/network-manager.mk
@@ -88,16 +88,9 @@  define NETWORK_MANAGER_INSTALL_INIT_SYSV
 endef
 
 define NETWORK_MANAGER_INSTALL_INIT_SYSTEMD
-	mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
-
 	ln -sf /usr/lib/systemd/system/NetworkManager.service \
 		$(TARGET_DIR)/etc/systemd/system/dbus-org.freedesktop.NetworkManager.service
 
-	ln -sf /usr/lib/systemd/system/NetworkManager.service \
-		$(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/NetworkManager.service
-
-	ln -sf /usr/lib/systemd/system/NetworkManager-dispatcher.service \
-		$(TARGET_DIR)/etc/systemd/system/dbus-org.freedesktop.nm-dispatcher.service
 endef
 
 $(eval $(autotools-package))