| Message ID | 1e1990d7fc5f4178c3c8175a25f3567826f642e5.camel@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | [SRU,Bionic,snapdragon,PULL] Enable support for UFS drive on DB820c and IFC6640 boards | expand |
On Tue, Dec 03, 2019 at 01:15:09PM +0800, Shrirang Bagul wrote: > BugLink: http://bugs.launchpad.net/bugs/1853556 All patches come from upstream, and two of the SAUCE patches (89f6deb399e0 "UBUNTU: SAUCE: phy: qcom-qmp: Increase PHY ready timeout" and fc08af59f86a "UBUNTU: SAUCE: phy: qcom: qmp: Use power_on/off ops for PCIe") are actually backports - the only real SAUCE patch is 01d866a0e043 "UBUNTU: SAUCE: arm64: dts: msm8996: db820c: disable pcie1 bus" that disables the pcie1 slot (empty on db820c and not-existent on ifc6640). Reported being tested on db820 and ifc6640. Acked-by: Paolo Pisati <paolo.pisati@canonical.com>
Acked-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
Hi Shrirang, On 2019-12-03 06:15, Shrirang Bagul wrote: > BugLink: http://bugs.launchpad.net/bugs/1853556 Please note that we have switched a while ago to use https instead of http for the BugLink's. I have fixed it while applying. > > [Impact] > Both Dragonboard 820c and Inforce 6640 (based on Snapdragon820 SoC) have a > Universal Flash Drive on-board. The patches in this pull request fix the > instabiliy issues and enable support for the UFS. > > [Fix] > Fix the bring-up of the QMP PHY shared between the UFS and the PCIE ports. > This patch set reverts patches picked-up from Linaro development tree and > replaces them with necessary updates from upstream mainline and stable kernel > trees. > > [Test Case] > Test kernel based on Ubuntu-snapdragon-4.15.0-1068.75 was verified on both the > DB820c and IFC6640. > > [Regression Risk] > Low. Kernel configs enabling the UFS were disabled in previous versions. > Also, pcie patches cause no regressions on DB410c. > > > The following changes since commit d724458ea5038070ca377366f6593625150b0def: > > UBUNTU: Ubuntu-snapdragon-4.15.0-1068.75 (2019-11-14 09:58:11 -0800) > > are available in the Git repository at: > > git://git.launchpad.net/~shrirang-bagul/ubuntu/+source/linux/+git/bionic snapdragon-ufs > > for you to fetch changes up to 01d866a0e0438f30b570b8cb5063fceedf4e529b: > > UBUNTU: SAUCE: arm64: dts: msm8996: db820c: disable pcie1 bus (2019-11-22 20:32:50 > +0800) > Applied to bionic/snapdragon branch. Thanks, Kleber > ---------------------------------------------------------------- > Arnd Bergmann (1): > PCI: qcom: Include gpio/consumer.h > > Bjorn Andersson (5): > arm64: dts: qcom: msm8996: Add ufs related nodes > phy: qcom-qmp: Correct ready status, again > PCI: qcom: Use clk bulk API for 2.4.0 controllers > UBUNTU: SAUCE: phy: qcom-qmp: Increase PHY ready timeout > UBUNTU: SAUCE: phy: qcom: qmp: Use power_on/off ops for PCIe > > Bjorn Helgaas (1): > PCI: Add Qualcomm vendor ID > > Dan Carpenter (1): > PCI: qcom: Fix a bitwise vs logical NOT typo > > Evan Green (6): > scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom > scsi: ufs: qcom: Expose the reset controller for PHY > dt-bindings: ufs: Add #reset-cells for Qualcomm controllers > dt-bindings: phy-qcom-qmp: Add UFS PHY reset > dt-bindings: phy: qcom-ufs: Add resets property > arm64: dts: msm8996: Add UFS PHY reset controller > > Kishon Vijay Abraham I (1): > phy: core: Invoke pm_runtime_get_*/pm_runtime_put_* before invoking reset callback > > Marc Gonzalez (3): > phy: qcom-qmp: Drop useless msm8998_pciephy_cfg setting > phy: qcom-qmp: Raise qcom_qmp_phy_enable() polling delay > PCI: qcom: Use default config space read function > > Paul Gortmaker (1): > phy: make phy-core explicitly non-modular > > Shawn Guo (1): > PCI: qcom: Drop unnecessary root_bus_nr setting > > Shrirang Bagul (10): > Revert "UBUNTU: [Config] disable PHY_QCOM_UFS" > Revert "UBUNTU: [Config] disable SCSI_UFSHCD" > Revert "dts: arm64/msm8996: Fix power domain for ufs" > Revert "arm64: dts: Add ufs dts nodes" > Revert "scsi: ufs: qcom: Expose the reset controller for PHY" > Revert "scsi: ufs: make UFS Tx lane1 clock optional for QCOM platforms" > Revert "scsi: ufs: ufshcd_dump_regs to use memcpy_fromio" > Revert "scsi: ufs: ufs-qcom: remove broken hci version quirk" > Revert "scsi/ufs: qcom: Remove ufs_qcom_phy_*() calls from host" > UBUNTU: SAUCE: arm64: dts: msm8996: db820c: disable pcie1 bus > > Srinivas Kandagatla (1): > PCI: qcom: Use regulator bulk api for apq8064 supplies > > Stanley Chu (2): > scsi: ufs-qcom: Re-factor ufshcd_get_pwr_dev_param > scsi: ufs: Introduce ufshcd_get_pwr_dev_param > > Vivek Gautam (1): > scsi/ufs: qcom: Remove ufs_qcom_phy_*() calls from host > > .../devicetree/bindings/phy/qcom-qmp-phy.txt | 4 +- > Documentation/devicetree/bindings/ufs/ufs-qcom.txt | 5 +- > .../devicetree/bindings/ufs/ufshcd-pltfrm.txt | 5 + > arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 17 +- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 169 ++++++++++--------- > debian.snapdragon/config/config.common.ubuntu | 10 +- > drivers/pci/dwc/pcie-qcom.c | 133 +++++---------- > drivers/pci/quirks.c | 4 +- > drivers/phy/phy-core.c | 18 +- > drivers/phy/qualcomm/phy-qcom-qmp.c | 42 +++-- > drivers/scsi/ufs/Kconfig | 1 - > drivers/scsi/ufs/ufs-qcom.c | 183 ++++++--------------- > drivers/scsi/ufs/ufshcd-pltfrm.c | 98 +++++++++++ > drivers/scsi/ufs/ufshcd-pltfrm.h | 21 +++ > drivers/scsi/ufs/ufshcd.c | 35 ++-- > drivers/scsi/ufs/ufshcd.h | 3 - > include/linux/pci_ids.h | 2 + > 17 files changed, 362 insertions(+), 388 deletions(-) > >
BugLink: http://bugs.launchpad.net/bugs/1853556 [Impact] Both Dragonboard 820c and Inforce 6640 (based on Snapdragon820 SoC) have a Universal Flash Drive on-board. The patches in this pull request fix the instabiliy issues and enable support for the UFS. [Fix] Fix the bring-up of the QMP PHY shared between the UFS and the PCIE ports. This patch set reverts patches picked-up from Linaro development tree and replaces them with necessary updates from upstream mainline and stable kernel trees. [Test Case] Test kernel based on Ubuntu-snapdragon-4.15.0-1068.75 was verified on both the DB820c and IFC6640. [Regression Risk] Low. Kernel configs enabling the UFS were disabled in previous versions. Also, pcie patches cause no regressions on DB410c. The following changes since commit d724458ea5038070ca377366f6593625150b0def: UBUNTU: Ubuntu-snapdragon-4.15.0-1068.75 (2019-11-14 09:58:11 -0800) are available in the Git repository at: git://git.launchpad.net/~shrirang-bagul/ubuntu/+source/linux/+git/bionic snapdragon-ufs for you to fetch changes up to 01d866a0e0438f30b570b8cb5063fceedf4e529b: UBUNTU: SAUCE: arm64: dts: msm8996: db820c: disable pcie1 bus (2019-11-22 20:32:50 +0800) ---------------------------------------------------------------- Arnd Bergmann (1): PCI: qcom: Include gpio/consumer.h Bjorn Andersson (5): arm64: dts: qcom: msm8996: Add ufs related nodes phy: qcom-qmp: Correct ready status, again PCI: qcom: Use clk bulk API for 2.4.0 controllers UBUNTU: SAUCE: phy: qcom-qmp: Increase PHY ready timeout UBUNTU: SAUCE: phy: qcom: qmp: Use power_on/off ops for PCIe Bjorn Helgaas (1): PCI: Add Qualcomm vendor ID Dan Carpenter (1): PCI: qcom: Fix a bitwise vs logical NOT typo Evan Green (6): scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom scsi: ufs: qcom: Expose the reset controller for PHY dt-bindings: ufs: Add #reset-cells for Qualcomm controllers dt-bindings: phy-qcom-qmp: Add UFS PHY reset dt-bindings: phy: qcom-ufs: Add resets property arm64: dts: msm8996: Add UFS PHY reset controller Kishon Vijay Abraham I (1): phy: core: Invoke pm_runtime_get_*/pm_runtime_put_* before invoking reset callback Marc Gonzalez (3): phy: qcom-qmp: Drop useless msm8998_pciephy_cfg setting phy: qcom-qmp: Raise qcom_qmp_phy_enable() polling delay PCI: qcom: Use default config space read function Paul Gortmaker (1): phy: make phy-core explicitly non-modular Shawn Guo (1): PCI: qcom: Drop unnecessary root_bus_nr setting Shrirang Bagul (10): Revert "UBUNTU: [Config] disable PHY_QCOM_UFS" Revert "UBUNTU: [Config] disable SCSI_UFSHCD" Revert "dts: arm64/msm8996: Fix power domain for ufs" Revert "arm64: dts: Add ufs dts nodes" Revert "scsi: ufs: qcom: Expose the reset controller for PHY" Revert "scsi: ufs: make UFS Tx lane1 clock optional for QCOM platforms" Revert "scsi: ufs: ufshcd_dump_regs to use memcpy_fromio" Revert "scsi: ufs: ufs-qcom: remove broken hci version quirk" Revert "scsi/ufs: qcom: Remove ufs_qcom_phy_*() calls from host" UBUNTU: SAUCE: arm64: dts: msm8996: db820c: disable pcie1 bus Srinivas Kandagatla (1): PCI: qcom: Use regulator bulk api for apq8064 supplies Stanley Chu (2): scsi: ufs-qcom: Re-factor ufshcd_get_pwr_dev_param scsi: ufs: Introduce ufshcd_get_pwr_dev_param Vivek Gautam (1): scsi/ufs: qcom: Remove ufs_qcom_phy_*() calls from host .../devicetree/bindings/phy/qcom-qmp-phy.txt | 4 +- Documentation/devicetree/bindings/ufs/ufs-qcom.txt | 5 +- .../devicetree/bindings/ufs/ufshcd-pltfrm.txt | 5 + arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 17 +- arch/arm64/boot/dts/qcom/msm8996.dtsi | 169 ++++++++++--------- debian.snapdragon/config/config.common.ubuntu | 10 +- drivers/pci/dwc/pcie-qcom.c | 133 +++++---------- drivers/pci/quirks.c | 4 +- drivers/phy/phy-core.c | 18 +- drivers/phy/qualcomm/phy-qcom-qmp.c | 42 +++-- drivers/scsi/ufs/Kconfig | 1 - drivers/scsi/ufs/ufs-qcom.c | 183 ++++++--------------- drivers/scsi/ufs/ufshcd-pltfrm.c | 98 +++++++++++ drivers/scsi/ufs/ufshcd-pltfrm.h | 21 +++ drivers/scsi/ufs/ufshcd.c | 35 ++-- drivers/scsi/ufs/ufshcd.h | 3 - include/linux/pci_ids.h | 2 + 17 files changed, 362 insertions(+), 388 deletions(-)