| Message ID | 20191130194240.10517-1-armbru@redhat.com |
|---|---|
| Headers | show |
| Series | Error handling fixes, may contain 4.2 material | expand |
On Sat, Nov 30, 2019 at 08:42:19PM +0100, Markus Armbruster wrote: > PATCH 2-4 fix crash bugs. Including them would be a no-brainer at > -rc0. But we're post -rc3, and even for crash bugs we require a > certain likelihood of users getting bitten. > > Jens, please assess impact of PATCH 2's crash bug. > > Kevin, please do the same for PATCH 3. > > Daniel, please do the same for PATCH 4. virtio things: Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Jason do you want to pick these? > The remainder is definitely not 4.2 material. > > Cc: "Daniel P. Berrangé" <berrange@redhat.com> > Cc: "Michael S. Tsirkin" <mst@redhat.com> > Cc: Christian Borntraeger <borntraeger@de.ibm.com> > Cc: Corey Minyard <cminyard@mvista.com> > Cc: Cornelia Huck <cohuck@redhat.com> > Cc: David Hildenbrand <david@redhat.com> > Cc: Halil Pasic <pasic@linux.ibm.com> > Cc: Igor Mammedov <imammedo@redhat.com> > Cc: Jens Freimann <jfreimann@redhat.com> > Cc: Kevin Wolf <kwolf@redhat.com> > Cc: Michael Roth <mdroth@linux.vnet.ibm.com> > Cc: Michael S. Tsirkin <mst@redhat.com> > Cc: Nishanth Aravamudan <naravamudan@digitalocean.com> > Cc: Stefan Hajnoczi <stefanha@redhat.com> > > Markus Armbruster (21): > net/virtio: Drop useless n->primary_dev not null checks > net/virtio: Fix failover error handling crash bugs > block/file-posix: Fix laio_init() error handling crash bug > crypto: Fix certificate file error handling crash bug > crypto: Fix typo in QCryptoTLSSession's <example> comment > io: Fix Error usage in a comment <example> > tests: Clean up initialization of Error *err variables > exec: Fix latent file_ram_alloc() error handling bug > hw/acpi: Fix latent legacy CPU plug error handling bug > hw/core: Fix latent fit_load_fdt() error handling bug > hw/ipmi: Fix latent realize() error handling bugs > qga: Fix latent guest-get-fsinfo error handling bug > memory-device: Fix latent memory pre-plug error handling bugs > s390x/event-facility: Fix latent realize() error handling bug > s390x/cpu_models: Fix latent feature property error handling bugs > s390/cpu_modules: Fix latent realize() error handling bugs > s390x: Fix latent query-cpu-model-FOO error handling bugs > s390x: Fix latent query-cpu-definitions error handling bug > error: Clean up unusual names of Error * variables > hw/intc/s390: Simplify error handling in kvm_s390_flic_realize() > tests-blockjob: Use error_free_or_abort() > > include/crypto/tlssession.h | 2 +- > include/io/task.h | 2 +- > block/file-posix.c | 2 +- > crypto/tlscredsx509.c | 2 +- > exec.c | 6 +- > hw/acpi/cpu_hotplug.c | 10 +-- > hw/core/loader-fit.c | 15 ++--- > hw/intc/s390_flic_kvm.c | 16 +++-- > hw/ipmi/isa_ipmi_bt.c | 7 ++- > hw/ipmi/isa_ipmi_kcs.c | 7 ++- > hw/ipmi/pci_ipmi_bt.c | 6 +- > hw/ipmi/pci_ipmi_kcs.c | 6 +- > hw/mem/memory-device.c | 6 +- > hw/net/virtio-net.c | 27 ++++---- > hw/ppc/spapr_pci.c | 16 ++--- > hw/ppc/spapr_pci_nvlink2.c | 10 +-- > hw/s390x/event-facility.c | 6 +- > qga/commands-posix.c | 6 +- > target/s390x/cpu_models.c | 98 +++++++++++++++++------------ > tests/test-blockjob.c | 15 +++-- > tests/test-qobject-output-visitor.c | 8 +-- > tests/test-string-output-visitor.c | 4 +- > 22 files changed, 154 insertions(+), 123 deletions(-) > > -- > 2.21.0
On Sat, Nov 30, 2019 at 08:42:19PM +0100, Markus Armbruster wrote: > PATCH 2-4 fix crash bugs. Including them would be a no-brainer at > -rc0. But we're post -rc3, and even for crash bugs we require a > certain likelihood of users getting bitten. > > Jens, please assess impact of PATCH 2's crash bug. > > Kevin, please do the same for PATCH 3. > > Daniel, please do the same for PATCH 4. The code has existed like this since 2.5.0, and its not a security issue, so I can't see any justification for putting it into 4.2 at the last minute. Regards, Daniel
On Sat, Nov 30, 2019 at 08:42:19PM +0100, Markus Armbruster wrote: >PATCH 2-4 fix crash bugs. Including them would be a no-brainer at >-rc0. But we're post -rc3, and even for crash bugs we require a >certain likelihood of users getting bitten. > >Jens, please assess impact of PATCH 2's crash bug. Guest can't use it to trigger a qemu crash because the hotplug_handler called after the pre-plug doesn't do anything with errp. qemu_opt_set_bool() is also unlikely to trigger the bug because both reasons for why it would set errp are not true in this path. I would prefer for this fix to go into 4.2 but if it is the only one and triggers a large amount of work then don't do it. regards Jens
"Michael S. Tsirkin" <mst@redhat.com> writes: > On Sat, Nov 30, 2019 at 08:42:19PM +0100, Markus Armbruster wrote: >> PATCH 2-4 fix crash bugs. Including them would be a no-brainer at >> -rc0. But we're post -rc3, and even for crash bugs we require a >> certain likelihood of users getting bitten. >> >> Jens, please assess impact of PATCH 2's crash bug. >> >> Kevin, please do the same for PATCH 3. >> >> Daniel, please do the same for PATCH 4. > > virtio things: > > Reviewed-by: Michael S. Tsirkin <mst@redhat.com> In my haste to get this into -rc4, I lost your r-bys. Sorry about that! > Jason do you want to pick these? Merged in commit 39032981fa851d25fb27527f25f046fed800e585.