| Message ID | 1574405757-76184-3-git-send-email-hanjie.lin@amlogic.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | arm64: meson: Add support for USB on Amlogic A1 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
Hi, On 22/11/2019 07:55, Hanjie Lin wrote: > The Amlogic A1 SoC Family embeds 1 USB Controllers: > - a DWC3 IP configured as Host for USB2 and USB3 > > A glue connects the controllers to the USB2 PHY of A1 SoC. > > Signed-off-by: Hanjie Lin <hanjie.lin@amlogic.com> > Signed-off-by: Yue Wang <yue.wang@amlogic.com> > --- > .../devicetree/bindings/usb/amlogic,dwc3.txt | 53 ++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/amlogic,dwc3.txt b/Documentation/devicetree/bindings/usb/amlogic,dwc3.txt > index 6ffb09b..63dc60b 100644 > --- a/Documentation/devicetree/bindings/usb/amlogic,dwc3.txt > +++ b/Documentation/devicetree/bindings/usb/amlogic,dwc3.txt > @@ -128,3 +128,56 @@ Example device nodes: > snps,quirk-frame-length-adjustment; > }; > }; > + > +Amlogic Meson A1 DWC3 USB SoC Controller Glue > + > +The Amlogic A1 embeds a DWC3 USB IP Core configured for USB2 in > +host-only mode. > + > +Required properties: > +- compatible: Should be "amlogic,meson-a1-usb-ctrl" > +- clocks: The clocks needed by the usb controller > +- clock-names: Should contain the name of the clocks: "usb_ctrl", "usb_bus", > + "xtal_usb_phy", "xtal_usb_ctrl" > +- resets: a handle for the shared "USB" reset line > +- reg: The base address and length of the registers > +- phys: handle to used PHYs on the system > + - a <0> phandle can be used if a PHY is not used > +- phy-names: names of the used PHYs on the system : > + - "usb2-phy0" for USB2 PHY if USBHOST port is used > + > +Required child nodes: > + > +A child node must exist to represent the core DWC3 IP block. The name of > +the node is not important. The content of the node is defined in dwc3.txt. > + > +PHY documentation is provided in the following places: > +- Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml > + > +Example device nodes: > + usb: usb@ffe09000 { > + status = "okay"; > + compatible = "amlogic,meson-a1-usb-ctrl"; > + reg = <0x0 0xffe09000 0x0 0xa0>; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + clocks = <&clkc_periphs CLKID_USB_CTRL>, > + <&clkc_periphs CLKID_USB_BUS>, > + <&clkc_periphs CLKID_XTAL_USB_PHY>, > + <&clkc_periphs CLKID_XTAL_USB_CTRL>; > + clock-names = "usb_ctrl", "usb_bus", "xtal_usb_phy", "xtal_usb_ctrl"; > + resets = <&reset RESET_USBCTRL>; > + phys = <&usb2_phy0>; > + phy-names = "usb2-phy0"; > + > + dwc3: usb@ff400000 { > + compatible = "snps,dwc3"; > + reg = <0x0 0xff400000 0x0 0x100000>; > + interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>; > + dr_mode = "host"; > + snps,dis_u2_susphy_quirk; > + snps,quirk-frame-length-adjustment = <0x20>; > + }; > + }; > This seems very similar to the g12a bindings, seems you could update the yaml g12a bindings with specific clocks and required for amlogic,meson-a1-usb-ctrl. Neil
On 2019/11/22 16:52, Neil Armstrong wrote: > Hi, > > > On 22/11/2019 07:55, Hanjie Lin wrote: >> The Amlogic A1 SoC Family embeds 1 USB Controllers: >> - a DWC3 IP configured as Host for USB2 and USB3 >> >> A glue connects the controllers to the USB2 PHY of A1 SoC. >> >> Signed-off-by: Hanjie Lin <hanjie.lin@amlogic.com> >> Signed-off-by: Yue Wang <yue.wang@amlogic.com> >> --- >> .../devicetree/bindings/usb/amlogic,dwc3.txt | 53 ++++++++++++++++++++++ >> 1 file changed, 53 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/amlogic,dwc3.txt b/Documentation/devicetree/bindings/usb/amlogic,dwc3.txt >> index 6ffb09b..63dc60b 100644 >> --- a/Documentation/devicetree/bindings/usb/amlogic,dwc3.txt >> +++ b/Documentation/devicetree/bindings/usb/amlogic,dwc3.txt >> @@ -128,3 +128,56 @@ Example device nodes: >> snps,quirk-frame-length-adjustment; >> }; >> }; >> + >> +Amlogic Meson A1 DWC3 USB SoC Controller Glue >> + >> +The Amlogic A1 embeds a DWC3 USB IP Core configured for USB2 in >> +host-only mode. >> + >> +Required properties: >> +- compatible: Should be "amlogic,meson-a1-usb-ctrl" >> +- clocks: The clocks needed by the usb controller >> +- clock-names: Should contain the name of the clocks: "usb_ctrl", "usb_bus", >> + "xtal_usb_phy", "xtal_usb_ctrl" >> +- resets: a handle for the shared "USB" reset line >> +- reg: The base address and length of the registers >> +- phys: handle to used PHYs on the system >> + - a <0> phandle can be used if a PHY is not used >> +- phy-names: names of the used PHYs on the system : >> + - "usb2-phy0" for USB2 PHY if USBHOST port is used >> + >> +Required child nodes: >> + >> +A child node must exist to represent the core DWC3 IP block. The name of >> +the node is not important. The content of the node is defined in dwc3.txt. >> + >> +PHY documentation is provided in the following places: >> +- Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml >> + >> +Example device nodes: >> + usb: usb@ffe09000 { >> + status = "okay"; >> + compatible = "amlogic,meson-a1-usb-ctrl"; >> + reg = <0x0 0xffe09000 0x0 0xa0>; >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges; >> + >> + clocks = <&clkc_periphs CLKID_USB_CTRL>, >> + <&clkc_periphs CLKID_USB_BUS>, >> + <&clkc_periphs CLKID_XTAL_USB_PHY>, >> + <&clkc_periphs CLKID_XTAL_USB_CTRL>; >> + clock-names = "usb_ctrl", "usb_bus", "xtal_usb_phy", "xtal_usb_ctrl"; >> + resets = <&reset RESET_USBCTRL>; >> + phys = <&usb2_phy0>; >> + phy-names = "usb2-phy0"; >> + >> + dwc3: usb@ff400000 { >> + compatible = "snps,dwc3"; >> + reg = <0x0 0xff400000 0x0 0x100000>; >> + interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>; >> + dr_mode = "host"; >> + snps,dis_u2_susphy_quirk; >> + snps,quirk-frame-length-adjustment = <0x20>; >> + }; >> + }; >> > > This seems very similar to the g12a bindings, seems you could update the yaml g12a bindings > with specific clocks and required for amlogic,meson-a1-usb-ctrl. > > Neil > > . > Hi Neil Thanks for the comment. 1, G12A have usb2-phy0/usb2-phy1/usb3-phy0 three phys and an interrupt to support host/peripheral/otg modes. A1 has one usb2-phy0 phy and only support host mode. 2, G12A glue/phy drivers are for G12A SoCs, there are some diffrences to A1. G12A glue driver have dr_mode and interrupts two attributes to support otg mode while A1 hasn't this requirement. G12A glue driver has a hard coding vbus regulator code to support otg mode while A1 hasn't this requirement. G12A glue driver has a hard coding support phys while A1 only supports host mode. enum { USB2_HOST_PHY = 0, USB2_OTG_PHY, USB3_HOST_PHY, PHY_COUNT, }; G12A glue driver only supports one clock while A1 needs four clocks. G12A and A1 phy drivers have different register configurations since hardware differences. 3, We have estimated these differences and we thought it's more clear and readable to have a dedicated glue/phy driver for A1 SoCs, so also dedicated dt-bindings.
On Mon, Nov 25, 2019 at 03:52:18PM +0800, Hanjie Lin wrote: > > > On 2019/11/22 16:52, Neil Armstrong wrote: > > Hi, > > > > > > On 22/11/2019 07:55, Hanjie Lin wrote: > >> The Amlogic A1 SoC Family embeds 1 USB Controllers: > >> - a DWC3 IP configured as Host for USB2 and USB3 > >> > >> A glue connects the controllers to the USB2 PHY of A1 SoC. > >> > >> Signed-off-by: Hanjie Lin <hanjie.lin@amlogic.com> > >> Signed-off-by: Yue Wang <yue.wang@amlogic.com> > >> --- > >> .../devicetree/bindings/usb/amlogic,dwc3.txt | 53 ++++++++++++++++++++++ > >> 1 file changed, 53 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/usb/amlogic,dwc3.txt b/Documentation/devicetree/bindings/usb/amlogic,dwc3.txt > >> index 6ffb09b..63dc60b 100644 > >> --- a/Documentation/devicetree/bindings/usb/amlogic,dwc3.txt > >> +++ b/Documentation/devicetree/bindings/usb/amlogic,dwc3.txt > >> @@ -128,3 +128,56 @@ Example device nodes: > >> snps,quirk-frame-length-adjustment; > >> }; > >> }; > >> + > >> +Amlogic Meson A1 DWC3 USB SoC Controller Glue > >> + > >> +The Amlogic A1 embeds a DWC3 USB IP Core configured for USB2 in > >> +host-only mode. > >> + > >> +Required properties: > >> +- compatible: Should be "amlogic,meson-a1-usb-ctrl" > >> +- clocks: The clocks needed by the usb controller > >> +- clock-names: Should contain the name of the clocks: "usb_ctrl", "usb_bus", > >> + "xtal_usb_phy", "xtal_usb_ctrl" > >> +- resets: a handle for the shared "USB" reset line > >> +- reg: The base address and length of the registers > >> +- phys: handle to used PHYs on the system > >> + - a <0> phandle can be used if a PHY is not used > >> +- phy-names: names of the used PHYs on the system : > >> + - "usb2-phy0" for USB2 PHY if USBHOST port is used > >> + > >> +Required child nodes: > >> + > >> +A child node must exist to represent the core DWC3 IP block. The name of > >> +the node is not important. The content of the node is defined in dwc3.txt. > >> + > >> +PHY documentation is provided in the following places: > >> +- Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml > >> + > >> +Example device nodes: > >> + usb: usb@ffe09000 { > >> + status = "okay"; > >> + compatible = "amlogic,meson-a1-usb-ctrl"; > >> + reg = <0x0 0xffe09000 0x0 0xa0>; > >> + #address-cells = <2>; > >> + #size-cells = <2>; > >> + ranges; > >> + > >> + clocks = <&clkc_periphs CLKID_USB_CTRL>, > >> + <&clkc_periphs CLKID_USB_BUS>, > >> + <&clkc_periphs CLKID_XTAL_USB_PHY>, > >> + <&clkc_periphs CLKID_XTAL_USB_CTRL>; > >> + clock-names = "usb_ctrl", "usb_bus", "xtal_usb_phy", "xtal_usb_ctrl"; > >> + resets = <&reset RESET_USBCTRL>; > >> + phys = <&usb2_phy0>; > >> + phy-names = "usb2-phy0"; > >> + > >> + dwc3: usb@ff400000 { > >> + compatible = "snps,dwc3"; > >> + reg = <0x0 0xff400000 0x0 0x100000>; > >> + interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>; > >> + dr_mode = "host"; > >> + snps,dis_u2_susphy_quirk; > >> + snps,quirk-frame-length-adjustment = <0x20>; > >> + }; > >> + }; > >> > > > > This seems very similar to the g12a bindings, seems you could update the yaml g12a bindings > > with specific clocks and required for amlogic,meson-a1-usb-ctrl. > > > > Neil > > > > . > > > > Hi Neil > Thanks for the comment. > > 1, G12A have usb2-phy0/usb2-phy1/usb3-phy0 three phys and an interrupt to support host/peripheral/otg modes. > A1 has one usb2-phy0 phy and only support host mode. > > 2, G12A glue/phy drivers are for G12A SoCs, there are some diffrences to A1. > G12A glue driver have dr_mode and interrupts two attributes to support otg mode while A1 hasn't this requirement. > G12A glue driver has a hard coding vbus regulator code to support otg mode while A1 hasn't this requirement. > G12A glue driver has a hard coding support phys while A1 only supports host mode. > enum { > USB2_HOST_PHY = 0, > USB2_OTG_PHY, > USB3_HOST_PHY, > PHY_COUNT, > }; > G12A glue driver only supports one clock while A1 needs four clocks. > G12A and A1 phy drivers have different register configurations since hardware differences. > > 3, We have estimated these differences and we thought it's more clear and readable to have a dedicated glue/phy > driver for A1 SoCs, so also dedicated dt-bindings. Fair enough, I guess. But you're not sharing anything from the amlogic,dwc3.txt binding, so make a new doc. And please make it a DT schema. Rob
diff --git a/Documentation/devicetree/bindings/usb/amlogic,dwc3.txt b/Documentation/devicetree/bindings/usb/amlogic,dwc3.txt index 6ffb09b..63dc60b 100644 --- a/Documentation/devicetree/bindings/usb/amlogic,dwc3.txt +++ b/Documentation/devicetree/bindings/usb/amlogic,dwc3.txt @@ -128,3 +128,56 @@ Example device nodes: snps,quirk-frame-length-adjustment; }; }; + +Amlogic Meson A1 DWC3 USB SoC Controller Glue + +The Amlogic A1 embeds a DWC3 USB IP Core configured for USB2 in +host-only mode. + +Required properties: +- compatible: Should be "amlogic,meson-a1-usb-ctrl" +- clocks: The clocks needed by the usb controller +- clock-names: Should contain the name of the clocks: "usb_ctrl", "usb_bus", + "xtal_usb_phy", "xtal_usb_ctrl" +- resets: a handle for the shared "USB" reset line +- reg: The base address and length of the registers +- phys: handle to used PHYs on the system + - a <0> phandle can be used if a PHY is not used +- phy-names: names of the used PHYs on the system : + - "usb2-phy0" for USB2 PHY if USBHOST port is used + +Required child nodes: + +A child node must exist to represent the core DWC3 IP block. The name of +the node is not important. The content of the node is defined in dwc3.txt. + +PHY documentation is provided in the following places: +- Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml + +Example device nodes: + usb: usb@ffe09000 { + status = "okay"; + compatible = "amlogic,meson-a1-usb-ctrl"; + reg = <0x0 0xffe09000 0x0 0xa0>; + #address-cells = <2>; + #size-cells = <2>; + ranges; + + clocks = <&clkc_periphs CLKID_USB_CTRL>, + <&clkc_periphs CLKID_USB_BUS>, + <&clkc_periphs CLKID_XTAL_USB_PHY>, + <&clkc_periphs CLKID_XTAL_USB_CTRL>; + clock-names = "usb_ctrl", "usb_bus", "xtal_usb_phy", "xtal_usb_ctrl"; + resets = <&reset RESET_USBCTRL>; + phys = <&usb2_phy0>; + phy-names = "usb2-phy0"; + + dwc3: usb@ff400000 { + compatible = "snps,dwc3"; + reg = <0x0 0xff400000 0x0 0x100000>; + interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>; + dr_mode = "host"; + snps,dis_u2_susphy_quirk; + snps,quirk-frame-length-adjustment = <0x20>; + }; + };