| Message ID | 20191119201433.13565-1-trini@konsulko.com |
|---|---|
| State | Accepted |
| Commit | 70f681398521c2ec2a75f612c04c506a0696c3b9 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot,PATCHv2] buildman: Fix problem with non-existent output directories | expand |
On Wed, Nov 20, 2019 at 4:14 AM Tom Rini <trini@konsulko.com> wrote: > > Now that we have buildman telling genboards.cfg to use an output > directory we need to ensure that it exists. > > Cc: Bin Meng <bmeng.cn@gmail.com> > Cc: Simon Glass <sjg@chromium.org> > Fixes: bc750bca1246 ("tools: buildman: Honor output directory when generating boards.cfg") > Signed-off-by: Tom Rini <trini@konsulko.com> > --- > Changes in v2: > - Use os.makedirs() per Bin > --- > tools/buildman/control.py | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On Tue, Nov 19, 2019 at 03:14:33PM -0500, Tom Rini wrote: > Now that we have buildman telling genboards.cfg to use an output > directory we need to ensure that it exists. > > Cc: Bin Meng <bmeng.cn@gmail.com> > Cc: Simon Glass <sjg@chromium.org> > Fixes: bc750bca1246 ("tools: buildman: Honor output directory when generating boards.cfg") > Signed-off-by: Tom Rini <trini@konsulko.com> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Applied to u-boot/master, thanks!
diff --git a/tools/buildman/control.py b/tools/buildman/control.py index 216012d00168..c55a65d0c30b 100644 --- a/tools/buildman/control.py +++ b/tools/buildman/control.py @@ -201,6 +201,8 @@ def DoBuildman(options, args, toolchains=None, make_func=None, boards=None, # Work out what subset of the boards we are building if not boards: + if not os.path.exists(options.output_dir): + os.makedirs(options.output_dir) board_file = os.path.join(options.output_dir, 'boards.cfg') genboardscfg = os.path.join(options.git, 'tools/genboardscfg.py') status = subprocess.call([genboardscfg, '-o', board_file])
Now that we have buildman telling genboards.cfg to use an output directory we need to ensure that it exists. Cc: Bin Meng <bmeng.cn@gmail.com> Cc: Simon Glass <sjg@chromium.org> Fixes: bc750bca1246 ("tools: buildman: Honor output directory when generating boards.cfg") Signed-off-by: Tom Rini <trini@konsulko.com> --- Changes in v2: - Use os.makedirs() per Bin --- tools/buildman/control.py | 2 ++ 1 file changed, 2 insertions(+)