Message ID | 20191113071045.GA22110@localhost.localdomain |
---|---|
State | New |
Headers | show |
Series | [v2,1/2] pinctrl: rza1: remove unnecessary static inline function | expand |
On Wed, Nov 13, 2019 at 8:10 AM Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> wrote: > Having static inline oneliner does not benefit too mucg when it is > only called from another oneliner function. Remove some of the > 'onion'. This simplifies also the coming usage of the gpiolib > defines. We can do conversion from chip bits to gpiolib direction > defines as last step in the get_direction callback. Drivers can > use chip specific values in driver internal functions and do > conversion only once. > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > > Changes since v1: Subject fixed as pointed out by Geert. Patch applied. Yours, Linus Walleij
diff --git a/drivers/pinctrl/pinctrl-rza1.c b/drivers/pinctrl/pinctrl-rza1.c index 017fc6b3e27e..215db220d795 100644 --- a/drivers/pinctrl/pinctrl-rza1.c +++ b/drivers/pinctrl/pinctrl-rza1.c @@ -617,12 +617,6 @@ static void rza1_pin_reset(struct rza1_port *port, unsigned int pin) spin_unlock_irqrestore(&port->lock, irqflags); } -static inline int rza1_pin_get_direction(struct rza1_port *port, - unsigned int pin) -{ - return !!rza1_get_bit(port, RZA1_PM_REG, pin); -} - /** * rza1_pin_set_direction() - set I/O direction on a pin in port mode * @@ -783,7 +777,7 @@ static int rza1_gpio_get_direction(struct gpio_chip *chip, unsigned int gpio) { struct rza1_port *port = gpiochip_get_data(chip); - return rza1_pin_get_direction(port, gpio); + return !!rza1_get_bit(port, RZA1_PM_REG, gpio); } static int rza1_gpio_direction_input(struct gpio_chip *chip,