| Message ID | 20191107105529.22825-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v1] i2c: i801: Correct Intel Jasper Lake PCH naming | expand |
On 11/7/19 12:55 PM, Andy Shevchenko wrote: > There is no suffix applied to Intel Jasper Lake PCH. Remove it from > the comments and definitions. > > Fixes: e0c61c04791a ("i2c: i801: Add support for Intel Jasper Lake") > Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/i2c/busses/i2c-i801.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index df02040d36d5..2de184bbd21f 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -67,7 +67,7 @@ > * Comet Lake-H (PCH) 0x06a3 32 hard yes yes yes > * Elkhart Lake (PCH) 0x4b23 32 hard yes yes yes > * Tiger Lake-LP (PCH) 0xa0a3 32 hard yes yes yes > - * Jasper Lake-N (PCH) 0x4da3 32 hard yes yes yes > + * Jasper Lake (PCH) 0x4da3 32 hard yes yes yes > * Let's crosscheck this first. The spec version I have explicitly says Jasper Lake -N and I wanted to carry it forward in case there is another version in the future.
Hi Andy On 11/7/19 1:29 PM, Jarkko Nikula wrote: >> diff --git a/drivers/i2c/busses/i2c-i801.c >> b/drivers/i2c/busses/i2c-i801.c >> index df02040d36d5..2de184bbd21f 100644 >> --- a/drivers/i2c/busses/i2c-i801.c >> +++ b/drivers/i2c/busses/i2c-i801.c >> @@ -67,7 +67,7 @@ >> * Comet Lake-H (PCH) 0x06a3 32 hard yes yes yes >> * Elkhart Lake (PCH) 0x4b23 32 hard yes yes yes >> * Tiger Lake-LP (PCH) 0xa0a3 32 hard yes yes yes >> - * Jasper Lake-N (PCH) 0x4da3 32 hard yes yes yes >> + * Jasper Lake (PCH) 0x4da3 32 hard yes yes yes >> * > Let's crosscheck this first. The spec version I have explicitly says > Jasper Lake -N and I wanted to carry it forward in case there is another > version in the future. > Would you like to send an update to this? I can do it also. As we were told it's Jasper Lake *SoC* so also drivers/i2c/busses/Kconfig and Documentation/i2c/busses/i2c-i801.rst should be updated accordingly. Jarkko
On Wed, Nov 20, 2019 at 04:09:41PM +0200, Jarkko Nikula wrote: > Hi Andy > > On 11/7/19 1:29 PM, Jarkko Nikula wrote: > > > diff --git a/drivers/i2c/busses/i2c-i801.c > > > b/drivers/i2c/busses/i2c-i801.c > > > index df02040d36d5..2de184bbd21f 100644 > > > --- a/drivers/i2c/busses/i2c-i801.c > > > +++ b/drivers/i2c/busses/i2c-i801.c > > > @@ -67,7 +67,7 @@ > > > * Comet Lake-H (PCH) 0x06a3 32 hard yes yes yes > > > * Elkhart Lake (PCH) 0x4b23 32 hard yes yes yes > > > * Tiger Lake-LP (PCH) 0xa0a3 32 hard yes yes yes > > > - * Jasper Lake-N (PCH) 0x4da3 32 hard yes yes yes > > > + * Jasper Lake (PCH) 0x4da3 32 hard yes yes yes > > > * > > Let's crosscheck this first. The spec version I have explicitly says > > Jasper Lake -N and I wanted to carry it forward in case there is another > > version in the future. > > > Would you like to send an update to this? I can do it also. > > As we were told it's Jasper Lake *SoC* so also drivers/i2c/busses/Kconfig > and Documentation/i2c/busses/i2c-i801.rst should be updated accordingly. Ah, thanks. I'm on it!
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c index df02040d36d5..2de184bbd21f 100644 --- a/drivers/i2c/busses/i2c-i801.c +++ b/drivers/i2c/busses/i2c-i801.c @@ -67,7 +67,7 @@ * Comet Lake-H (PCH) 0x06a3 32 hard yes yes yes * Elkhart Lake (PCH) 0x4b23 32 hard yes yes yes * Tiger Lake-LP (PCH) 0xa0a3 32 hard yes yes yes - * Jasper Lake-N (PCH) 0x4da3 32 hard yes yes yes + * Jasper Lake (PCH) 0x4da3 32 hard yes yes yes * * Features supported by this driver: * Software PEC no @@ -226,7 +226,7 @@ #define PCI_DEVICE_ID_INTEL_ICELAKE_LP_SMBUS 0x34a3 #define PCI_DEVICE_ID_INTEL_5_3400_SERIES_SMBUS 0x3b30 #define PCI_DEVICE_ID_INTEL_ELKHART_LAKE_SMBUS 0x4b23 -#define PCI_DEVICE_ID_INTEL_JASPER_LAKE_N_SMBUS 0x4da3 +#define PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS 0x4da3 #define PCI_DEVICE_ID_INTEL_BROXTON_SMBUS 0x5ad4 #define PCI_DEVICE_ID_INTEL_LYNXPOINT_SMBUS 0x8c22 #define PCI_DEVICE_ID_INTEL_WILDCATPOINT_SMBUS 0x8ca2 @@ -1076,7 +1076,7 @@ static const struct pci_device_id i801_ids[] = { { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_COMETLAKE_H_SMBUS) }, { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ELKHART_LAKE_SMBUS) }, { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TIGERLAKE_LP_SMBUS) }, - { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_JASPER_LAKE_N_SMBUS) }, + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS) }, { 0, } }; @@ -1759,7 +1759,7 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id) case PCI_DEVICE_ID_INTEL_COMETLAKE_H_SMBUS: case PCI_DEVICE_ID_INTEL_ELKHART_LAKE_SMBUS: case PCI_DEVICE_ID_INTEL_TIGERLAKE_LP_SMBUS: - case PCI_DEVICE_ID_INTEL_JASPER_LAKE_N_SMBUS: + case PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS: priv->features |= FEATURE_BLOCK_PROC; priv->features |= FEATURE_I2C_BLOCK_READ; priv->features |= FEATURE_IRQ;
There is no suffix applied to Intel Jasper Lake PCH. Remove it from the comments and definitions. Fixes: e0c61c04791a ("i2c: i801: Add support for Intel Jasper Lake") Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/i2c/busses/i2c-i801.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)