| Message ID | 01b4b3af-6b3b-281e-31b6-8d852e76bc52@suse.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot,GIT,PULL] Raspberry Pi updates for v2020.01 | expand |
On Tue, Nov 19, 2019 at 05:02:34PM +0100, Matthias Brugger wrote: > Hi Tom, > > Please have a look at the below patches. > Travis-ci can be found here: > https://travis-ci.org/mbgg/u-boot/builds/614078145 > > Apart from this patches, I planning to send another pull request once the single > binary series is ready to be merged. But for now, we should take this patches as > it fixes some FAT write errors and the boot banner issue for RPi3 you detected. > > Regards, > Matthias > NAK, this seems to break FAT in some cases: https://gitlab.denx.de/u-boot/u-boot/-/jobs/31682 https://gitlab.denx.de/u-boot/u-boot/-/jobs/31683 (and similar in Azure and Travis).
Hi Tom, On 20/11/2019 02:57, Tom Rini wrote: > On Tue, Nov 19, 2019 at 05:02:34PM +0100, Matthias Brugger wrote: > >> Hi Tom, >> >> Please have a look at the below patches. >> Travis-ci can be found here: >> https://travis-ci.org/mbgg/u-boot/builds/614078145 >> >> Apart from this patches, I planning to send another pull request once the single >> binary series is ready to be merged. But for now, we should take this patches as >> it fixes some FAT write errors and the boot banner issue for RPi3 you detected. >> >> Regards, >> Matthias >> > > NAK, this seems to break FAT in some cases: > https://gitlab.denx.de/u-boot/u-boot/-/jobs/31682 > https://gitlab.denx.de/u-boot/u-boot/-/jobs/31683 > (and similar in Azure and Travis). > It seems that it does not break in travis, but it also seems that the CI diverged between travis and gitlab: https://travis-ci.org/mbgg/u-boot/jobs/614078209 https://travis-ci.org/mbgg/u-boot/jobs/614078210 @Tom are you aware of that? @Marek can you have a look into the FAT errors please? Regards, Matthias
On Wed, Nov 20, 2019 at 10:10:00AM +0100, Matthias Brugger wrote: > Hi Tom, > > On 20/11/2019 02:57, Tom Rini wrote: > > On Tue, Nov 19, 2019 at 05:02:34PM +0100, Matthias Brugger wrote: > > > >> Hi Tom, > >> > >> Please have a look at the below patches. > >> Travis-ci can be found here: > >> https://travis-ci.org/mbgg/u-boot/builds/614078145 > >> > >> Apart from this patches, I planning to send another pull request once the single > >> binary series is ready to be merged. But for now, we should take this patches as > >> it fixes some FAT write errors and the boot banner issue for RPi3 you detected. > >> > >> Regards, > >> Matthias > >> > > > > NAK, this seems to break FAT in some cases: > > https://gitlab.denx.de/u-boot/u-boot/-/jobs/31682 > > https://gitlab.denx.de/u-boot/u-boot/-/jobs/31683 > > (and similar in Azure and Travis). > > > > It seems that it does not break in travis, but it also seems that the CI > diverged between travis and gitlab: > https://travis-ci.org/mbgg/u-boot/jobs/614078209 > https://travis-ci.org/mbgg/u-boot/jobs/614078210 > > @Tom are you aware of that? Ah yes, oops. Travis does not, and I cannot figure out why, run the filesystem tests. Azure and GitLab both do. Setup is the same in both cases, I thought. Generally one should be able to run them locally as well.
Hi Matthias, On 20.11.2019 10:10, Matthias Brugger wrote: > Hi Tom, > > On 20/11/2019 02:57, Tom Rini wrote: >> On Tue, Nov 19, 2019 at 05:02:34PM +0100, Matthias Brugger wrote: >> >>> Hi Tom, >>> >>> Please have a look at the below patches. >>> Travis-ci can be found here: >>> https://travis-ci.org/mbgg/u-boot/builds/614078145 >>> >>> Apart from this patches, I planning to send another pull request once the single >>> binary series is ready to be merged. But for now, we should take this patches as >>> it fixes some FAT write errors and the boot banner issue for RPi3 you detected. >>> >>> Regards, >>> Matthias >>> >> NAK, this seems to break FAT in some cases: >> https://protect2.fireeye.com/url?k=2537010b-78fbcdae-25368a44-0cc47a30d446-1c9023d2fe8030d3&u=https://gitlab.denx.de/u-boot/u-boot/-/jobs/31682 >> https://protect2.fireeye.com/url?k=320832ee-6fc4fe4b-3209b9a1-0cc47a30d446-2f8fe5692eb397d4&u=https://gitlab.denx.de/u-boot/u-boot/-/jobs/31683 >> (and similar in Azure and Travis). >> > It seems that it does not break in travis, but it also seems that the CI > diverged between travis and gitlab: > https://travis-ci.org/mbgg/u-boot/jobs/614078209 > https://travis-ci.org/mbgg/u-boot/jobs/614078210 > > @Tom are you aware of that? > > @Marek can you have a look into the FAT errors please? Yes, I will take care of them. It looks that my fixes revealed bugs in other parts of fat code... Best regards
On 22/11/2019 14:40, Marek Szyprowski wrote: > Hi Matthias, > > On 20.11.2019 10:10, Matthias Brugger wrote: >> Hi Tom, >> >> On 20/11/2019 02:57, Tom Rini wrote: >>> On Tue, Nov 19, 2019 at 05:02:34PM +0100, Matthias Brugger wrote: >>> >>>> Hi Tom, >>>> >>>> Please have a look at the below patches. >>>> Travis-ci can be found here: >>>> https://travis-ci.org/mbgg/u-boot/builds/614078145 >>>> >>>> Apart from this patches, I planning to send another pull request once the single >>>> binary series is ready to be merged. But for now, we should take this patches as >>>> it fixes some FAT write errors and the boot banner issue for RPi3 you detected. >>>> >>>> Regards, >>>> Matthias >>>> >>> NAK, this seems to break FAT in some cases: >>> https://protect2.fireeye.com/url?k=2537010b-78fbcdae-25368a44-0cc47a30d446-1c9023d2fe8030d3&u=https://gitlab.denx.de/u-boot/u-boot/-/jobs/31682 >>> https://protect2.fireeye.com/url?k=320832ee-6fc4fe4b-3209b9a1-0cc47a30d446-2f8fe5692eb397d4&u=https://gitlab.denx.de/u-boot/u-boot/-/jobs/31683 >>> (and similar in Azure and Travis). >>> >> It seems that it does not break in travis, but it also seems that the CI >> diverged between travis and gitlab: >> https://travis-ci.org/mbgg/u-boot/jobs/614078209 >> https://travis-ci.org/mbgg/u-boot/jobs/614078210 >> >> @Tom are you aware of that? >> >> @Marek can you have a look into the FAT errors please? > > Yes, I will take care of them. It looks that my fixes revealed bugs in > other parts of fat code... > Thanks. I'll postpone your DFU series for now, as they are rahter useless without a working FAT partition. I can merge it when all the FAT related problems are fixed. Sounds good? Regards, Matthias
Hi Matthias, On 24.11.2019 10:39, Matthias Brugger wrote: > On 22/11/2019 14:40, Marek Szyprowski wrote: >> On 20.11.2019 10:10, Matthias Brugger wrote: >>> On 20/11/2019 02:57, Tom Rini wrote: >>>> On Tue, Nov 19, 2019 at 05:02:34PM +0100, Matthias Brugger wrote: >>>>> Please have a look at the below patches. >>>>> Travis-ci can be found here: >>>>> https://travis-ci.org/mbgg/u-boot/builds/614078145 >>>>> >>>>> Apart from this patches, I planning to send another pull request once the single >>>>> binary series is ready to be merged. But for now, we should take this patches as >>>>> it fixes some FAT write errors and the boot banner issue for RPi3 you detected. >>>>> >>>>> Regards, >>>>> Matthias >>>>> >>>> NAK, this seems to break FAT in some cases: >>>> https://protect2.fireeye.com/url?k=2537010b-78fbcdae-25368a44-0cc47a30d446-1c9023d2fe8030d3&u=https://gitlab.denx.de/u-boot/u-boot/-/jobs/31682 >>>> https://protect2.fireeye.com/url?k=320832ee-6fc4fe4b-3209b9a1-0cc47a30d446-2f8fe5692eb397d4&u=https://gitlab.denx.de/u-boot/u-boot/-/jobs/31683 >>>> (and similar in Azure and Travis). >>>> >>> It seems that it does not break in travis, but it also seems that the CI >>> diverged between travis and gitlab: >>> https://travis-ci.org/mbgg/u-boot/jobs/614078209 >>> https://travis-ci.org/mbgg/u-boot/jobs/614078210 >>> >>> @Tom are you aware of that? >>> >>> @Marek can you have a look into the FAT errors please? >> Yes, I will take care of them. It looks that my fixes revealed bugs in >> other parts of fat code... >> > Thanks. I'll postpone your DFU series for now, as they are rahter useless > without a working FAT partition. I can merge it when all the FAT related > problems are fixed. Sounds good? I've managed to identify the FAT/sandbox issue and fixed it. I've sent a v3 of complete RPi4 DFU patchset a few minutes ago: https://patchwork.ozlabs.org/cover/1200793/ Best regards
Hi Marek, On 26/11/2019 09:25, Marek Szyprowski wrote: > Hi Matthias, > > On 24.11.2019 10:39, Matthias Brugger wrote: >> On 22/11/2019 14:40, Marek Szyprowski wrote: >>> On 20.11.2019 10:10, Matthias Brugger wrote: >>>> On 20/11/2019 02:57, Tom Rini wrote: >>>>> On Tue, Nov 19, 2019 at 05:02:34PM +0100, Matthias Brugger wrote: >>>>>> Please have a look at the below patches. >>>>>> Travis-ci can be found here: >>>>>> https://travis-ci.org/mbgg/u-boot/builds/614078145 >>>>>> >>>>>> Apart from this patches, I planning to send another pull request once the single >>>>>> binary series is ready to be merged. But for now, we should take this patches as >>>>>> it fixes some FAT write errors and the boot banner issue for RPi3 you detected. >>>>>> >>>>>> Regards, >>>>>> Matthias >>>>>> >>>>> NAK, this seems to break FAT in some cases: >>>>> https://protect2.fireeye.com/url?k=2537010b-78fbcdae-25368a44-0cc47a30d446-1c9023d2fe8030d3&u=https://gitlab.denx.de/u-boot/u-boot/-/jobs/31682 >>>>> https://protect2.fireeye.com/url?k=320832ee-6fc4fe4b-3209b9a1-0cc47a30d446-2f8fe5692eb397d4&u=https://gitlab.denx.de/u-boot/u-boot/-/jobs/31683 >>>>> (and similar in Azure and Travis). >>>>> >>>> It seems that it does not break in travis, but it also seems that the CI >>>> diverged between travis and gitlab: >>>> https://travis-ci.org/mbgg/u-boot/jobs/614078209 >>>> https://travis-ci.org/mbgg/u-boot/jobs/614078210 >>>> >>>> @Tom are you aware of that? >>>> >>>> @Marek can you have a look into the FAT errors please? >>> Yes, I will take care of them. It looks that my fixes revealed bugs in >>> other parts of fat code... >>> >> Thanks. I'll postpone your DFU series for now, as they are rahter useless >> without a working FAT partition. I can merge it when all the FAT related >> problems are fixed. Sounds good? > > I've managed to identify the FAT/sandbox issue and fixed it. I've sent a > v3 of complete RPi4 DFU patchset a few minutes ago: > https://patchwork.ozlabs.org/cover/1200793/ > Thanks for the quick fix. I'll wait to see if someone with more knowledge can review the patch and then will send the whole series for inclusion. Regards, Matthias
Hi Tom, Please have a look at the below patches. Travis-ci can be found here: https://travis-ci.org/mbgg/u-boot/builds/614078145 Apart from this patches, I planning to send another pull request once the single binary series is ready to be merged. But for now, we should take this patches as it fixes some FAT write errors and the boot banner issue for RPi3 you detected. Regards, Matthias --- The following changes since commit d4a31e8ee5592072d8d5208b3e950cba2d89b6bd: Prepare v2020.01-rc3 (2019-11-18 21:31:49 -0500) are available in the Git repository at: https://github.com/mbgg/u-boot.git tags/rpi-next-2020.01 for you to fetch changes up to cf3a4dc5d12d2b635370795ec15996d3216c7ea3: drivers: bcm283x: Set pre-location flag for OF_BOARD (2019-11-19 16:29:15 +0100) ---------------------------------------------------------------- - enable DFU for RPi4 - fix fat write - add pinctrl upstream compatible for RPi4 - fix boot banner for RPi3 and RPi4 ---------------------------------------------------------------- Marek Szyprowski (6): fat: write: fix broken write to fragmented files fat: write: fix broken write at non-zero file offset dfu: mmc: rearrange the code dfu: mmc: remove file size limit for io operations usb: dwc2_udc_otg: add bcm2835 SoC (Raspberry Pi4) support config: enable DFU over USB on Raspberry Pi4 boards Matthias Brugger (4): pinctrl: bcm283x: Add compatible for RPi4 fdt: fix bcm283x dm-pre-reloc definitions arm: dts: bcm283x: Rename U-Boot file drivers: bcm283x: Set pre-location flag for OF_BOARD .../{bcm283x-uboot.dtsi => bcm283x-u-boot.dtsi} | 4 - configs/rpi_4_32b_defconfig | 11 +++ configs/rpi_4_defconfig | 11 +++ drivers/dfu/dfu_mmc.c | 93 +++++++++++++--------- drivers/pinctrl/broadcom/pinctrl-bcm283x.c | 3 +- drivers/serial/serial_bcm283x_mu.c | 2 +- drivers/serial/serial_bcm283x_pl011.c | 2 +- drivers/usb/gadget/dwc2_udc_otg.c | 2 + drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c | 12 +-- fs/fat/fat_write.c | 18 ++--- include/configs/rpi.h | 20 +++++ 11 files changed, 120 insertions(+), 58 deletions(-) rename arch/arm/dts/{bcm283x-uboot.dtsi => bcm283x-u-boot.dtsi} (90%)