Message ID | 1306222943.2785.55.camel@localhost |
---|---|
State | New, archived |
Headers | show |
On Tue, 2011-05-24 at 10:42 +0300, Artem Bityutskiy wrote: > From: Randy Dunlap <randy.dunlap@oracle.com> > Subject: [PATCH] mtd: fix physmap.h warnings > > Fix build warnings in physmap.h: > > include/linux/mtd/physmap.h:25: warning: 'struct platform_device' declared inside parameter list > include/linux/mtd/physmap.h:25: warning: its scope is only this definition or declaration, which is probably not what you want > include/linux/mtd/physmap.h:26: warning: 'struct platform_device' declared inside parameter list > include/linux/mtd/physmap.h:27: warning: 'struct platform_device' declared inside parameter list > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> David, it looks like Russel did not merge this patch and people complain. Could you please merge it?
On Wed, Jun 01, 2011 at 10:45:54AM +0300, Artem Bityutskiy wrote: > On Tue, 2011-05-24 at 10:42 +0300, Artem Bityutskiy wrote: > > From: Randy Dunlap <randy.dunlap@oracle.com> > > Subject: [PATCH] mtd: fix physmap.h warnings > > > > Fix build warnings in physmap.h: > > > > include/linux/mtd/physmap.h:25: warning: 'struct platform_device' declared inside parameter list > > include/linux/mtd/physmap.h:25: warning: its scope is only this definition or declaration, which is probably not what you want > > include/linux/mtd/physmap.h:26: warning: 'struct platform_device' declared inside parameter list > > include/linux/mtd/physmap.h:27: warning: 'struct platform_device' declared inside parameter list > > > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > > Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> > > David, it looks like Russel did not merge this patch and people ^^ > complain. Could you please merge it? Bah, it got lost in the depths of my mailboxes and forgotten...
diff --git a/include/linux/mtd/physmap.h b/include/linux/mtd/physmap.h index 49b9590..697cc98 100644 --- a/include/linux/mtd/physmap.h +++ b/include/linux/mtd/physmap.h @@ -19,6 +19,7 @@ #include <linux/mtd/partitions.h> struct map_info; +struct platform_device; struct physmap_flash_data { unsigned int width;