Message ID | 20191115141444.24155-1-vsementsov@virtuozzo.com |
---|---|
Headers | show |
Series | backup performance: block_status + async | expand |
Patchew URL: https://patchew.org/QEMU/20191115141444.24155-1-vsementsov@virtuozzo.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [RFC 00/24] backup performance: block_status + async Type: series Message-id: 20191115141444.24155-1-vsementsov@virtuozzo.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' b3ea574 python: benchmark new backup architecture 899a413 python: add qemu/bench_block_job.py 46552d2 python: add simplebench.py e20f1fb backup: move to block-copy 9b0e5f0 job: call job_enter from job_user_pause fcc0a72 blockjob: add set_speed to BlockJobDriver 62d85a7 block/block-copy: add block_copy_cancel 19066cf block/block-copy: add ratelimit to block-copy db53990 block/block-copy: add max_chunk and max_workers paramters 97fe936 block/block-copy: implement block_copy_async feb18da block/block-copy: More explicit call_state 5f9fd94 block/block-copy: use aio-task-pool API 94a4f4f block/block-copy: move block_copy_task_create down 74bc1b1 block/block-copy: move task size initial calculation to _task_create aaf398c block/block-copy: add state pointer to BlockCopyTask 5c4dbd2 block/block-copy: alloc task on each iteration 44e698f block/block-copy: rename in-flight requests to tasks 6d78584 block/block-copy: hide structure definitions 4b541b5 block/block-copy: reduce intersecting request lock 33d4eb1 block/block-copy: rename start to offset in interfaces d74cc59 block/block-copy: refactor interfaces to use bytes instead of end bc4e836 block/block-copy: factor out block_copy_find_inflight_req f22200c block/block-copy: use block_status 5c23778 block/block-copy: specialcase first copy_range request === OUTPUT BEGIN === 1/24 Checking commit 5c23778bb3f4 (block/block-copy: specialcase first copy_range request) 2/24 Checking commit f22200c5b50a (block/block-copy: use block_status) 3/24 Checking commit bc4e83640682 (block/block-copy: factor out block_copy_find_inflight_req) 4/24 Checking commit d74cc59b9921 (block/block-copy: refactor interfaces to use bytes instead of end) 5/24 Checking commit 33d4eb118fd6 (block/block-copy: rename start to offset in interfaces) 6/24 Checking commit 4b541b586cbf (block/block-copy: reduce intersecting request lock) 7/24 Checking commit 6d785845c236 (block/block-copy: hide structure definitions) 8/24 Checking commit 44e698fcabd9 (block/block-copy: rename in-flight requests to tasks) 9/24 Checking commit 5c4dbd281da7 (block/block-copy: alloc task on each iteration) 10/24 Checking commit aaf398c95343 (block/block-copy: add state pointer to BlockCopyTask) 11/24 Checking commit 74bc1b1a2719 (block/block-copy: move task size initial calculation to _task_create) 12/24 Checking commit 94a4f4fbaf78 (block/block-copy: move block_copy_task_create down) 13/24 Checking commit 5f9fd943c782 (block/block-copy: use aio-task-pool API) 14/24 Checking commit feb18da8d233 (block/block-copy: More explicit call_state) 15/24 Checking commit 97fe9366ea2b (block/block-copy: implement block_copy_async) 16/24 Checking commit db5399013d42 (block/block-copy: add max_chunk and max_workers paramters) 17/24 Checking commit 19066cfd3aeb (block/block-copy: add ratelimit to block-copy) 18/24 Checking commit 62d85a7434d8 (block/block-copy: add block_copy_cancel) 19/24 Checking commit fcc0a7228683 (blockjob: add set_speed to BlockJobDriver) 20/24 Checking commit 9b0e5f043396 (job: call job_enter from job_user_pause) 21/24 Checking commit e20f1fb84dd4 (backup: move to block-copy) 22/24 Checking commit 46552d28b459 (python: add simplebench.py) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100644 total: 0 errors, 1 warnings, 122 lines checked Patch 22/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/24 Checking commit 899a41312a82 (python: add qemu/bench_block_job.py) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100755 total: 0 errors, 1 warnings, 114 lines checked Patch 23/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 24/24 Checking commit b3ea574749ec (python: benchmark new backup architecture) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100755 ERROR: line over 90 characters #66: FILE: python/bench-example.py:34: + 'qemu_binary': '/work/src/qemu/up-block-copy-block-status--before/x86_64-softmmu/qemu-system-x86_64' ERROR: line over 90 characters #71: FILE: python/bench-example.py:39: + 'qemu_binary': '/work/src/qemu/up-block-copy-block-status--before--no-copy-range/x86_64-softmmu/qemu-system-x86_64' ERROR: line over 90 characters #76: FILE: python/bench-example.py:44: + 'qemu_binary': '/work/src/qemu/up-block-copy-block-status/x86_64-softmmu/qemu-system-x86_64' ERROR: line over 90 characters #81: FILE: python/bench-example.py:49: + 'qemu_binary': '/work/src/qemu/up-block-copy-block-status--no-copy_range/x86_64-softmmu/qemu-system-x86_64' ERROR: line over 90 characters #86: FILE: python/bench-example.py:54: + 'qemu_binary': '/work/src/qemu/up-block-copy-block-status/x86_64-softmmu/qemu-system-x86_64' ERROR: line over 90 characters #110: FILE: python/bench-example.py:78: + 'qemu_binary': '/work/src/qemu/up-block-copy-block-status--before/x86_64-softmmu/qemu-system-x86_64' ERROR: line over 90 characters #115: FILE: python/bench-example.py:83: + 'qemu_binary': '/work/src/qemu/up-block-copy-block-status/x86_64-softmmu/qemu-system-x86_64' ERROR: line over 90 characters #120: FILE: python/bench-example.py:88: + 'qemu_binary': '/work/src/qemu/up-block-copy-block-status/x86_64-softmmu/qemu-system-x86_64' total: 8 errors, 1 warnings, 93 lines checked Patch 24/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20191115141444.24155-1-vsementsov@virtuozzo.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com