diff mbox series

Relax lto-dump.o dependency.

Message ID 09d02170-b6bc-9fa6-c674-34b610d455c9@suse.cz
State New
Headers show
Series Relax lto-dump.o dependency. | expand

Commit Message

Martin Liška Nov. 11, 2019, 2:06 p.m. UTC 
Hi.

Current lto-dump.o relies on some FE generated files as
pre-requirement. That hover delays LTO linking of the lto-dump
and so that I adjusted the dependency to LTO_OBJS which will
work as well.

Patch can bootstrap on x86_64-linux-gnu and survives regression tests.

Ready to be installed?
Thanks,
Martin

gcc/lto/ChangeLog:

2019-11-11  Martin Liska  <mliska@suse.cz>

	* Make-lang.in: Relax dependency of lto-dump.o to
	LTO_OBJS which will allow faster linking (mainly with LTO).
---
  gcc/lto/Make-lang.in | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Biener Nov. 11, 2019, 2:22 p.m. UTC | #1 
On Mon, Nov 11, 2019 at 3:06 PM Martin Liška <mliska@suse.cz> wrote:
>
> Hi.
>
> Current lto-dump.o relies on some FE generated files as
> pre-requirement. That hover delays LTO linking of the lto-dump
> and so that I adjusted the dependency to LTO_OBJS which will
> work as well.
>
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>
> Ready to be installed?

OK.

> Thanks,
> Martin
>
> gcc/lto/ChangeLog:
>
> 2019-11-11  Martin Liska  <mliska@suse.cz>
>
>         * Make-lang.in: Relax dependency of lto-dump.o to
>         LTO_OBJS which will allow faster linking (mainly with LTO).
> ---
>   gcc/lto/Make-lang.in | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
>
Jan Hubicka Nov. 13, 2019, 10:49 p.m. UTC | #2 
> Hi.
> 
> Current lto-dump.o relies on some FE generated files as
> pre-requirement. That hover delays LTO linking of the lto-dump
> and so that I adjusted the dependency to LTO_OBJS which will
> work as well.
> 
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
> 
> Ready to be installed?
> Thanks,
> Martin
> 
> gcc/lto/ChangeLog:
> 
> 2019-11-11  Martin Liska  <mliska@suse.cz>
> 
> 	* Make-lang.in: Relax dependency of lto-dump.o to
> 	LTO_OBJS which will allow faster linking (mainly with LTO).
Hi,
thanks for looking into this. Unforutnately it seems that even after
your patch lto-dump always links only after all other frontends are
finished :(

Honza
Martin Liška Nov. 14, 2019, 8:18 a.m. UTC | #3 
On 11/13/19 11:49 PM, Jan Hubicka wrote:
>> Hi.
>>
>> Current lto-dump.o relies on some FE generated files as
>> pre-requirement. That hover delays LTO linking of the lto-dump
>> and so that I adjusted the dependency to LTO_OBJS which will
>> work as well.
>>
>> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>>
>> Ready to be installed?
>> Thanks,
>> Martin
>>
>> gcc/lto/ChangeLog:
>>
>> 2019-11-11  Martin Liska  <mliska@suse.cz>
>>
>> 	* Make-lang.in: Relax dependency of lto-dump.o to
>> 	LTO_OBJS which will allow faster linking (mainly with LTO).
> Hi,
> thanks for looking into this. Unforutnately it seems that even after
> your patch lto-dump always links only after all other frontends are
> finished :(

You are right :) I've got a patch that removes the not needed
(and blocking) dependency.

I'm going to install the patch after proper testing.
Martin

> 
> Honza
>
diff mbox series

Patch

diff --git a/gcc/lto/Make-lang.in b/gcc/lto/Make-lang.in
index 00701aec800..faee8899502 100644
--- a/gcc/lto/Make-lang.in
+++ b/gcc/lto/Make-lang.in
@@ -92,7 +92,7 @@  $(LTO_DUMP_EXE): $(LTO_EXE) $(LTO_DUMP_OBJS) $(BACKEND) $(LIBDEPS)
 	+$(LLINKER) $(ALL_LINKERFLAGS) $(LDFLAGS) -o $@ \
 		$(LTO_DUMP_OBJS) $(BACKEND) $(BACKENDLIBS) $(LIBS)
 
-lto/lto-dump.o: $(LTO_EXE)
+lto/lto-dump.o: $(LTO_OBJS)
 
 lto1.fda: ../prev-gcc/lto1$(exeext) ../prev-gcc/$(PERF_DATA)
 	$(CREATE_GCOV) -binary ../prev-gcc/lto1$(exeext) -gcov lto1.fda -profile ../prev-gcc/$(PERF_DATA) -gcov_version 1