| Message ID | 12cc0337-f876-1803-97ca-610b344bc2d9@suse.cz |
|---|---|
| State | New |
| Headers | show |
| Series | Enable VPOPCNTDQ for icelake-{client,server} and tigerlake. | expand |
On Wed, Nov 13, 2019 at 4:25 PM Martin Liška <mliska@suse.cz> wrote: > > Hi. > > The patch adds a missing feature for PTA_ICELAKE_CLIENT and > inherited CPUs. One can see that: > https://en.wikipedia.org/wiki/AVX-512#CPUs_with_AVX-512 > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > > gcc/ChangeLog: > > 2019-11-13 Martin Liska <mliska@suse.cz> > > PR target/92389 > * config/i386/i386.h: Add PTA_AVX512VPOPCNTDQ to > PTA_ICELAKE_CLIENT which is later interited by > PTA_ICELAKE_SERVER and PTA_TIGERLAKE. OK. Thanks, Uros. > --- > gcc/config/i386/i386.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >
On 11/13/19 5:14 PM, Uros Bizjak wrote: > On Wed, Nov 13, 2019 at 4:25 PM Martin Liška <mliska@suse.cz> wrote: >> >> Hi. >> >> The patch adds a missing feature for PTA_ICELAKE_CLIENT and >> inherited CPUs. One can see that: >> https://en.wikipedia.org/wiki/AVX-512#CPUs_with_AVX-512 >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >> >> Ready to be installed? >> Thanks, >> Martin >> >> gcc/ChangeLog: >> >> 2019-11-13 Martin Liska <mliska@suse.cz> >> >> PR target/92389 >> * config/i386/i386.h: Add PTA_AVX512VPOPCNTDQ to >> PTA_ICELAKE_CLIENT which is later interited by >> PTA_ICELAKE_SERVER and PTA_TIGERLAKE. > > > OK. > > Thanks, > Uros. Thank you for the review. May I install the patch to all active branches as well? Martin > >> --- >> gcc/config/i386/i386.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >>
On Thu, Nov 14, 2019 at 9:36 AM Martin Liška <mliska@suse.cz> wrote: > > On 11/13/19 5:14 PM, Uros Bizjak wrote: > > On Wed, Nov 13, 2019 at 4:25 PM Martin Liška <mliska@suse.cz> wrote: > >> > >> Hi. > >> > >> The patch adds a missing feature for PTA_ICELAKE_CLIENT and > >> inherited CPUs. One can see that: > >> https://en.wikipedia.org/wiki/AVX-512#CPUs_with_AVX-512 > >> > >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > >> > >> Ready to be installed? > >> Thanks, > >> Martin > >> > >> gcc/ChangeLog: > >> > >> 2019-11-13 Martin Liska <mliska@suse.cz> > >> > >> PR target/92389 > >> * config/i386/i386.h: Add PTA_AVX512VPOPCNTDQ to > >> PTA_ICELAKE_CLIENT which is later interited by > >> PTA_ICELAKE_SERVER and PTA_TIGERLAKE. > > > > > > OK. > > > > Thanks, > > Uros. > > Thank you for the review. > > May I install the patch to all active branches as well? Yes, it is simple enough and kind of obvious. Thanks, Uros. > Martin > > > > >> --- > >> gcc/config/i386/i386.h | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> >
diff --git a/gcc/config/i386/i386.h b/gcc/config/i386/i386.h index afa0aa83ddf..b042324cfd1 100644 --- a/gcc/config/i386/i386.h +++ b/gcc/config/i386/i386.h @@ -2438,7 +2438,7 @@ const wide_int_bitmask PTA_CANNONLAKE = PTA_SKYLAKE | PTA_AVX512F | PTA_AVX512VBMI | PTA_AVX512IFMA | PTA_SHA; const wide_int_bitmask PTA_ICELAKE_CLIENT = PTA_CANNONLAKE | PTA_AVX512VNNI | PTA_GFNI | PTA_VAES | PTA_AVX512VBMI2 | PTA_VPCLMULQDQ | PTA_AVX512BITALG - | PTA_RDPID | PTA_CLWB; + | PTA_RDPID | PTA_CLWB | PTA_AVX512VPOPCNTDQ; const wide_int_bitmask PTA_ICELAKE_SERVER = PTA_ICELAKE_CLIENT | PTA_PCONFIG | PTA_WBNOINVD; const wide_int_bitmask PTA_TIGERLAKE = PTA_ICELAKE_CLIENT | PTA_MOVDIRI