| Message ID | 20191113115952.775-6-alex.bennee@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | misc doc and testing fixes | expand |
On 13/11/2019 12.59, Alex Bennée wrote: > The older clangs are still struggling to build and run everything > withing the 50 minute timeout so lets lighten the load a bit more. We > still have coverage for GCC and hopefully no obscure 32 bit guest only > breakages slip through the cracks. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > .travis.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.travis.yml b/.travis.yml > index b9a026c8eeb..c09b6a00143 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -79,7 +79,7 @@ env: > - BASE_CONFIG="--disable-docs --disable-tools" > - TEST_CMD="make check V=1" > # This is broadly a list of "mainline" softmmu targets which have support across the major distros > - - MAIN_SOFTMMU_TARGETS="aarch64-softmmu,arm-softmmu,i386-softmmu,mips-softmmu,mips64-softmmu,ppc64-softmmu,riscv64-softmmu,s390x-softmmu,x86_64-softmmu" > + - MAIN_SOFTMMU_TARGETS="aarch64-softmmu,mips64-softmmu,ppc64-softmmu,riscv64-softmmu,s390x-softmmu,x86_64-softmmu" > - CCACHE_SLOPPINESS="include_file_ctime,include_file_mtime" > - CCACHE_MAXSIZE=1G Reviewed-by: Thomas Huth <thuth@redhat.com>
On 11/13/19 12:59 PM, Alex Bennée wrote: > The older clangs are still struggling to build and run everything > withing the 50 minute timeout so lets lighten the load a bit more. We > still have coverage for GCC and hopefully no obscure 32 bit guest only > breakages slip through the cracks. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > .travis.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.travis.yml b/.travis.yml > index b9a026c8eeb..c09b6a00143 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -79,7 +79,7 @@ env: > - BASE_CONFIG="--disable-docs --disable-tools" > - TEST_CMD="make check V=1" > # This is broadly a list of "mainline" softmmu targets which have support across the major distros > - - MAIN_SOFTMMU_TARGETS="aarch64-softmmu,arm-softmmu,i386-softmmu,mips-softmmu,mips64-softmmu,ppc64-softmmu,riscv64-softmmu,s390x-softmmu,x86_64-softmmu" > + - MAIN_SOFTMMU_TARGETS="aarch64-softmmu,mips64-softmmu,ppc64-softmmu,riscv64-softmmu,s390x-softmmu,x86_64-softmmu" Aleksandar, since you mostly test 32-bit MIPS, are you OK we keep mips-softmmu and drop mips64-softmmu here? Another job (acceptance-test) builds the mips64el-softmmu. > - CCACHE_SLOPPINESS="include_file_ctime,include_file_mtime" > - CCACHE_MAXSIZE=1G > >
> From: Philippe Mathieu-Daudé <philmd@redhat.com> > > - - MAIN_SOFTMMU_TARGETS="aarch64-softmmu,arm-softmmu,i386-softmmu,mips-softmmu,mips64-softmmu,ppc64-softmmu,riscv64-softmmu,s390x-softmmu,x86_64-softmmu" > > + - MAIN_SOFTMMU_TARGETS="aarch64-softmmu,mips64-softmmu,ppc64-softmmu,riscv64-softmmu,s390x-softmmu,x86_64-softmmu" > > Aleksandar, since you mostly test 32-bit MIPS, are you OK we keep > mips-softmmu and drop mips64-softmmu here? Another job (acceptance-test) > builds the mips64el-softmmu. Philippe, thanks for bringing this to my attention. Yes, 32-bit mips targets are important to us, but, what can we do, time constraints are time constraints, so I agree with Alex change, please go ahead, Alex. We can test 32-bit mips targets via other acceptance tests (those that can run longer, so-called "slow" group), and perhaps we can extend them to test more 32-bit mips systems. Thanks to everybody, Aleksandar
On 11/13/19 6:38 PM, Aleksandar Markovic wrote: >> From: Philippe Mathieu-Daudé <philmd@redhat.com> >>> - - MAIN_SOFTMMU_TARGETS="aarch64-softmmu,arm-softmmu,i386-softmmu,mips-softmmu,mips64-softmmu,ppc64-softmmu,riscv64-softmmu,s390x-softmmu,x86_64-softmmu" >>> + - MAIN_SOFTMMU_TARGETS="aarch64-softmmu,mips64-softmmu,ppc64-softmmu,riscv64-softmmu,s390x-softmmu,x86_64-softmmu" >> >> Aleksandar, since you mostly test 32-bit MIPS, are you OK we keep >> mips-softmmu and drop mips64-softmmu here? Another job (acceptance-test) >> builds the mips64el-softmmu. > > Philippe, thanks for bringing this to my attention. Yes, 32-bit mips targets are important to us, but, what can we do, time constraints are time constraints, so I agree with Alex change, please go ahead, Alex. We can test 32-bit mips targets via other acceptance tests (those that can run longer, so-called "slow" group), and perhaps we can extend them to test more 32-bit mips systems. OK, let's keep mips64 as suggested Alex then. Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Aleksandar Markovic <amarkovic@wavecomp.com> writes: >> From: Philippe Mathieu-Daudé <philmd@redhat.com> >> > - - MAIN_SOFTMMU_TARGETS="aarch64-softmmu,arm-softmmu,i386-softmmu,mips-softmmu,mips64-softmmu,ppc64-softmmu,riscv64-softmmu,s390x-softmmu,x86_64-softmmu" >> > + - MAIN_SOFTMMU_TARGETS="aarch64-softmmu,mips64-softmmu,ppc64-softmmu,riscv64-softmmu,s390x-softmmu,x86_64-softmmu" >> >> Aleksandar, since you mostly test 32-bit MIPS, are you OK we keep >> mips-softmmu and drop mips64-softmmu here? Another job (acceptance-test) >> builds the mips64el-softmmu. > > Philippe, thanks for bringing this to my attention. Yes, 32-bit mips > targets are important to us, but, what can we do, time constraints are > time constraints, so I agree with Alex change, please go ahead, Alex. > We can test 32-bit mips targets via other acceptance tests (those that > can run longer, so-called "slow" group), and perhaps we can extend > them to test more 32-bit mips systems. To be clear both gcc and clang have rules that test: - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}" So the main targets which are reducing their coverage are: - CONFIG="--enable-debug --target-list=${MAIN_SOFTMMU_TARGETS}" - CONFIG="--enable-modules --target-list=${MAIN_SOFTMMU_TARGETS}" - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS} " - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-sanitize" compiler: clang before_script: - ./configure ${CONFIG} --extra-cflags="-fsanitize=undefined -Werror" || { cat config.log && exit 1; } - CONFIG="--enable-gprof --enable-gcov --disable-pie --target-list=${MAIN_SOFTMMU_TARGETS}" and the MacOSX 9.4 build: # MacOSX builds - env: - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS}" os: osx osx_image: xcode9.4 compiler: clang The Xcode 10.3 build is already a reduced list: - CONFIG="--target-list=i386-softmmu,ppc-softmmu,ppc64-softmmu,m68k-softmmu,x86_64-softmmu" > > Thanks to everybody, > Aleksandar -- Alex Bennée
On 13/11/2019 14.30, Thomas Huth wrote: > On 13/11/2019 12.59, Alex Bennée wrote: >> The older clangs are still struggling to build and run everything >> withing the 50 minute timeout so lets lighten the load a bit more. We >> still have coverage for GCC and hopefully no obscure 32 bit guest only >> breakages slip through the cracks. >> >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> >> --- >> .travis.yml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/.travis.yml b/.travis.yml >> index b9a026c8eeb..c09b6a00143 100644 >> --- a/.travis.yml >> +++ b/.travis.yml >> @@ -79,7 +79,7 @@ env: >> - BASE_CONFIG="--disable-docs --disable-tools" >> - TEST_CMD="make check V=1" >> # This is broadly a list of "mainline" softmmu targets which have support across the major distros >> - - MAIN_SOFTMMU_TARGETS="aarch64-softmmu,arm-softmmu,i386-softmmu,mips-softmmu,mips64-softmmu,ppc64-softmmu,riscv64-softmmu,s390x-softmmu,x86_64-softmmu" >> + - MAIN_SOFTMMU_TARGETS="aarch64-softmmu,mips64-softmmu,ppc64-softmmu,riscv64-softmmu,s390x-softmmu,x86_64-softmmu" >> - CCACHE_SLOPPINESS="include_file_ctime,include_file_mtime" >> - CCACHE_MAXSIZE=1G > > Reviewed-by: Thomas Huth <thuth@redhat.com> On a second glance, we also have this entry with --target-list-exclude in our test matrix: - env: - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}" - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default" compiler: clang So while you've speed up one target, this one might get actually slower instead. That's a little bit unfortunate. Is there maybe a better way to tackle this? Thomas
diff --git a/.travis.yml b/.travis.yml index b9a026c8eeb..c09b6a00143 100644 --- a/.travis.yml +++ b/.travis.yml @@ -79,7 +79,7 @@ env: - BASE_CONFIG="--disable-docs --disable-tools" - TEST_CMD="make check V=1" # This is broadly a list of "mainline" softmmu targets which have support across the major distros - - MAIN_SOFTMMU_TARGETS="aarch64-softmmu,arm-softmmu,i386-softmmu,mips-softmmu,mips64-softmmu,ppc64-softmmu,riscv64-softmmu,s390x-softmmu,x86_64-softmmu" + - MAIN_SOFTMMU_TARGETS="aarch64-softmmu,mips64-softmmu,ppc64-softmmu,riscv64-softmmu,s390x-softmmu,x86_64-softmmu" - CCACHE_SLOPPINESS="include_file_ctime,include_file_mtime" - CCACHE_MAXSIZE=1G
The older clangs are still struggling to build and run everything withing the 50 minute timeout so lets lighten the load a bit more. We still have coverage for GCC and hopefully no obscure 32 bit guest only breakages slip through the cracks. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)