Message ID | 1573316433-40669-3-git-send-email-clabbe@baylibre.com |
---|---|
State | Changes Requested, archived |
Headers | show |
Series | ARM64: dts: allwinner: Add devicetree for pineH64 modelB | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | warning | "total: 0 errors, 2 warnings, 37 lines checked" |
robh/dt-meta-schema | success |
On Sat, Nov 09, 2019 at 04:20:33PM +0000, Corentin Labbe wrote: > This patch adds the model B of the PineH64. > The model B is smaller than the pine64 model A and has no PCIE slot. > > The only devicetree difference with the pineH64 model A, is the PHY > regulator and the HDMI connector node. > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> > --- > .../devicetree/bindings/arm/sunxi.yaml | 5 +++++ > arch/arm64/boot/dts/allwinner/Makefile | 1 + > .../allwinner/sun50i-h6-pine-h64-modelB.dts | 21 +++++++++++++++++++ > 3 files changed, 27 insertions(+) > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml > index b8ec616c2538..227217bf28df 100644 > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml > @@ -604,6 +604,11 @@ properties: > - const: pine64,pine-h64-modelA > - const: allwinner,sun50i-h6 > > + - description: Pine64 PineH64 model B > + items: > + - const: pine64,pine-h64-modelB > + - const: allwinner,sun50i-h6 > + > - description: Pine64 LTS > items: > - const: pine64,pine64-lts > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile > index d2418021768b..bda89b9ccb4a 100644 > --- a/arch/arm64/boot/dts/allwinner/Makefile > +++ b/arch/arm64/boot/dts/allwinner/Makefile > @@ -26,4 +26,5 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-3.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-lite2.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-one-plus.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64.dtb > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64-modelB.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts > new file mode 100644 > index 000000000000..063a85223faa > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts > @@ -0,0 +1,21 @@ > +// SPDX-License-Identifier: (GPL-2.0+ or MIT) > +/* > + * Copyright (C) 2019 Corentin LABBE <clabbe@baylibre.com> > + */ > + > +#include "sun50i-h6-pine-h64.dts" > + > +/ { > + model = "Pine H64 model B"; > + compatible = "pine64,pine-h64-modelB", "allwinner,sun50i-h6"; compatibles are usually lowercase, what about pine64,pine-h64-model-b? Maxime
On Tue, Nov 12, 2019 at 01:04:55PM +0100, Maxime Ripard wrote: > On Sat, Nov 09, 2019 at 04:20:33PM +0000, Corentin Labbe wrote: > > This patch adds the model B of the PineH64. > > The model B is smaller than the pine64 model A and has no PCIE slot. > > > > The only devicetree difference with the pineH64 model A, is the PHY > > regulator and the HDMI connector node. > > > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> > > --- > > .../devicetree/bindings/arm/sunxi.yaml | 5 +++++ > > arch/arm64/boot/dts/allwinner/Makefile | 1 + > > .../allwinner/sun50i-h6-pine-h64-modelB.dts | 21 +++++++++++++++++++ > > 3 files changed, 27 insertions(+) > > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts > > > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml > > index b8ec616c2538..227217bf28df 100644 > > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml > > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml > > @@ -604,6 +604,11 @@ properties: > > - const: pine64,pine-h64-modelA > > - const: allwinner,sun50i-h6 > > > > + - description: Pine64 PineH64 model B > > + items: > > + - const: pine64,pine-h64-modelB > > + - const: allwinner,sun50i-h6 > > + > > - description: Pine64 LTS > > items: > > - const: pine64,pine64-lts > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile > > index d2418021768b..bda89b9ccb4a 100644 > > --- a/arch/arm64/boot/dts/allwinner/Makefile > > +++ b/arch/arm64/boot/dts/allwinner/Makefile > > @@ -26,4 +26,5 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-3.dtb > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-lite2.dtb > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-one-plus.dtb > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64.dtb > > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64-modelB.dtb > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts > > new file mode 100644 > > index 000000000000..063a85223faa > > --- /dev/null > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts > > @@ -0,0 +1,21 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ or MIT) > > +/* > > + * Copyright (C) 2019 Corentin LABBE <clabbe@baylibre.com> > > + */ > > + > > +#include "sun50i-h6-pine-h64.dts" > > + > > +/ { > > + model = "Pine H64 model B"; > > + compatible = "pine64,pine-h64-modelB", "allwinner,sun50i-h6"; > > compatibles are usually lowercase, what about pine64,pine-h64-model-b? > Perfect, I will use it. Regards
diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml index b8ec616c2538..227217bf28df 100644 --- a/Documentation/devicetree/bindings/arm/sunxi.yaml +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml @@ -604,6 +604,11 @@ properties: - const: pine64,pine-h64-modelA - const: allwinner,sun50i-h6 + - description: Pine64 PineH64 model B + items: + - const: pine64,pine-h64-modelB + - const: allwinner,sun50i-h6 + - description: Pine64 LTS items: - const: pine64,pine64-lts diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile index d2418021768b..bda89b9ccb4a 100644 --- a/arch/arm64/boot/dts/allwinner/Makefile +++ b/arch/arm64/boot/dts/allwinner/Makefile @@ -26,4 +26,5 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-3.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-lite2.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-one-plus.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64.dtb +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64-modelB.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts new file mode 100644 index 000000000000..063a85223faa --- /dev/null +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts @@ -0,0 +1,21 @@ +// SPDX-License-Identifier: (GPL-2.0+ or MIT) +/* + * Copyright (C) 2019 Corentin LABBE <clabbe@baylibre.com> + */ + +#include "sun50i-h6-pine-h64.dts" + +/ { + model = "Pine H64 model B"; + compatible = "pine64,pine-h64-modelB", "allwinner,sun50i-h6"; + + /delete-node/ reg_gmac_3v3; +}; + +&hdmi_connector { + /delete-property/ ddc-en-gpios; +}; + +&emac { + phy-supply = <®_aldo2>; +};
This patch adds the model B of the PineH64. The model B is smaller than the pine64 model A and has no PCIE slot. The only devicetree difference with the pineH64 model A, is the PHY regulator and the HDMI connector node. Signed-off-by: Corentin Labbe <clabbe@baylibre.com> --- .../devicetree/bindings/arm/sunxi.yaml | 5 +++++ arch/arm64/boot/dts/allwinner/Makefile | 1 + .../allwinner/sun50i-h6-pine-h64-modelB.dts | 21 +++++++++++++++++++ 3 files changed, 27 insertions(+) create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelB.dts