| Message ID | 20191109095902.14425-1-xypron.glpk@gmx.de |
|---|---|
| State | Accepted |
| Commit | 5e5c785e34a18a12faedc93829e2a88ef22ade2a |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | [U-Boot,1/1] serial: sandbox: support Unicode | expand |
On Sat, Nov 9, 2019 at 11:59 AM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > Due to a conversion error the sandbox does not accept byte values 0x80-0xff > from the keyboard. The UEFI extended text input unit test requires Unicode > support. > > Use unsigned char for the serial buffer. > FWIW, Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > drivers/serial/sandbox.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/serial/sandbox.c b/drivers/serial/sandbox.c > index 2f7bc24887..1af5cc12f3 100644 > --- a/drivers/serial/sandbox.c > +++ b/drivers/serial/sandbox.c > @@ -33,7 +33,7 @@ DECLARE_GLOBAL_DATA_PTR; > * serial_buf_write == serial_buf_read -> empty buffer > * (serial_buf_write + 1) % 16 == serial_buf_read -> full buffer > */ > -static char serial_buf[16]; > +static unsigned char serial_buf[16]; > static unsigned int serial_buf_write; > static unsigned int serial_buf_read; > > -- > 2.24.0 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot
On Sat, 9 Nov 2019 at 03:35, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Sat, Nov 9, 2019 at 11:59 AM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > > > Due to a conversion error the sandbox does not accept byte values 0x80-0xff > > from the keyboard. The UEFI extended text input unit test requires Unicode > > support. > > > > Use unsigned char for the serial buffer. > > > > FWIW, > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Reviewed-by: Simon Glass <sjg@chromium.org>
diff --git a/drivers/serial/sandbox.c b/drivers/serial/sandbox.c index 2f7bc24887..1af5cc12f3 100644 --- a/drivers/serial/sandbox.c +++ b/drivers/serial/sandbox.c @@ -33,7 +33,7 @@ DECLARE_GLOBAL_DATA_PTR; * serial_buf_write == serial_buf_read -> empty buffer * (serial_buf_write + 1) % 16 == serial_buf_read -> full buffer */ -static char serial_buf[16]; +static unsigned char serial_buf[16]; static unsigned int serial_buf_write; static unsigned int serial_buf_read;
Due to a conversion error the sandbox does not accept byte values 0x80-0xff from the keyboard. The UEFI extended text input unit test requires Unicode support. Use unsigned char for the serial buffer. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- drivers/serial/sandbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.24.0