| Message ID | 20191105183504.21447-2-geert+renesas@glider.be |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | dt-bindings: display: renesas: du: Add vendor prefix to vsps property | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Tue, 5 Nov 2019 19:35:02 +0100, Geert Uytterhoeven wrote: > The Renesas-specific "vsps" property lacks a vendor prefix. > Add a "renesas," prefix to comply with DT best practises. > > Move "renesas,vsps" below "renesas,cmms" to preserve alphabetical sort > order. > > Fixes: 06711e6385a4ab4c ("drm: rcar-du: Document the vsps property in the DT bindings") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > .../devicetree/bindings/display/renesas,du.txt | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
Hi Geert, Thank you for the patch. On Tue, Nov 05, 2019 at 07:35:02PM +0100, Geert Uytterhoeven wrote: > The Renesas-specific "vsps" property lacks a vendor prefix. > Add a "renesas," prefix to comply with DT best practises. > > Move "renesas,vsps" below "renesas,cmms" to preserve alphabetical sort > order. > > Fixes: 06711e6385a4ab4c ("drm: rcar-du: Document the vsps property in the DT bindings") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> and taken in my tree. > --- > .../devicetree/bindings/display/renesas,du.txt | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt > index f6fdaa67c257a046..eb4ae41fe41f83c7 100644 > --- a/Documentation/devicetree/bindings/display/renesas,du.txt > +++ b/Documentation/devicetree/bindings/display/renesas,du.txt > @@ -41,15 +41,15 @@ Required Properties: > supplied they must be named "dclkin.x" with "x" being the input clock > numerical index. > > - - vsps: A list of phandle and channel index tuples to the VSPs that handle > - the memory interfaces for the DU channels. The phandle identifies the VSP > - instance that serves the DU channel, and the channel index identifies the > - LIF instance in that VSP. > - > - renesas,cmms: A list of phandles to the CMM instances present in the SoC, > one for each available DU channel. The property shall not be specified for > SoCs that do not provide any CMM (such as V3M and V3H). > > + - renesas,vsps: A list of phandle and channel index tuples to the VSPs that > + handle the memory interfaces for the DU channels. The phandle identifies the > + VSP instance that serves the DU channel, and the channel index identifies > + the LIF instance in that VSP. > + > Required nodes: > > The connections to the DU output video ports are modeled using the OF graph > @@ -96,8 +96,8 @@ Example: R8A7795 (R-Car H3) ES2.0 DU > <&cpg CPG_MOD 722>, > <&cpg CPG_MOD 721>; > clock-names = "du.0", "du.1", "du.2", "du.3"; > - vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, <&vspd0 1>; > renesas,cmms = <&cmm0>, <&cmm1>, <&cmm2>, <&cmm3>; > + renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, <&vspd0 1>; > > ports { > #address-cells = <1>;
diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt index f6fdaa67c257a046..eb4ae41fe41f83c7 100644 --- a/Documentation/devicetree/bindings/display/renesas,du.txt +++ b/Documentation/devicetree/bindings/display/renesas,du.txt @@ -41,15 +41,15 @@ Required Properties: supplied they must be named "dclkin.x" with "x" being the input clock numerical index. - - vsps: A list of phandle and channel index tuples to the VSPs that handle - the memory interfaces for the DU channels. The phandle identifies the VSP - instance that serves the DU channel, and the channel index identifies the - LIF instance in that VSP. - - renesas,cmms: A list of phandles to the CMM instances present in the SoC, one for each available DU channel. The property shall not be specified for SoCs that do not provide any CMM (such as V3M and V3H). + - renesas,vsps: A list of phandle and channel index tuples to the VSPs that + handle the memory interfaces for the DU channels. The phandle identifies the + VSP instance that serves the DU channel, and the channel index identifies + the LIF instance in that VSP. + Required nodes: The connections to the DU output video ports are modeled using the OF graph @@ -96,8 +96,8 @@ Example: R8A7795 (R-Car H3) ES2.0 DU <&cpg CPG_MOD 722>, <&cpg CPG_MOD 721>; clock-names = "du.0", "du.1", "du.2", "du.3"; - vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, <&vspd0 1>; renesas,cmms = <&cmm0>, <&cmm1>, <&cmm2>, <&cmm3>; + renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, <&vspd0 1>; ports { #address-cells = <1>;
The Renesas-specific "vsps" property lacks a vendor prefix. Add a "renesas," prefix to comply with DT best practises. Move "renesas,vsps" below "renesas,cmms" to preserve alphabetical sort order. Fixes: 06711e6385a4ab4c ("drm: rcar-du: Document the vsps property in the DT bindings") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- .../devicetree/bindings/display/renesas,du.txt | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)