| Message ID | 1227105593-29462-1-git-send-email-galak@kernel.crashing.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Commit | 1b98326b91eb9eea346945779e1f245aa66b17ce |
| Delegated to: | Paul Mackerras |
| Headers | show |
On Wed, 2008-11-19 at 08:39 -0600, Kumar Gala wrote: > Signed-off-by: Kumar Gala <galak@kernel.crashing.org> > --- Shouldn't this be protected by some ifdef ? Ben. > arch/powerpc/kernel/process.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c > index 957bded..b038323 100644 > --- a/arch/powerpc/kernel/process.c > +++ b/arch/powerpc/kernel/process.c > @@ -467,6 +467,8 @@ static struct regbit { > {MSR_VEC, "VEC"}, > {MSR_VSX, "VSX"}, > {MSR_ME, "ME"}, > + {MSR_CE, "CE"}, > + {MSR_DE, "DE"}, > {MSR_IR, "IR"}, > {MSR_DR, "DR"}, > {0, NULL}
On Nov 19, 2008, at 10:46 PM, Benjamin Herrenschmidt wrote: > On Wed, 2008-11-19 at 08:39 -0600, Kumar Gala wrote: >> Signed-off-by: Kumar Gala <galak@kernel.crashing.org> >> --- > > Shouldn't this be protected by some ifdef ? > > Ben. > >> arch/powerpc/kernel/process.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/ >> process.c >> index 957bded..b038323 100644 >> --- a/arch/powerpc/kernel/process.c >> +++ b/arch/powerpc/kernel/process.c >> @@ -467,6 +467,8 @@ static struct regbit { >> {MSR_VEC, "VEC"}, >> {MSR_VSX, "VSX"}, >> {MSR_ME, "ME"}, >> + {MSR_CE, "CE"}, >> + {MSR_DE, "DE"}, >> {MSR_IR, "IR"}, >> {MSR_DR, "DR"}, >> {0, NULL} Why? The bits are always defined and don't seem to be reused (and we don't ifdef VEC, VSX, etc..) so why bother? - k
diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c index 957bded..b038323 100644 --- a/arch/powerpc/kernel/process.c +++ b/arch/powerpc/kernel/process.c @@ -467,6 +467,8 @@ static struct regbit { {MSR_VEC, "VEC"}, {MSR_VSX, "VSX"}, {MSR_ME, "ME"}, + {MSR_CE, "CE"}, + {MSR_DE, "DE"}, {MSR_IR, "IR"}, {MSR_DR, "DR"}, {0, NULL}
Signed-off-by: Kumar Gala <galak@kernel.crashing.org> --- arch/powerpc/kernel/process.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)