| Message ID | 20191031123040.26316-3-benjamin.gaignard@st.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Convert STM32 Timer mdf bindings to yaml | expand |
On Thu, 31 Oct 2019 13:30:38 +0100 Benjamin Gaignard <benjamin.gaignard@st.com> wrote: > Convert the STM32 IIO trigger binding to DT schema format using json-schema > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> I'm far from great on these as still haven't taken the time I should to learn the yaml syntax properly. A few comments inline however based mostly on this doesn't quite look like other ones I've seen recently. Thanks, Jonathan > --- > .../bindings/iio/timer/st,stm32-timer-trigger.yaml | 44 ++++++++++++++++++++++ > .../bindings/iio/timer/stm32-timer-trigger.txt | 25 ------------ > 2 files changed, 44 insertions(+), 25 deletions(-) > create mode 100644 Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml > delete mode 100644 Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt > > diff --git a/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml > new file mode 100644 > index 000000000000..1c8c8b55e8cd > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/timer/st,stm32-timer-trigger.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: STMicroelectronics STM32 Timers IIO timer bindings > + > +maintainers: > + - Benjamin Gaignard <benjamin.gaignard@st.com> > + - Fabrice Gasnier <fabrice.gasnier@st.com> > + > +properties: > + $nodemane: nodename? > + pattern: "^timer@[0-9]+$" > + type: object > + > + description: > + must be a sub-node of an STM32 Timer device tree node > + > + properties: > + compatible: > + oneOf: enum is I think preferred for these. > + - const: st,stm32-timer-trigger > + - const: st,stm32h7-timer-trigger > + > + reg: true Normally some info for what the reg value is.. > + > + required: > + - compatible > + - reg > + > +examples: > + - | > + timers2: timer@40000000 { > + #address-cells = <1>; > + #size-cells = <0>; > + timer@0 { > + compatible = "st,stm32-timer-trigger"; > + reg = <0>; > + }; > + }; > + > +... > diff --git a/Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt b/Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt > deleted file mode 100644 > index b8e8c769d434..000000000000 > --- a/Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt > +++ /dev/null > @@ -1,25 +0,0 @@ > -STMicroelectronics STM32 Timers IIO timer bindings > - > -Must be a sub-node of an STM32 Timers device tree node. > -See ../mfd/stm32-timers.txt for details about the parent node. > - > -Required parameters: > -- compatible: Must be one of: > - "st,stm32-timer-trigger" > - "st,stm32h7-timer-trigger" > -- reg: Identify trigger hardware block. > - > -Example: > - timers@40010000 { > - #address-cells = <1>; > - #size-cells = <0>; > - compatible = "st,stm32-timers"; > - reg = <0x40010000 0x400>; > - clocks = <&rcc 0 160>; > - clock-names = "int"; > - > - timer@0 { > - compatible = "st,stm32-timer-trigger"; > - reg = <0>; > - }; > - };
Le dim. 3 nov. 2019 à 12:08, Jonathan Cameron <jic23@kernel.org> a écrit : > > On Thu, 31 Oct 2019 13:30:38 +0100 > Benjamin Gaignard <benjamin.gaignard@st.com> wrote: > > > Convert the STM32 IIO trigger binding to DT schema format using json-schema > > > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> > I'm far from great on these as still haven't taken the time I should to learn > the yaml syntax properly. A few comments inline however based mostly on this > doesn't quite look like other ones I've seen recently. > > Thanks, > > Jonathan > > > --- > > .../bindings/iio/timer/st,stm32-timer-trigger.yaml | 44 ++++++++++++++++++++++ > > .../bindings/iio/timer/stm32-timer-trigger.txt | 25 ------------ > > 2 files changed, 44 insertions(+), 25 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml > > delete mode 100644 Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt > > > > diff --git a/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml > > new file mode 100644 > > index 000000000000..1c8c8b55e8cd > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml > > @@ -0,0 +1,44 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/timer/st,stm32-timer-trigger.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: STMicroelectronics STM32 Timers IIO timer bindings > > + > > +maintainers: > > + - Benjamin Gaignard <benjamin.gaignard@st.com> > > + - Fabrice Gasnier <fabrice.gasnier@st.com> > > + > > +properties: > > + $nodemane: > > nodename? That will be in v2 > > > + pattern: "^timer@[0-9]+$" > > + type: object > > + > > + description: > > + must be a sub-node of an STM32 Timer device tree node > > + > > + properties: > > + compatible: > > + oneOf: > > enum is I think preferred for these. as you like it will be in v2 > > > + - const: st,stm32-timer-trigger > > + - const: st,stm32h7-timer-trigger > > + > > + reg: true > > Normally some info for what the reg value is.. I can't put "description" on this field because the syntax doesn't allow it. I will add a comment in v2 to explain what reg is. Thanks for your review. Benjamin > > > + > > + required: > > + - compatible > > + - reg > > + > > +examples: > > + - | > > + timers2: timer@40000000 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + timer@0 { > > + compatible = "st,stm32-timer-trigger"; > > + reg = <0>; > > + }; > > + }; > > + > > +... > > diff --git a/Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt b/Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt > > deleted file mode 100644 > > index b8e8c769d434..000000000000 > > --- a/Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt > > +++ /dev/null > > @@ -1,25 +0,0 @@ > > -STMicroelectronics STM32 Timers IIO timer bindings > > - > > -Must be a sub-node of an STM32 Timers device tree node. > > -See ../mfd/stm32-timers.txt for details about the parent node. > > - > > -Required parameters: > > -- compatible: Must be one of: > > - "st,stm32-timer-trigger" > > - "st,stm32h7-timer-trigger" > > -- reg: Identify trigger hardware block. > > - > > -Example: > > - timers@40010000 { > > - #address-cells = <1>; > > - #size-cells = <0>; > > - compatible = "st,stm32-timers"; > > - reg = <0x40010000 0x400>; > > - clocks = <&rcc 0 160>; > > - clock-names = "int"; > > - > > - timer@0 { > > - compatible = "st,stm32-timer-trigger"; > > - reg = <0>; > > - }; > > - }; > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Tue, Nov 05, 2019 at 11:07:16AM +0100, Benjamin Gaignard wrote: > Le dim. 3 nov. 2019 à 12:08, Jonathan Cameron <jic23@kernel.org> a écrit : > > > > On Thu, 31 Oct 2019 13:30:38 +0100 > > Benjamin Gaignard <benjamin.gaignard@st.com> wrote: > > > > > Convert the STM32 IIO trigger binding to DT schema format using json-schema > > > > > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> > > I'm far from great on these as still haven't taken the time I should to learn > > the yaml syntax properly. A few comments inline however based mostly on this > > doesn't quite look like other ones I've seen recently. > > > > Thanks, > > > > Jonathan > > > > > --- > > > .../bindings/iio/timer/st,stm32-timer-trigger.yaml | 44 ++++++++++++++++++++++ > > > .../bindings/iio/timer/stm32-timer-trigger.txt | 25 ------------ > > > 2 files changed, 44 insertions(+), 25 deletions(-) > > > create mode 100644 Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml > > > delete mode 100644 Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt > > > > > > diff --git a/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml > > > new file mode 100644 > > > index 000000000000..1c8c8b55e8cd > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml > > > @@ -0,0 +1,44 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/iio/timer/st,stm32-timer-trigger.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: STMicroelectronics STM32 Timers IIO timer bindings > > > + > > > +maintainers: > > > + - Benjamin Gaignard <benjamin.gaignard@st.com> > > > + - Fabrice Gasnier <fabrice.gasnier@st.com> > > > + > > > +properties: > > > + $nodemane: > > > > nodename? > > That will be in v2 No, $nodename is correct. The '$' signifies something we generate and add in. IOW, not a real property. I guess we could have used 'name' here and stuck with traditional OpenFirmware. > > > > > > + pattern: "^timer@[0-9]+$" > > > + type: object > > > + > > > + description: > > > + must be a sub-node of an STM32 Timer device tree node > > > + > > > + properties: > > > + compatible: > > > + oneOf: > > > > enum is I think preferred for these. > > as you like it will be in v2 > > > > > > + - const: st,stm32-timer-trigger > > > + - const: st,stm32h7-timer-trigger > > > + > > > + reg: true > > > > Normally some info for what the reg value is.. > I can't put "description" on this field because the syntax doesn't allow it. > I will add a comment in v2 to explain what reg is. items: - maximum: <max timer number> Rob
On 11/6/19 5:06 AM, Rob Herring wrote: > On Tue, Nov 05, 2019 at 11:07:16AM +0100, Benjamin Gaignard wrote: >> Le dim. 3 nov. 2019 à 12:08, Jonathan Cameron <jic23@kernel.org> a écrit : >>> On Thu, 31 Oct 2019 13:30:38 +0100 >>> Benjamin Gaignard <benjamin.gaignard@st.com> wrote: >>> >>>> Convert the STM32 IIO trigger binding to DT schema format using json-schema >>>> >>>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> >>> I'm far from great on these as still haven't taken the time I should to learn >>> the yaml syntax properly. A few comments inline however based mostly on this >>> doesn't quite look like other ones I've seen recently. >>> >>> Thanks, >>> >>> Jonathan >>> >>>> --- >>>> .../bindings/iio/timer/st,stm32-timer-trigger.yaml | 44 ++++++++++++++++++++++ >>>> .../bindings/iio/timer/stm32-timer-trigger.txt | 25 ------------ >>>> 2 files changed, 44 insertions(+), 25 deletions(-) >>>> create mode 100644 Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml >>>> delete mode 100644 Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt >>>> >>>> diff --git a/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml >>>> new file mode 100644 >>>> index 000000000000..1c8c8b55e8cd >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml >>>> @@ -0,0 +1,44 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/iio/timer/st,stm32-timer-trigger.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: STMicroelectronics STM32 Timers IIO timer bindings >>>> + >>>> +maintainers: >>>> + - Benjamin Gaignard <benjamin.gaignard@st.com> >>>> + - Fabrice Gasnier <fabrice.gasnier@st.com> >>>> + >>>> +properties: >>>> + $nodemane: >>> nodename? >> That will be in v2 > No, $nodename is correct. The '$' signifies something we generate and > add in. IOW, not a real property. I guess we could have used 'name' here > and stuck with traditional OpenFirmware. let's go for $name >>>> + pattern: "^timer@[0-9]+$" >>>> + type: object >>>> + >>>> + description: >>>> + must be a sub-node of an STM32 Timer device tree node >>>> + >>>> + properties: >>>> + compatible: >>>> + oneOf: >>> enum is I think preferred for these. >> as you like it will be in v2 >> >>>> + - const: st,stm32-timer-trigger >>>> + - const: st,stm32h7-timer-trigger >>>> + >>>> + reg: true >>> Normally some info for what the reg value is.. >> I can't put "description" on this field because the syntax doesn't allow it. >> I will add a comment in v2 to explain what reg is. > items: > - maximum: <max timer number> reg is an index from 0 up to X, I will try with your syntax. Thanks, Benjamin > > Rob
On Wed, Nov 6, 2019 at 1:52 PM Benjamin GAIGNARD <benjamin.gaignard@st.com> wrote: > > > On 11/6/19 5:06 AM, Rob Herring wrote: > > On Tue, Nov 05, 2019 at 11:07:16AM +0100, Benjamin Gaignard wrote: > >> Le dim. 3 nov. 2019 à 12:08, Jonathan Cameron <jic23@kernel.org> a écrit : > >>> On Thu, 31 Oct 2019 13:30:38 +0100 > >>> Benjamin Gaignard <benjamin.gaignard@st.com> wrote: > >>> > >>>> Convert the STM32 IIO trigger binding to DT schema format using json-schema > >>>> > >>>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> > >>> I'm far from great on these as still haven't taken the time I should to learn > >>> the yaml syntax properly. A few comments inline however based mostly on this > >>> doesn't quite look like other ones I've seen recently. > >>> > >>> Thanks, > >>> > >>> Jonathan > >>> > >>>> --- > >>>> .../bindings/iio/timer/st,stm32-timer-trigger.yaml | 44 ++++++++++++++++++++++ > >>>> .../bindings/iio/timer/stm32-timer-trigger.txt | 25 ------------ > >>>> 2 files changed, 44 insertions(+), 25 deletions(-) > >>>> create mode 100644 Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml > >>>> delete mode 100644 Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt > >>>> > >>>> diff --git a/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml > >>>> new file mode 100644 > >>>> index 000000000000..1c8c8b55e8cd > >>>> --- /dev/null > >>>> +++ b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml > >>>> @@ -0,0 +1,44 @@ > >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >>>> +%YAML 1.2 > >>>> +--- > >>>> +$id: http://devicetree.org/schemas/iio/timer/st,stm32-timer-trigger.yaml# > >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>>> + > >>>> +title: STMicroelectronics STM32 Timers IIO timer bindings > >>>> + > >>>> +maintainers: > >>>> + - Benjamin Gaignard <benjamin.gaignard@st.com> > >>>> + - Fabrice Gasnier <fabrice.gasnier@st.com> > >>>> + > >>>> +properties: > >>>> + $nodemane: > >>> nodename? > >> That will be in v2 > > No, $nodename is correct. The '$' signifies something we generate and > > add in. IOW, not a real property. I guess we could have used 'name' here > > and stuck with traditional OpenFirmware. > let's go for $name No, $nodename is correct. You don't have a choice. That is what the tooling generates. Rob
On Wed, 6 Nov 2019 17:35:20 -0600 Rob Herring <robh@kernel.org> wrote: > On Wed, Nov 6, 2019 at 1:52 PM Benjamin GAIGNARD > <benjamin.gaignard@st.com> wrote: > > > > > > On 11/6/19 5:06 AM, Rob Herring wrote: > > > On Tue, Nov 05, 2019 at 11:07:16AM +0100, Benjamin Gaignard wrote: > > >> Le dim. 3 nov. 2019 à 12:08, Jonathan Cameron <jic23@kernel.org> a écrit : > > >>> On Thu, 31 Oct 2019 13:30:38 +0100 > > >>> Benjamin Gaignard <benjamin.gaignard@st.com> wrote: > > >>> > > >>>> Convert the STM32 IIO trigger binding to DT schema format using json-schema > > >>>> > > >>>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> > > >>> I'm far from great on these as still haven't taken the time I should to learn > > >>> the yaml syntax properly. A few comments inline however based mostly on this > > >>> doesn't quite look like other ones I've seen recently. > > >>> > > >>> Thanks, > > >>> > > >>> Jonathan > > >>> > > >>>> --- > > >>>> .../bindings/iio/timer/st,stm32-timer-trigger.yaml | 44 ++++++++++++++++++++++ > > >>>> .../bindings/iio/timer/stm32-timer-trigger.txt | 25 ------------ > > >>>> 2 files changed, 44 insertions(+), 25 deletions(-) > > >>>> create mode 100644 Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml > > >>>> delete mode 100644 Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt > > >>>> > > >>>> diff --git a/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml > > >>>> new file mode 100644 > > >>>> index 000000000000..1c8c8b55e8cd > > >>>> --- /dev/null > > >>>> +++ b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml > > >>>> @@ -0,0 +1,44 @@ > > >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > >>>> +%YAML 1.2 > > >>>> +--- > > >>>> +$id: http://devicetree.org/schemas/iio/timer/st,stm32-timer-trigger.yaml# > > >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > > >>>> + > > >>>> +title: STMicroelectronics STM32 Timers IIO timer bindings > > >>>> + > > >>>> +maintainers: > > >>>> + - Benjamin Gaignard <benjamin.gaignard@st.com> > > >>>> + - Fabrice Gasnier <fabrice.gasnier@st.com> > > >>>> + > > >>>> +properties: > > >>>> + $nodemane: > > >>> nodename? > > >> That will be in v2 > > > No, $nodename is correct. The '$' signifies something we generate and > > > add in. IOW, not a real property. I guess we could have used 'name' here > > > and stuck with traditional OpenFirmware. > > let's go for $name > > No, $nodename is correct. You don't have a choice. That is what the > tooling generates. Sorry all, I caused confusion here. Was just trying to point out the typo! $node_m_ane :) > > Rob
diff --git a/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml new file mode 100644 index 000000000000..1c8c8b55e8cd --- /dev/null +++ b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml @@ -0,0 +1,44 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/timer/st,stm32-timer-trigger.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: STMicroelectronics STM32 Timers IIO timer bindings + +maintainers: + - Benjamin Gaignard <benjamin.gaignard@st.com> + - Fabrice Gasnier <fabrice.gasnier@st.com> + +properties: + $nodemane: + pattern: "^timer@[0-9]+$" + type: object + + description: + must be a sub-node of an STM32 Timer device tree node + + properties: + compatible: + oneOf: + - const: st,stm32-timer-trigger + - const: st,stm32h7-timer-trigger + + reg: true + + required: + - compatible + - reg + +examples: + - | + timers2: timer@40000000 { + #address-cells = <1>; + #size-cells = <0>; + timer@0 { + compatible = "st,stm32-timer-trigger"; + reg = <0>; + }; + }; + +... diff --git a/Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt b/Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt deleted file mode 100644 index b8e8c769d434..000000000000 --- a/Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt +++ /dev/null @@ -1,25 +0,0 @@ -STMicroelectronics STM32 Timers IIO timer bindings - -Must be a sub-node of an STM32 Timers device tree node. -See ../mfd/stm32-timers.txt for details about the parent node. - -Required parameters: -- compatible: Must be one of: - "st,stm32-timer-trigger" - "st,stm32h7-timer-trigger" -- reg: Identify trigger hardware block. - -Example: - timers@40010000 { - #address-cells = <1>; - #size-cells = <0>; - compatible = "st,stm32-timers"; - reg = <0x40010000 0x400>; - clocks = <&rcc 0 160>; - clock-names = "int"; - - timer@0 { - compatible = "st,stm32-timer-trigger"; - reg = <0>; - }; - };
Convert the STM32 IIO trigger binding to DT schema format using json-schema Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> --- .../bindings/iio/timer/st,stm32-timer-trigger.yaml | 44 ++++++++++++++++++++++ .../bindings/iio/timer/stm32-timer-trigger.txt | 25 ------------ 2 files changed, 44 insertions(+), 25 deletions(-) create mode 100644 Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml delete mode 100644 Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt