| Message ID | 20191024031704.6844-1-dja@axtens.net |
|---|---|
| State | Accepted |
| Headers | show |
| Series | travis, tox: only do coverage testing in py27 | expand |
Applied. Daniel Axtens <dja@axtens.net> writes: > Currently Travis calls `tox -e coverage` unconditionally. However, > the environment has py27 basepython, so all the runs only generate > py27 coverage! > > Rather than try to untangle that, just run the coverage when run > in a py27 travis environment. This makes things faster for no > loss of coverage. It means that codecov has nothing to submit for > the py3x environments, but that's no real loss: it would otherwise > submit lots of duplicate data. > > We could try to improve coverage by running coverage for 27 and 3x, > but given that 27 is going away, don't stress at this point. > > Signed-off-by: Daniel Axtens <dja@axtens.net> > --- > .travis.yml | 1 - > tox.ini | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git .travis.yml .travis.yml > index 51746b2674ce..90ff36dfe52b 100644 > --- .travis.yml > +++ .travis.yml > @@ -55,7 +55,6 @@ script: > psql -c "SELECT VERSION(), CURRENT_USER, current_database()" -U $PW_TEST_DB_USER patchwork; > fi > - tox > - - tox -e coverage > > after_success: > - codecov > diff --git tox.ini tox.ini > index 617e73cdbee6..882c44a628eb 100644 > --- tox.ini > +++ tox.ini > @@ -86,4 +86,4 @@ commands = > > [travis] > python = > - 2.7: py27, pep8 > + 2.7: py27, pep8, coverage > -- > 2.20.1
diff --git .travis.yml .travis.yml index 51746b2674ce..90ff36dfe52b 100644 --- .travis.yml +++ .travis.yml @@ -55,7 +55,6 @@ script: psql -c "SELECT VERSION(), CURRENT_USER, current_database()" -U $PW_TEST_DB_USER patchwork; fi - tox - - tox -e coverage after_success: - codecov diff --git tox.ini tox.ini index 617e73cdbee6..882c44a628eb 100644 --- tox.ini +++ tox.ini @@ -86,4 +86,4 @@ commands = [travis] python = - 2.7: py27, pep8 + 2.7: py27, pep8, coverage
Currently Travis calls `tox -e coverage` unconditionally. However, the environment has py27 basepython, so all the runs only generate py27 coverage! Rather than try to untangle that, just run the coverage when run in a py27 travis environment. This makes things faster for no loss of coverage. It means that codecov has nothing to submit for the py3x environments, but that's no real loss: it would otherwise submit lots of duplicate data. We could try to improve coverage by running coverage for 27 and 3x, but given that 27 is going away, don't stress at this point. Signed-off-by: Daniel Axtens <dja@axtens.net> --- .travis.yml | 1 - tox.ini | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-)