| Message ID | 20191024202703.8017-2-chris.packham@alliedtelesis.co.nz |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: brcm: XGS iProc GPIO driver | expand |
On Thu, Oct 24, 2019 at 3:27 PM Chris Packham <chris.packham@alliedtelesis.co.nz> wrote: > > This GPIO controller is present on a number of Broadcom switch ASICs > with integrated SoCs. It is similar to the nsp-gpio and iproc-gpio > blocks but different enough to require a separate driver. > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > --- > > Notes: > Changes in v4: > - rename brcm,xgs-iproc.yaml -> brcm,xgs-iproc-gpio.yaml as suggested > > Changes in v3: > - incorporate review comments from Rob and Bart > > Changes in v2: > - Document as DT schema > - Include ngpios, #gpio-cells and gpio-controller properties > > .../bindings/gpio/brcm,xgs-iproc-gpio.yaml | 70 +++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml > > diff --git a/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml b/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml > new file mode 100644 > index 000000000000..ec1fd3a64aa2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gpio/brcm,xgs-iproc.yaml# Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml: $id: path/filename 'gpio/brcm,xgs-iproc.yaml' doesn't match actual filename Otherwise, Reviewed-by: Rob Herring <robh@kernel.org>
Hi Rob, On Fri, 2019-10-25 at 12:12 -0500, Rob Herring wrote: > On Thu, Oct 24, 2019 at 3:27 PM Chris Packham > <chris.packham@alliedtelesis.co.nz> wrote: > > > > This GPIO controller is present on a number of Broadcom switch ASICs > > with integrated SoCs. It is similar to the nsp-gpio and iproc-gpio > > blocks but different enough to require a separate driver. > > > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > > --- > > > > Notes: > > Changes in v4: > > - rename brcm,xgs-iproc.yaml -> brcm,xgs-iproc-gpio.yaml as suggested > > > > Changes in v3: > > - incorporate review comments from Rob and Bart > > > > Changes in v2: > > - Document as DT schema > > - Include ngpios, #gpio-cells and gpio-controller properties > > > > .../bindings/gpio/brcm,xgs-iproc-gpio.yaml | 70 +++++++++++++++++++ > > 1 file changed, 70 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml > > > > diff --git a/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml b/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml > > new file mode 100644 > > index 000000000000..ec1fd3a64aa2 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml > > @@ -0,0 +1,70 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/gpio/brcm,xgs-iproc.yaml# > > Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml: $id: > path/filename 'gpio/brcm,xgs-iproc.yaml' doesn't match actual filename > > Otherwise, > > Reviewed-by: Rob Herring <robh@kernel.org> I'll send a quick v5 of just this patch with the minor correction and your reviewed-by.
diff --git a/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml b/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml new file mode 100644 index 000000000000..ec1fd3a64aa2 --- /dev/null +++ b/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml @@ -0,0 +1,70 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpio/brcm,xgs-iproc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Broadcom XGS iProc GPIO controller + +maintainers: + - Chris Packham <chris.packham@alliedtelesis.co.nz> + +description: | + This controller is the Chip Common A GPIO present on a number of Broadcom + switch ASICs with integrated SoCs. + +properties: + compatible: + const: brcm,iproc-gpio-cca + + reg: + items: + - description: the I/O address containing the GPIO controller + registers. + - description: the I/O address containing the Chip Common A interrupt + registers. + + gpio-controller: true + + '#gpio-cells': + const: 2 + + ngpios: + minimum: 0 + maximum: 32 + + interrupt-controller: true + + '#interrupt-cells': + const: 2 + + interrupts: + maxItems: 1 + +required: + - compatible + - reg + - "#gpio-cells" + - gpio-controller + +dependencies: + interrupt-controller: [ interrupts ] + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + gpio@18000060 { + compatible = "brcm,iproc-gpio-cca"; + #gpio-cells = <2>; + reg = <0x18000060 0x50>, + <0x18000000 0x50>; + ngpios = <12>; + gpio-controller; + interrupt-controller; + #interrupt-cells = <2>; + interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>; + }; + + +...
This GPIO controller is present on a number of Broadcom switch ASICs with integrated SoCs. It is similar to the nsp-gpio and iproc-gpio blocks but different enough to require a separate driver. Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> --- Notes: Changes in v4: - rename brcm,xgs-iproc.yaml -> brcm,xgs-iproc-gpio.yaml as suggested Changes in v3: - incorporate review comments from Rob and Bart Changes in v2: - Document as DT schema - Include ngpios, #gpio-cells and gpio-controller properties .../bindings/gpio/brcm,xgs-iproc-gpio.yaml | 70 +++++++++++++++++++ 1 file changed, 70 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml