| Message ID | 20191023211101.16591-9-adrian.freihofer@siemens.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | simplify swupdate config | expand |
Am 23.10.19 um 23:10 schrieb Adrian Freihofer: > swupdate-www requires the swupdate-progress service from swupdate-tools > package. Should we move swupdate-progress into its own package? Regards Stefan
Hi Stefan, That's what I've been thinking about. I only see advantages in it. But I would prefer to do it in another merge request. Regards, Adrian Am Donnerstag, 24. Oktober 2019 10:45:03 UTC+2 schrieb Stefan Herbrechtsmeier: > > Am 23.10.19 um 23:10 schrieb Adrian Freihofer: > > swupdate-www requires the swupdate-progress service from swupdate-tools > > package. > > Should we move swupdate-progress into its own package? > > Regards > Stefan >
Hi Adrian, On 23/10/19 23:10, Adrian Freihofer wrote: > swupdate-www requires the swupdate-progress service from swupdate-tools > package. > Why ? swupdate-progress is not mandatory. I can have swupdate-www (Website) without swupdate-progress. Best regards, Stefano > Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com> > --- > recipes-support/swupdate/swupdate.inc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/recipes-support/swupdate/swupdate.inc b/recipes-support/swupdate/swupdate.inc > index 392af31..1c863bb 100644 > --- a/recipes-support/swupdate/swupdate.inc > +++ b/recipes-support/swupdate/swupdate.inc > @@ -24,6 +24,8 @@ FILES_${PN}-lua += "${libdir}/lua/" > FILES_${PN}-www = "/www/*" > FILES_${PN} += "${libdir}/tmpfiles.d" > > +RDEPENDS_${PN}-www += "${PN}-tools" > + > S = "${WORKDIR}/git/" > > EXTRA_OEMAKE += " HOSTCC="${BUILD_CC}" HOSTCXX="${BUILD_CXX}" LD="${CC}" DESTDIR="${D}" V=1 ARCH=${TARGET_ARCH} CROSS_COMPILE=${TARGET_PREFIX} SKIP_STRIP=y" >
On 24/10/19 12:38, adrian.freihofer@gmail.com wrote: > Hi Stefan, > > That's what I've been thinking about. I only see advantages in it Agree, I've been thinking about, too. Regards, Stefano >. But I > would prefer to do it in another merge request. > > Regards, > Adrian > > Am Donnerstag, 24. Oktober 2019 10:45:03 UTC+2 schrieb Stefan > Herbrechtsmeier: > > Am 23.10.19 um 23:10 schrieb Adrian Freihofer: > > swupdate-www requires the swupdate-progress service from > swupdate-tools > > package. > > Should we move swupdate-progress into its own package? > > Regards > Stefan > > -- > You received this message because you are subscribed to the Google > Groups "swupdate" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to swupdate+unsubscribe@googlegroups.com > <mailto:swupdate+unsubscribe@googlegroups.com>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/swupdate/7fc9ed98-023d-400e-88e3-5a4b0410b939%40googlegroups.com > <https://groups.google.com/d/msgid/swupdate/7fc9ed98-023d-400e-88e3-5a4b0410b939%40googlegroups.com?utm_medium=email&utm_source=footer>.
Hi Stefano Am Samstag, 26. Oktober 2019 22:16:18 UTC+2 schrieb Stefano Babic: > > Hi Adrian, > > On 23/10/19 23:10, Adrian Freihofer wrote: > > swupdate-www requires the swupdate-progress service from swupdate-tools > > package. > > > > Why ? swupdate-progress is not mandatory. I can have swupdate-www > (Website) without swupdate-progress. > Please ignore this patch. I did not see this use case. I just realized that some features of swupdate-www did not work without haveing swupdate-progress as well. Regards, Adrian > > Best regards, > Stefano > > > Signed-off-by: Adrian Freihofer <adrian....@siemens.com <javascript:>> > > --- > > recipes-support/swupdate/swupdate.inc | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/recipes-support/swupdate/swupdate.inc > b/recipes-support/swupdate/swupdate.inc > > index 392af31..1c863bb 100644 > > --- a/recipes-support/swupdate/swupdate.inc > > +++ b/recipes-support/swupdate/swupdate.inc > > @@ -24,6 +24,8 @@ FILES_${PN}-lua += "${libdir}/lua/" > > FILES_${PN}-www = "/www/*" > > FILES_${PN} += "${libdir}/tmpfiles.d" > > > > +RDEPENDS_${PN}-www += "${PN}-tools" > > + > > S = "${WORKDIR}/git/" > > > > EXTRA_OEMAKE += " HOSTCC="${BUILD_CC}" HOSTCXX="${BUILD_CXX}" > LD="${CC}" DESTDIR="${D}" V=1 ARCH=${TARGET_ARCH} > CROSS_COMPILE=${TARGET_PREFIX} SKIP_STRIP=y" > > > > -- > ===================================================================== > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de > <javascript:> > ===================================================================== >
diff --git a/recipes-support/swupdate/swupdate.inc b/recipes-support/swupdate/swupdate.inc index 392af31..1c863bb 100644 --- a/recipes-support/swupdate/swupdate.inc +++ b/recipes-support/swupdate/swupdate.inc @@ -24,6 +24,8 @@ FILES_${PN}-lua += "${libdir}/lua/" FILES_${PN}-www = "/www/*" FILES_${PN} += "${libdir}/tmpfiles.d" +RDEPENDS_${PN}-www += "${PN}-tools" + S = "${WORKDIR}/git/" EXTRA_OEMAKE += " HOSTCC="${BUILD_CC}" HOSTCXX="${BUILD_CXX}" LD="${CC}" DESTDIR="${D}" V=1 ARCH=${TARGET_ARCH} CROSS_COMPILE=${TARGET_PREFIX} SKIP_STRIP=y"
swupdate-www requires the swupdate-progress service from swupdate-tools package. Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com> --- recipes-support/swupdate/swupdate.inc | 2 ++ 1 file changed, 2 insertions(+)