| Message ID | 1306317904-18740-1-git-send-email-panweiping3@gmail.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
On Wed, May 25, 2011 at 06:05:04PM +0800, Weiping Pan wrote: > xmit_hash_policy supports layer2+3 now, > and both balance-xor and 802.3ad use xmit_hash_policy. > > Signed-off-by: Weiping Pan <panweiping3@gmail.com> > --- > drivers/net/bonding/bond_main.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c > index 088fd84..d1f5606 100644 > --- a/drivers/net/bonding/bond_main.c > +++ b/drivers/net/bonding/bond_main.c > @@ -147,8 +147,7 @@ MODULE_PARM_DESC(lacp_rate, "LACPDU tx rate to request from 802.3ad partner " > module_param(ad_select, charp, 0); > MODULE_PARM_DESC(ad_select, "803.ad aggregation selection logic: stable (0, default), bandwidth (1), count (2)"); > module_param(xmit_hash_policy, charp, 0); > -MODULE_PARM_DESC(xmit_hash_policy, "XOR hashing method: 0 for layer 2 (default)" > - ", 1 for layer 3+4"); > +MODULE_PARM_DESC(xmit_hash_policy, "balance-xor and 802.3ad hashing method: 0 for layer 2 (default), 1 for layer 3+4, 2 for layer 2+3"); This is a good idea and a definite bug-fix. Thanks for posting it. I do not want to create a description that is longer than 80 characters in the source if I can help it. I went ahead and cleaned up all the descriptions and have posted a followup patch. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 088fd84..d1f5606 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -147,8 +147,7 @@ MODULE_PARM_DESC(lacp_rate, "LACPDU tx rate to request from 802.3ad partner " module_param(ad_select, charp, 0); MODULE_PARM_DESC(ad_select, "803.ad aggregation selection logic: stable (0, default), bandwidth (1), count (2)"); module_param(xmit_hash_policy, charp, 0); -MODULE_PARM_DESC(xmit_hash_policy, "XOR hashing method: 0 for layer 2 (default)" - ", 1 for layer 3+4"); +MODULE_PARM_DESC(xmit_hash_policy, "balance-xor and 802.3ad hashing method: 0 for layer 2 (default), 1 for layer 3+4, 2 for layer 2+3"); module_param(arp_interval, int, 0); MODULE_PARM_DESC(arp_interval, "arp interval in milliseconds"); module_param_array(arp_ip_target, charp, NULL, 0);
xmit_hash_policy supports layer2+3 now, and both balance-xor and 802.3ad use xmit_hash_policy. Signed-off-by: Weiping Pan <panweiping3@gmail.com> --- drivers/net/bonding/bond_main.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)