diff mbox series

[U-Boot,3/3] mx7ulp: Move SoC base address to a common file

Message ID 20191023140855.19446-3-festevam@gmail.com
State Accepted
Commit 9c27310ac23ce1966f9629d73973c458412a0085
Delegated to: Stefano Babic
Headers show
Series [U-Boot,1/3] mx7ulp_evk: Disable CONFIG_NET | expand

Commit Message

Fabio Estevam Oct. 23, 2019, 2:08 p.m. UTC
SoC base addresses should better go into a common SoC file instead
of repeating the definition in each board file.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 arch/arm/include/asm/arch-mx7ulp/imx-regs.h | 4 ++++
 include/configs/mx7ulp_evk.h                | 4 ----
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

Peng Fan Oct. 24, 2019, 1:10 a.m. UTC | #1
> Subject: [PATCH 3/3] mx7ulp: Move SoC base address to a common file
> 
> SoC base addresses should better go into a common SoC file instead of
> repeating the definition in each board file.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  arch/arm/include/asm/arch-mx7ulp/imx-regs.h | 4 ++++
>  include/configs/mx7ulp_evk.h                | 4 ----
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/include/asm/arch-mx7ulp/imx-regs.h
> b/arch/arm/include/asm/arch-mx7ulp/imx-regs.h
> index 3c82e9921e..9a420dc30b 100644
> --- a/arch/arm/include/asm/arch-mx7ulp/imx-regs.h
> +++ b/arch/arm/include/asm/arch-mx7ulp/imx-regs.h
> @@ -946,6 +946,10 @@
>  #define SNVS_LPCR_DPEN				(0x20)
>  #define SNVS_LPCR_SRTC_ENV			(0x1)
> 
> +#define SRC_BASE_ADDR			CMC1_RBASE
> +#define IRAM_BASE_ADDR			OCRAM_0_BASE
> +#define IOMUXC_BASE_ADDR		IOMUXC1_RBASE
> +
>  #if !(defined(__KERNEL_STRICT_NAMES) || defined(__ASSEMBLY__))
> 
>  #include <asm/types.h>
> diff --git a/include/configs/mx7ulp_evk.h b/include/configs/mx7ulp_evk.h
> index 141036310b..6d70fb45ae 100644
> --- a/include/configs/mx7ulp_evk.h
> +++ b/include/configs/mx7ulp_evk.h
> @@ -14,10 +14,6 @@
>  #define CONFIG_BOARD_POSTCLK_INIT
>  #define CONFIG_SYS_BOOTM_LEN		0x1000000
> 
> -#define SRC_BASE_ADDR			CMC1_RBASE
> -#define IRAM_BASE_ADDR			OCRAM_0_BASE
> -#define IOMUXC_BASE_ADDR		IOMUXC1_RBASE
> -
>  #define CONFIG_SYS_MMC_ENV_DEV          0	/* USDHC1 */
>  #define CONFIG_SYS_MMC_ENV_PART         0	/* user area */
>  #define CONFIG_MMCROOT                  "/dev/mmcblk0p2"  /*
> USDHC1 */

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> --
> 2.17.1
diff mbox series

Patch

diff --git a/arch/arm/include/asm/arch-mx7ulp/imx-regs.h b/arch/arm/include/asm/arch-mx7ulp/imx-regs.h
index 3c82e9921e..9a420dc30b 100644
--- a/arch/arm/include/asm/arch-mx7ulp/imx-regs.h
+++ b/arch/arm/include/asm/arch-mx7ulp/imx-regs.h
@@ -946,6 +946,10 @@ 
 #define SNVS_LPCR_DPEN				(0x20)
 #define SNVS_LPCR_SRTC_ENV			(0x1)
 
+#define SRC_BASE_ADDR			CMC1_RBASE
+#define IRAM_BASE_ADDR			OCRAM_0_BASE
+#define IOMUXC_BASE_ADDR		IOMUXC1_RBASE
+
 #if !(defined(__KERNEL_STRICT_NAMES) || defined(__ASSEMBLY__))
 
 #include <asm/types.h>
diff --git a/include/configs/mx7ulp_evk.h b/include/configs/mx7ulp_evk.h
index 141036310b..6d70fb45ae 100644
--- a/include/configs/mx7ulp_evk.h
+++ b/include/configs/mx7ulp_evk.h
@@ -14,10 +14,6 @@ 
 #define CONFIG_BOARD_POSTCLK_INIT
 #define CONFIG_SYS_BOOTM_LEN		0x1000000
 
-#define SRC_BASE_ADDR			CMC1_RBASE
-#define IRAM_BASE_ADDR			OCRAM_0_BASE
-#define IOMUXC_BASE_ADDR		IOMUXC1_RBASE
-
 #define CONFIG_SYS_MMC_ENV_DEV          0	/* USDHC1 */
 #define CONFIG_SYS_MMC_ENV_PART         0	/* user area */
 #define CONFIG_MMCROOT                  "/dev/mmcblk0p2"  /* USDHC1 */