| Message ID | 20191023122652.2999-2-fziglio@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] util/async: avoid useless cast | expand |
Le 23/10/2019 à 14:26, Frediano Ziglio a écrit : > If rfd is equal to wfd the file descriptor is closed but > rfd will still have the closed value. > The EventNotifier structure should not be used again after calling > event_notifier_cleanup or should be initialized again but make > sure to not have dandling file descriptors around. > > Signed-off-by: Frediano Ziglio <fziglio@redhat.com> > --- > util/event_notifier-posix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/util/event_notifier-posix.c b/util/event_notifier-posix.c > index 73c4046b58..00d93204f9 100644 > --- a/util/event_notifier-posix.c > +++ b/util/event_notifier-posix.c > @@ -80,8 +80,8 @@ void event_notifier_cleanup(EventNotifier *e) > { > if (e->rfd != e->wfd) { > close(e->rfd); > - e->rfd = -1; > } > + e->rfd = -1; > close(e->wfd); > e->wfd = -1; > } > Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Le 23/10/2019 à 14:26, Frediano Ziglio a écrit : > If rfd is equal to wfd the file descriptor is closed but > rfd will still have the closed value. > The EventNotifier structure should not be used again after calling > event_notifier_cleanup or should be initialized again but make > sure to not have dandling file descriptors around. > > Signed-off-by: Frediano Ziglio <fziglio@redhat.com> > --- > util/event_notifier-posix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/util/event_notifier-posix.c b/util/event_notifier-posix.c > index 73c4046b58..00d93204f9 100644 > --- a/util/event_notifier-posix.c > +++ b/util/event_notifier-posix.c > @@ -80,8 +80,8 @@ void event_notifier_cleanup(EventNotifier *e) > { > if (e->rfd != e->wfd) { > close(e->rfd); > - e->rfd = -1; > } > + e->rfd = -1; > close(e->wfd); > e->wfd = -1; > } > Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/util/event_notifier-posix.c b/util/event_notifier-posix.c index 73c4046b58..00d93204f9 100644 --- a/util/event_notifier-posix.c +++ b/util/event_notifier-posix.c @@ -80,8 +80,8 @@ void event_notifier_cleanup(EventNotifier *e) { if (e->rfd != e->wfd) { close(e->rfd); - e->rfd = -1; } + e->rfd = -1; close(e->wfd); e->wfd = -1; }
If rfd is equal to wfd the file descriptor is closed but rfd will still have the closed value. The EventNotifier structure should not be used again after calling event_notifier_cleanup or should be initialized again but make sure to not have dandling file descriptors around. Signed-off-by: Frediano Ziglio <fziglio@redhat.com> --- util/event_notifier-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)