| Message ID | 20191018010625.20392-1-joel@jms.id.au |
|---|---|
| State | Superseded |
| Headers | show |
| Series | p9-kernel.dts: Fix sbefifo-mem dtc warning | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch master (8b4611b5d8e7e2279fe4aa80c892fcfe10aa398d) |
| snowpatch_ozlabs/build-multiarch | success | Test build-multiarch on branch master |
On Fri, 2019-10-18 at 11:36 +1030, Joel Stanley wrote: > p9-kernel.dts:1212.18-1214.6: Warning (unit_address_vs_reg): > /kernelfsi@0/sbefifo@2400/sbefifo-mem@0: node has a unit name, but no > reg property > p9-kernel.dts:2422.19-2424.7: Warning (unit_address_vs_reg): > /kernelfsi@0/hmfsi@100000/sbefifo@2400/sbefifo-mem@0: node has a unit > name, but no reg property > Just adding "<0>" reg generates lot more warnings! Warning (reg_format): /kernelfsi@0/sbefifo@2400/sbefifo-mem@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) Warning (reg_format): /kernelfsi@0/hmfsi@100000/sbefifo@2400 /sbefifo-mem@0:reg: property has invalid length (4 bytes) (#address- cells == 2, #size-cells == 1) Warning (pci_device_reg): Failed prerequisite 'reg_format' Warning (pci_device_bus_num): Failed prerequisite 'reg_format' Warning (simple_bus_reg): Failed prerequisite 'reg_format' Warning (avoid_default_addr_size): /kernelfsi@0/sbefifo@2400 /sbefifo-mem@0: Relying on default #address-cells value Warning (avoid_default_addr_size): /kernelfsi@0/sbefifo@2400 /sbefifo-mem@0: Relying on default #size-cells value Warning (avoid_default_addr_size): /kernelfsi@0/hmfsi@100000 /sbefifo@2400/sbefifo-mem@0: Relying on default #address-cells value Warning (avoid_default_addr_size): /kernelfsi@0/hmfsi@100000 /sbefifo@2400/sbefifo-mem@0: Relying on default #size-cells value Warning (avoid_unnecessary_addr_size): Failed prerequisite 'avoid_default_addr_size' Warning (unique_unit_address): Failed prerequisite 'avoid_default_addr_size' Correct solution would be to add #address-cells and #size-cells for sbefifo@2400 and then using the right number of arguments for reg property. > Signed-off-by: Joel Stanley <joel@jms.id.au> > --- > p9-kernel.dts.m4 | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/p9-kernel.dts.m4 b/p9-kernel.dts.m4 > index aa4bcac16fcb..39c072fb3cec 100644 > --- a/p9-kernel.dts.m4 > +++ b/p9-kernel.dts.m4 > @@ -30,7 +30,8 @@ > device-path = "/dev/sbefifo1"; > > sbefifo-mem@0 { > - compatible = "ibm,sbefifo-mem"; > + reg = <0>; > + compatible = "ibm,sbefifo-mem"; > }; > }; > > @@ -59,7 +60,8 @@ > device-path = "/dev/sbefifo2"; > > sbefifo-mem@0 { > - compatible = "ibm,sbefifo-mem"; > + reg = <0>; > + compatible = "ibm,sbefifo-mem"; > }; > }; > }; > -- > 2.23.0 > Amitay.
diff --git a/p9-kernel.dts.m4 b/p9-kernel.dts.m4 index aa4bcac16fcb..39c072fb3cec 100644 --- a/p9-kernel.dts.m4 +++ b/p9-kernel.dts.m4 @@ -30,7 +30,8 @@ device-path = "/dev/sbefifo1"; sbefifo-mem@0 { - compatible = "ibm,sbefifo-mem"; + reg = <0>; + compatible = "ibm,sbefifo-mem"; }; }; @@ -59,7 +60,8 @@ device-path = "/dev/sbefifo2"; sbefifo-mem@0 { - compatible = "ibm,sbefifo-mem"; + reg = <0>; + compatible = "ibm,sbefifo-mem"; }; }; };
p9-kernel.dts:1212.18-1214.6: Warning (unit_address_vs_reg): /kernelfsi@0/sbefifo@2400/sbefifo-mem@0: node has a unit name, but no reg property p9-kernel.dts:2422.19-2424.7: Warning (unit_address_vs_reg): /kernelfsi@0/hmfsi@100000/sbefifo@2400/sbefifo-mem@0: node has a unit name, but no reg property Signed-off-by: Joel Stanley <joel@jms.id.au> --- p9-kernel.dts.m4 | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)