Message ID | 20191003220613.10791-2-jack@suse.cz |
---|---|
State | Superseded |
Headers | show |
Series | ext4: Fix transaction overflow due to revoke descriptors | expand |
On Fri, Oct 04, 2019 at 12:05:48AM +0200, Jan Kara wrote: > jbd2_journal_next_log_block() does not look at > transaction->t_outstanding_credits. Remove the misleading comment. > > Signed-off-by: Jan Kara <jack@suse.cz> Looks good, you can add: Reviewed-by: Theodore Ts'o <tytso@mit.edu>
diff --git a/fs/jbd2/commit.c b/fs/jbd2/commit.c index 132fb92098c7..c6d39f2ad828 100644 --- a/fs/jbd2/commit.c +++ b/fs/jbd2/commit.c @@ -642,8 +642,7 @@ void jbd2_journal_commit_transaction(journal_t *journal) /* * start_this_handle() uses t_outstanding_credits to determine - * the free space in the log, but this counter is changed - * by jbd2_journal_next_log_block() also. + * the free space in the log. */ atomic_dec(&commit_transaction->t_outstanding_credits);
jbd2_journal_next_log_block() does not look at transaction->t_outstanding_credits. Remove the misleading comment. Signed-off-by: Jan Kara <jack@suse.cz> --- fs/jbd2/commit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)