| Message ID | 20191018034116.10259-1-ajd@linux.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | tests: Rename inaccurately named test_patchwork_from_header | expand |
Andrew Donnellan <ajd@linux.ibm.com> writes: > The test_patchwork_from_header test claims to test for the presence of the > X-Patchwork-From header, when we actually call it X-Patchwork-Sender. X-Patchwork-Submitter, surely? (I didn't even know that one existed!) Regards, Daniel > > Fix it. > > Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com> > --- > patchwork/tests/test_mboxviews.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/patchwork/tests/test_mboxviews.py b/patchwork/tests/test_mboxviews.py > index 3854a856c4db..ab0c1669944f 100644 > --- a/patchwork/tests/test_mboxviews.py > +++ b/patchwork/tests/test_mboxviews.py > @@ -153,8 +153,8 @@ class MboxHeaderTest(TestCase): > patch.url_msgid])) > self.assertContains(response, 'X-Patchwork-Delegate: %s' % user.email) > > - def test_patchwork_from_header(self): > - """Validate inclusion of generated 'X-Patchwork-From' header.""" > + def test_patchwork_submitter_header(self): > + """Validate inclusion of generated 'X-Patchwork-Submitter' header.""" > email = 'jon@doe.com' > from_header = 'From: Jon Doe <%s>\n' % email > > -- > 2.20.1 > > _______________________________________________ > Patchwork mailing list > Patchwork@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/patchwork
On 18/10/19 3:02 pm, Daniel Axtens wrote: > Andrew Donnellan <ajd@linux.ibm.com> writes: > >> The test_patchwork_from_header test claims to test for the presence of the >> X-Patchwork-From header, when we actually call it X-Patchwork-Sender. > X-Patchwork-Submitter, surely? Wow, the irony of me getting this wrong in the commit message... I get it right in the actual commit! Can you fix in merge or do you want me to respin? > > (I didn't even know that one existed!) > > Regards, > Daniel >> >> Fix it. >> >> Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com> >> --- >> patchwork/tests/test_mboxviews.py | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/patchwork/tests/test_mboxviews.py b/patchwork/tests/test_mboxviews.py >> index 3854a856c4db..ab0c1669944f 100644 >> --- a/patchwork/tests/test_mboxviews.py >> +++ b/patchwork/tests/test_mboxviews.py >> @@ -153,8 +153,8 @@ class MboxHeaderTest(TestCase): >> patch.url_msgid])) >> self.assertContains(response, 'X-Patchwork-Delegate: %s' % user.email) >> >> - def test_patchwork_from_header(self): >> - """Validate inclusion of generated 'X-Patchwork-From' header.""" >> + def test_patchwork_submitter_header(self): >> + """Validate inclusion of generated 'X-Patchwork-Submitter' header.""" >> email = 'jon@doe.com' >> from_header = 'From: Jon Doe <%s>\n' % email >> >> -- >> 2.20.1 >> >> _______________________________________________ >> Patchwork mailing list >> Patchwork@lists.ozlabs.org >> https://lists.ozlabs.org/listinfo/patchwork
Andrew Donnellan <ajd@linux.ibm.com> writes: > On 18/10/19 3:02 pm, Daniel Axtens wrote: >> Andrew Donnellan <ajd@linux.ibm.com> writes: >> >>> The test_patchwork_from_header test claims to test for the presence of the >>> X-Patchwork-From header, when we actually call it X-Patchwork-Sender. >> X-Patchwork-Submitter, surely? > > Wow, the irony of me getting this wrong in the commit message... I get > it right in the actual commit! > > Can you fix in merge or do you want me to respin? I'll fix it and merge now :) Daniel. > >> >> (I didn't even know that one existed!) >> >> Regards, >> Daniel >>> >>> Fix it. >>> >>> Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com> >>> --- >>> patchwork/tests/test_mboxviews.py | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/patchwork/tests/test_mboxviews.py b/patchwork/tests/test_mboxviews.py >>> index 3854a856c4db..ab0c1669944f 100644 >>> --- a/patchwork/tests/test_mboxviews.py >>> +++ b/patchwork/tests/test_mboxviews.py >>> @@ -153,8 +153,8 @@ class MboxHeaderTest(TestCase): >>> patch.url_msgid])) >>> self.assertContains(response, 'X-Patchwork-Delegate: %s' % user.email) >>> >>> - def test_patchwork_from_header(self): >>> - """Validate inclusion of generated 'X-Patchwork-From' header.""" >>> + def test_patchwork_submitter_header(self): >>> + """Validate inclusion of generated 'X-Patchwork-Submitter' header.""" >>> email = 'jon@doe.com' >>> from_header = 'From: Jon Doe <%s>\n' % email >>> >>> -- >>> 2.20.1 >>> >>> _______________________________________________ >>> Patchwork mailing list >>> Patchwork@lists.ozlabs.org >>> https://lists.ozlabs.org/listinfo/patchwork > > -- > Andrew Donnellan OzLabs, ADL Canberra > ajd@linux.ibm.com IBM Australia Limited
diff --git a/patchwork/tests/test_mboxviews.py b/patchwork/tests/test_mboxviews.py index 3854a856c4db..ab0c1669944f 100644 --- a/patchwork/tests/test_mboxviews.py +++ b/patchwork/tests/test_mboxviews.py @@ -153,8 +153,8 @@ class MboxHeaderTest(TestCase): patch.url_msgid])) self.assertContains(response, 'X-Patchwork-Delegate: %s' % user.email) - def test_patchwork_from_header(self): - """Validate inclusion of generated 'X-Patchwork-From' header.""" + def test_patchwork_submitter_header(self): + """Validate inclusion of generated 'X-Patchwork-Submitter' header.""" email = 'jon@doe.com' from_header = 'From: Jon Doe <%s>\n' % email
The test_patchwork_from_header test claims to test for the presence of the X-Patchwork-From header, when we actually call it X-Patchwork-Sender. Fix it. Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com> --- patchwork/tests/test_mboxviews.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)