| Message ID | 20191017122640.22976-1-yuehaibing@huawei.com |
|---|---|
| Headers | show
Return-Path: <linux-gpio-owner@vger.kernel.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=huawei.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 46v8996g42z9sPW for <incoming@patchwork.ozlabs.org>; Thu, 17 Oct 2019 23:48:29 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502604AbfJQMs2 (ORCPT <rfc822;incoming@patchwork.ozlabs.org>); Thu, 17 Oct 2019 08:48:28 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:59328 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729344AbfJQMs1 (ORCPT <rfc822;linux-gpio@vger.kernel.org>); Thu, 17 Oct 2019 08:48:27 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 47C9634C1F89D02A68CC; Thu, 17 Oct 2019 20:48:11 +0800 (CST) Received: from localhost (10.133.213.239) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.439.0; Thu, 17 Oct 2019 20:48:01 +0800 From: YueHaibing <yuehaibing@huawei.com> To: <linus.walleij@linaro.org>, <manivannan.sadhasivam@linaro.org>, <afaerber@suse.de>, <f.fainelli@gmail.com>, <rjui@broadcom.com>, <sbranden@broadcom.com>, <bcm-kernel-feedback-list@broadcom.com>, <jesper.nilsson@axis.com>, <lars.persson@axis.com>, <ludovic.desroches@microchip.com>, <nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com>, <baruch@tkos.co.il> CC: <linux-arm-kernel@lists.infradead.org>, <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@axis.com>, <linux-oxnas@groups.io>, <linux-renesas-soc@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>, <linux-tegra@vger.kernel.org>, <vz@mleia.com>, <narmstrong@baylibre.com>, <geert+renesas@glider.be>, <daniel@zonque.org>, <haojian.zhuang@gmail.com>, <wens@csie.org>, <thierry.reding@gmail.com>, <jonathanh@nvidia.com>, <agross@kernel.org>, YueHaibing <yuehaibing@huawei.com> Subject: [PATCH -next 00/30] pinctrl: use devm_platform_ioremap_resource() to simplify code Date: Thu, 17 Oct 2019 20:26:10 +0800 Message-ID: <20191017122640.22976-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.133.213.239] X-CFilter-Loop: Reflected Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: <linux-gpio.vger.kernel.org> X-Mailing-List: linux-gpio@vger.kernel.org |
| Series |
pinctrl: use devm_platform_ioremap_resource() to simplify code
|
expand
|
Hi, On 17/10/2019 20:26:10+0800, YueHaibing wrote: > devm_platform_ioremap_resource() internally have platform_get_resource() > and devm_ioremap_resource() in it. So instead of calling them separately > use devm_platform_ioremap_resource() directly. > Shouldn't we stop with this insanity? The net gain is exactly 2 lines per driver and this puts the full review load on the maintainers. We end up with crap like: https://lore.kernel.org/lkml/9bbcce19c777583815c92ce3c2ff2586@www.loen.fr/ What is the end goal here ? platform_get_resource and devm_ioremap_resource will have to stay even after you have done the conversion.
devm_platform_ioremap_resource() internally have platform_get_resource() and devm_ioremap_resource() in it. So instead of calling them separately use devm_platform_ioremap_resource() directly. YueHaibing (30): pinctrl: pxa25x: use devm_platform_ioremap_resource() to simplify code pinctrl: pxa27x: use devm_platform_ioremap_resource() to simplify code pinctrl: cygnus-mux: use devm_platform_ioremap_resource() to simplify code pinctrl: pic32: use devm_platform_ioremap_resource() to simplify code pinctrl: nsp-gpio: use devm_platform_ioremap_resource() to simplify code pinctrl: nsp: use devm_platform_ioremap_resource() to simplify code pinctrl: ns2: use devm_platform_ioremap_resource() to simplify code pinctrl: bcm281xx: use devm_platform_ioremap_resource() to simplify code pinctrl: sunxi: use devm_platform_ioremap_resource() to simplify code pinctrl: tegra: use devm_platform_ioremap_resource() to simplify code pinctrl: msm: use devm_platform_ioremap_resource() to simplify code pinctrl: spear: use devm_platform_ioremap_resource() to simplify code pinctrl: zte: use devm_platform_ioremap_resource() to simplify code pinctrl: at91: use devm_platform_ioremap_resource() to simplify code pinctrl: oxnas: use devm_platform_ioremap_resource() to simplify code pinctrl: pistachio: use devm_platform_ioremap_resource() to simplify code pinctrl: lpc18xx: use devm_platform_ioremap_resource() to simplify code pinctrl: da850-pupd: use devm_platform_ioremap_resource() to simplify code pinctrl: tb10x: use devm_platform_ioremap_resource() to simplify code pinctrl: u300: use devm_platform_ioremap_resource() to simplify code pinctrl: vt8500: use devm_platform_ioremap_resource() to simplify code pinctrl: xway: use devm_platform_ioremap_resource() to simplify code pinctrl: rza2: use devm_platform_ioremap_resource() to simplify code pinctrl: digicolor: use devm_platform_ioremap_resource() to simplify code pinctrl: coh901: use devm_platform_ioremap_resource() to simplify code pinctrl: bm1880: use devm_platform_ioremap_resource() to simplify code pinctrl: artpec6: use devm_platform_ioremap_resource() to simplify code pinctrl: actions: use devm_platform_ioremap_resource() to simplify code pinctrl: at91-pio4: use devm_platform_ioremap_resource() to simplify code pinctrl: iproc: use devm_platform_ioremap_resource() to simplify code drivers/pinctrl/actions/pinctrl-owl.c | 4 +--- drivers/pinctrl/bcm/pinctrl-bcm281xx.c | 4 +--- drivers/pinctrl/bcm/pinctrl-cygnus-mux.c | 7 ++----- drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 3 +-- drivers/pinctrl/bcm/pinctrl-ns2-mux.c | 6 ++---- drivers/pinctrl/bcm/pinctrl-nsp-gpio.c | 7 ++----- drivers/pinctrl/bcm/pinctrl-nsp-mux.c | 6 ++---- drivers/pinctrl/pinctrl-artpec6.c | 4 +--- drivers/pinctrl/pinctrl-at91-pio4.c | 3 +-- drivers/pinctrl/pinctrl-at91.c | 4 +--- drivers/pinctrl/pinctrl-bm1880.c | 4 +--- drivers/pinctrl/pinctrl-coh901.c | 4 +--- drivers/pinctrl/pinctrl-da850-pupd.c | 4 +--- drivers/pinctrl/pinctrl-digicolor.c | 4 +--- drivers/pinctrl/pinctrl-lpc18xx.c | 4 +--- drivers/pinctrl/pinctrl-oxnas.c | 4 +--- drivers/pinctrl/pinctrl-pic32.c | 4 +--- drivers/pinctrl/pinctrl-pistachio.c | 4 +--- drivers/pinctrl/pinctrl-rza2.c | 4 +--- drivers/pinctrl/pinctrl-tb10x.c | 4 +--- drivers/pinctrl/pinctrl-u300.c | 4 +--- drivers/pinctrl/pinctrl-xway.c | 4 +--- drivers/pinctrl/pxa/pinctrl-pxa25x.c | 13 ++++--------- drivers/pinctrl/pxa/pinctrl-pxa27x.c | 13 ++++--------- drivers/pinctrl/qcom/pinctrl-msm.c | 3 +-- drivers/pinctrl/spear/pinctrl-plgpio.c | 4 +--- drivers/pinctrl/spear/pinctrl-spear.c | 4 +--- drivers/pinctrl/sunxi/pinctrl-sunxi.c | 4 +--- drivers/pinctrl/tegra/pinctrl-tegra-xusb.c | 4 +--- drivers/pinctrl/tegra/pinctrl-tegra.c | 3 +-- drivers/pinctrl/vt8500/pinctrl-wmt.c | 4 +--- drivers/pinctrl/zte/pinctrl-zx.c | 4 +--- 32 files changed, 42 insertions(+), 110 deletions(-)